From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8FF6C3A5A1 for ; Sun, 25 Aug 2019 15:04:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73E6520850 for ; Sun, 25 Aug 2019 15:04:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=web.de header.i=@web.de header.b="eVYx9Xx+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73E6520850 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1u3z-0002i4-EB for qemu-devel@archiver.kernel.org; Sun, 25 Aug 2019 11:04:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49888) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1tyY-0001vn-KL for qemu-devel@nongnu.org; Sun, 25 Aug 2019 10:58:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1tyX-0005uH-O9 for qemu-devel@nongnu.org; Sun, 25 Aug 2019 10:58:38 -0400 Received: from mout.web.de ([212.227.17.11]:49127) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1tyX-0005nw-Bx for qemu-devel@nongnu.org; Sun, 25 Aug 2019 10:58:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1566745105; bh=WU6VhO79hD5gewC9QLl9xD4QkWHlpphrOQjpN7vfT8k=; h=X-UI-Sender-Class:Subject:From:To:References:Date:In-Reply-To; b=eVYx9Xx+V7ssw5Tvm30Nj1zkdQF+w5ngzoXlFGU2L07KgaNRxZ7YGnJkLrohKaRgi eVeZ8z8jMR4OXlP5S1VgYBsv9AUmqt2qU/MdkAVVgYv8FtkEmtElbJ21xv71ZBy9Tz 85c1TBE3A6Eh9hv05piuD2ZtJIlYlBWf86YtakZc= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.10] ([95.157.55.156]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LyDph-1iGOd9263p-015Xw2; Sun, 25 Aug 2019 16:58:25 +0200 From: Jan Kiszka To: qemu-devel , Paolo Bonzini , Richard Henderson , Eduardo Habkost References: Message-ID: <90ea3127-5e26-ed2a-4ad7-d30445bcf53a@web.de> Date: Sun, 25 Aug 2019 16:58:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:iHM/3HaElcQOtD7YkcIHIJej3PXUx+aaBZPtgsJpYr+NW19KAHe nd7GpYfodttAz4VpIkehfZrZgS17URZMA4xQIZVK+hoFnwOWSLTRvyqHD1Wm7WHpDM1yIWd vthYKcNFoQPahXsRh2eGSw6CE+IR8fCnj/nA5FMsIyoMYMq6jJ8bAZUkJqOkFWCFM5HnAwJ rQtwW0HvXEOzNZRsVgBAQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:1onk8D612uA=:+wFhJhHrp40CaoSds61qPs AACzfIAQwlJ6ldr75DsU3r5fD4mASKSBCJ2yLeMQKQ92njexZCJ7B2PL8dOZOTiVeE+nsMeDy 2Yd84KAtAyXtHp+sGwPkBH4GshIk8Z21gii1Y3dFxyOFCQ4bC6oDGHX0C3c8rdbKTP5Vh/uPj Gz2J2qEs22jnd2kL3RB4GY45L6oeKZNjjanzQbfzE/x2PRWYiUbrqDJrvSHoV9mIE6sPYViAr 6jJq6JZ0I3Wuvumj0sfQ2lZAfpEyhhU8NSgYSfrEP/dZFCeoZgq4iQrT4ChZ1Ym7FbeM24dcP DrA77rRpeBdMwuRXa5WD55bYJOdTsuvdcrefJUJ7MGEdscGa5PsZvrfC0WeSh0qlhVfLskQ1F eITupDjI2ymEJkYUjySNyeB+LAMtmGVhiz6keJS1i5F92A9pnapCyvZjJWgp4ejEqJP4uyrqI 8QFstfSmOk6OguFPlfuAOL8dFQ2FKjal4nBRfuQKjzDcNI2KisOmHYzLN9Fnqy1oJUfPDymZF Io38XtS6ZLnBkTDKjBpDWJe0wQK7cJzVz8TklFLku11zvjSLa2SHCvHr+5JRB8mWfILmV+N6W mHrNiY3PgzvV++SWhnclWGK16moaHJ9Oz4zLlfG9WW7OCreZb9GxRHBynp6nZLXy/aB5UhfMZ JxcH+exPImoc23aairLUcwrO9LcNyGwE7GKUbgHvIGwwD89KZt4nXqU2T1aTVgh2Ucv7Al3Z+ DKMZJYHyjMZl84kjN8G/WO+NDlzhVF6Gi6HbEqRlVMcXgf20gnpz3z/UYQ06OEauBaO80Svxy Do8HQiMJ3IxrEnmx/rMm4bAcSA3D0WJE20tphTNbm8ti0LJ+phqksNwywydx/nxao8BXS4nI+ lYF26rJK9hANkA3YrZhT6Z9uvsfDCw7Ix9GgJDrYMCVXqCFTvnSLYn58oP+/KXcHThZXNgDr5 tw1NFaOhKKuLUw5dzNSr2pvupVEfNVyPI+eMNncMPMRdzbS8yx16uyOnebs50OeCh3KBgtAaw nELGcNSyCxicAO+PRaRVhwa1aJH4cpWCASWyvg1I2QOJ4mk5KOlxtfa8KhDzrkyx3+8CDMClw 0oM3PKYetqPOxG7ypM16XbdbaXVXC9j+bxlm57WgEM3wIJBtALfV2ZZbD76MRZlTQhVyu6WKb ewZUEPCCK/wb1zqMlzHW5dBoCDoJHDM8cpWUvjg3iKQl8/VQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.11 Subject: Re: [Qemu-devel] [PATCH] i386/vmmouse: Properly reset state X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 21.07.19 10:58, Jan Kiszka wrote: > From: Jan Kiszka > > nb_queue was not zeroed so that we no longer delivered events if a > previous guest left the device in an overflow state. > > The state of absolute does not matter as the next vmmouse_update_handler > call will align it again. > > Signed-off-by: Jan Kiszka > --- > hw/i386/vmmouse.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/i386/vmmouse.c b/hw/i386/vmmouse.c > index 5d2d278be4..e335bd07da 100644 > --- a/hw/i386/vmmouse.c > +++ b/hw/i386/vmmouse.c > @@ -257,6 +257,7 @@ static void vmmouse_reset(DeviceState *d) > VMMouseState *s =3D VMMOUSE(d); > > s->queue_size =3D VMMOUSE_QUEUE_SIZE; > + s->nb_queue =3D 0; > > vmmouse_disable(s); > } > -- > 2.16.4 > > Ping - or who is looking after this? Jan