From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D66EC31E5B for ; Mon, 17 Jun 2019 20:45:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E20220644 for ; Mon, 17 Jun 2019 20:45:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RuTyIkd9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E20220644 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcyVE-0001PL-0Q for qemu-devel@archiver.kernel.org; Mon, 17 Jun 2019 16:45:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39608) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcyTN-0000TJ-L1 for qemu-devel@nongnu.org; Mon, 17 Jun 2019 16:43:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcyTM-0006Fo-M8 for qemu-devel@nongnu.org; Mon, 17 Jun 2019 16:43:25 -0400 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:34698) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcyTM-0006Eo-Ci for qemu-devel@nongnu.org; Mon, 17 Jun 2019 16:43:24 -0400 Received: by mail-pg1-x544.google.com with SMTP id p10so6443349pgn.1 for ; Mon, 17 Jun 2019 13:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Xsrpd3kMOPUZ4MznF4kLmVwCzElCqGBrIkNNQsGG4lM=; b=RuTyIkd94xIsdEdLRyQF2GA68HUO7OfTft6wm13tQLpBKbI2yme/zdnR+dTqs7dqNY W01Il4QfuchPCQX5wWSNWmqQLGOB91n8ybaqUmPF0w0LmTIzAIXks3jOnFkpnsCsC0ba Vk7maYM4tP4gaVh34vpHhnhzdit9uus/kvfrkm4eijr/KH0CYoBXRu1+cAkHO/li+7rh CKi/SemhuKme6yPiTP8/p8kLJee1wz7hw/nZJaB7xDcZ5zuNE87C8SU4qOPPQlo+lm6Y dGQ1fAmXs9fzymLKhwfDWWTHN9oeUIiEs6uI5hLB6ct5MiuZ8WQ6LqoGQOfWSB5St/Pf xZPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Xsrpd3kMOPUZ4MznF4kLmVwCzElCqGBrIkNNQsGG4lM=; b=Tv1qosiotK0HEk1B6fpnHV119VjBWx6z34o4jqdIXHB0EaF12xurzBJDTv+wMqKLJX /hGsoMWUTTh3V8i+gjxWOAMhhbNAK588PG1iyfhT4da37Fet1BEExXIweQMY0fjlstQR /6xORbR+5tgNRyxWDhe3iVUxodA7XuYMwxez6+gd+91aUkNoa8hBwLKVcr6Xidrirvl/ PgZfexplY9jy8i1NnbX74iX951WmSNFv4nxIKTjSWmirOOa/iwxxCViPvwhcXcKs5siZ pRqdzzSYLj9Ct43oIdiSELmrwenPv/LbnCyVmVIW4oGawzRHgeAJFwalI6LEMwSnYnMf OmkQ== X-Gm-Message-State: APjAAAUDiU7GOlTk1DRFj/5DVzYfidSJyXtWdYMMQ6mdWuICC9WA5eZb guDFCzntB86fG9JKIJHnZEycqg== X-Google-Smtp-Source: APXvYqwT4TrSq/tYqkZI8KVRFfwlC/jz0aeG4/w/ZJz6qmgR0SZofhxlbBCEPeNkxfOxJYJjhfqWCg== X-Received: by 2002:a17:90a:3270:: with SMTP id k103mr907037pjb.54.1560804201960; Mon, 17 Jun 2019 13:43:21 -0700 (PDT) Received: from [192.168.1.11] (97-113-2-33.tukw.qwest.net. [97.113.2.33]) by smtp.gmail.com with ESMTPSA id l63sm13161048pfl.181.2019.06.17.13.43.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 13:43:21 -0700 (PDT) To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org References: <20190614171200.21078-1-alex.bennee@linaro.org> <20190614171200.21078-16-alex.bennee@linaro.org> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: <92083b56-a36d-d5a1-50b0-09749d056d70@linaro.org> Date: Mon, 17 Jun 2019 13:43:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190614171200.21078-16-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::544 Subject: Re: [Qemu-devel] [PATCH v3 15/50] tcg: add MO_HADDR to TCGMemOp X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Emilio G. Cota" , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/14/19 10:11 AM, Alex Bennée wrote: > + /* > + * SoftMMU-only: if set, the TCG backend puts the corresponding host address > + * in CPUArchState.hostaddr. > + */ > + MO_HSHIFT = MO_ASHIFT + 3, > + MO_HADDR = 1 << MO_HSHIFT, FYI, Alex and I talked about recomputing the host address within the helper. For at least a few of the hosts, we currently never compute the full host address into a single register -- we use reg+reg addressing when possible. It's only a couple of instructions to re-compute, given that we know that the tlb lookup succeeded, and importantly they are all out of line and not bloating the inline code further. r~