From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FACBC31E5B for ; Tue, 18 Jun 2019 16:07:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 442E320B1F for ; Tue, 18 Jun 2019 16:07:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 442E320B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59310 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdGdX-0001xL-43 for qemu-devel@archiver.kernel.org; Tue, 18 Jun 2019 12:07:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42757) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdFPu-0002Oo-Ge for qemu-devel@nongnu.org; Tue, 18 Jun 2019 10:48:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdFPt-0002NW-Cq for qemu-devel@nongnu.org; Tue, 18 Jun 2019 10:48:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38952) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hdFPr-0002Ks-3y; Tue, 18 Jun 2019 10:48:55 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5AC1A223882; Tue, 18 Jun 2019 14:48:54 +0000 (UTC) Received: from [10.3.116.44] (ovpn-116-44.phx2.redhat.com [10.3.116.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AEB28608A7; Tue, 18 Jun 2019 14:48:53 +0000 (UTC) To: Max Reitz , qemu-block@nongnu.org References: <20190612221004.2317-1-mreitz@redhat.com> <20190612221004.2317-30-mreitz@redhat.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <92ec8a78-18b1-946a-cbc8-847377b0a127@redhat.com> Date: Tue, 18 Jun 2019 09:48:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190612221004.2317-30-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oBrQOZVDoj0ilT3BMDLyV5P9fsTFu33jV" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 18 Jun 2019 14:48:54 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v5 29/42] nbd: Use CAF when looking for dirty bitmap X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oBrQOZVDoj0ilT3BMDLyV5P9fsTFu33jV Content-Type: multipart/mixed; boundary="42zE5ZIbZChrAhgx7GbmSH3VCRWkgOU61"; protected-headers="v1" From: Eric Blake To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Message-ID: <92ec8a78-18b1-946a-cbc8-847377b0a127@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 29/42] nbd: Use CAF when looking for dirty bitmap References: <20190612221004.2317-1-mreitz@redhat.com> <20190612221004.2317-30-mreitz@redhat.com> In-Reply-To: <20190612221004.2317-30-mreitz@redhat.com> --42zE5ZIbZChrAhgx7GbmSH3VCRWkgOU61 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/12/19 5:09 PM, Max Reitz wrote: > When looking for a dirty bitmap to share, we should handle filters by > just including them in the search (so they do not break backing chains)= =2E >=20 > Signed-off-by: Max Reitz > --- > nbd/server.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake >=20 > diff --git a/nbd/server.c b/nbd/server.c > index aeca3893fe..0d51d46b81 100644 > --- a/nbd/server.c > +++ b/nbd/server.c > @@ -1508,13 +1508,13 @@ NBDExport *nbd_export_new(BlockDriverState *bs,= uint64_t dev_offset, > if (bitmap) { > BdrvDirtyBitmap *bm =3D NULL; > =20 > - while (true) { > + while (bs) { > bm =3D bdrv_find_dirty_bitmap(bs, bitmap); > - if (bm !=3D NULL || bs->backing =3D=3D NULL) { > + if (bm !=3D NULL) { > break; > } > =20 > - bs =3D bs->backing->bs; > + bs =3D bdrv_filtered_bs(bs); > } > =20 > if (bm =3D=3D NULL) { >=20 --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --42zE5ZIbZChrAhgx7GbmSH3VCRWkgOU61-- --oBrQOZVDoj0ilT3BMDLyV5P9fsTFu33jV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl0I+dQACgkQp6FrSiUn Q2pxggf/X/8x+4yy3tXoKzDbbxRlqVSl/aCpgX/MB+aGgrcmSaymuDaVgVI5oniz uSt2yTzcGk/p8H30cvfMvC77IT0gMlnAfDn4AWPEttn0JBIl5SLbR0QEYXaHT3mf w7+5PXmgBDEzMTF/fASyn9rdqt5dvwd3g3gQksPMDF1uY3Wm+xo6xwojZbT8SQ6n cwkmHlOcCoKBzcYtQ2k/RjtMhnp7oLsf7ALF4rQKs03xGRyfKAZliOcwvS37eheS sY4/ach9iwzMZr0vOCGyIwoFK1vposYlF93JYpx1UJL6UPzGcW0JZgqNgHIL4rv4 XyKjAfCPynnwj3Pl26CX/mZBx/M0KQ== =33Js -----END PGP SIGNATURE----- --oBrQOZVDoj0ilT3BMDLyV5P9fsTFu33jV--