From: Connor Kuehl <ckuehl@redhat.com>
To: Tom Lendacky <thomas.lendacky@amd.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Jiri Slaby <jslaby@suse.cz>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 2/4] sev/i386: Allow AP booting under SEV-ES
Date: Wed, 26 Aug 2020 14:07:39 -0500 [thread overview]
Message-ID: <93275d7f-1bfd-c115-be4b-3d20952bf376@redhat.com> (raw)
In-Reply-To: <a3fc1bfb697a85865710fa99a3e1169e7d355a18.1598382343.git.thomas.lendacky@amd.com>
On 8/25/20 2:05 PM, Tom Lendacky wrote:
> From: Tom Lendacky <thomas.lendacky@amd.com>
>
> When SEV-ES is enabled, it is not possible modify the guests register
> state after it has been initially created, encrypted and measured.
>
> Normally, an INIT-SIPI-SIPI request is used to boot the AP. However, the
> hypervisor cannot emulate this because it cannot update the AP register
> state. For the very first boot by an AP, the reset vector CS segment
> value and the EIP value must be programmed before the register has been
> encrypted and measured.
>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> accel/kvm/kvm-all.c | 60 ++++++++++++++++++++++++++++++++++++++++++
> accel/stubs/kvm-stub.c | 5 ++++
> hw/i386/pc_sysfw.c | 10 ++++++-
> include/sysemu/kvm.h | 16 +++++++++++
> include/sysemu/sev.h | 2 ++
> target/i386/kvm.c | 2 ++
> target/i386/sev.c | 47 +++++++++++++++++++++++++++++++++
> 7 files changed, 141 insertions(+), 1 deletion(-)
Just a heads-up: ./scripts/checkpatch.pl does report a couple of style
errors. I've seen other series go by where maintainers didn't mind the
line length errors, but there are a couple that have to do with braces
around if-statement contents that may need to be addressed.
next prev parent reply other threads:[~2020-08-26 19:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 19:05 [PATCH 0/4] SEV-ES guest support Tom Lendacky
2020-08-25 19:05 ` [PATCH 1/4] sev/i386: Add initial support for SEV-ES Tom Lendacky
2020-08-26 19:07 ` Connor Kuehl
2020-08-26 19:24 ` Tom Lendacky
2020-08-25 19:05 ` [PATCH 2/4] sev/i386: Allow AP booting under SEV-ES Tom Lendacky
2020-08-26 19:07 ` Connor Kuehl [this message]
2020-08-26 19:25 ` Tom Lendacky
2020-08-25 19:05 ` [PATCH 3/4] sev/i386: Don't allow a system reset under an SEV-ES guest Tom Lendacky
2020-08-26 19:07 ` Connor Kuehl
2020-08-25 19:05 ` [PATCH 4/4] sev/i386: Enable an SEV-ES guest based on SEV policy Tom Lendacky
2020-08-26 19:07 ` Connor Kuehl
2020-08-27 15:53 ` [PATCH 0/4] SEV-ES guest support Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93275d7f-1bfd-c115-be4b-3d20952bf376@redhat.com \
--to=ckuehl@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jslaby@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).