From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Sergio Lopez <slp@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
qemu-arm@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v3 12/22] acpi: move acpi_dsdt_add_power_button() to ged
Date: Wed, 20 May 2020 15:32:09 +0200 [thread overview]
Message-ID: <93396c96-32a1-b10c-be24-64b79466b420@redhat.com> (raw)
In-Reply-To: <20200520132003.9492-13-kraxel@redhat.com>
On 5/20/20 3:19 PM, Gerd Hoffmann wrote:
> Allow reuse for microvm.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> include/hw/acpi/generic_event_device.h | 1 +
> hw/acpi/generic_event_device.c | 8 ++++++++
> hw/arm/virt-acpi-build.c | 8 --------
> 3 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/include/hw/acpi/generic_event_device.h b/include/hw/acpi/generic_event_device.h
> index 9687cb524258..ebed1ffe4231 100644
> --- a/include/hw/acpi/generic_event_device.h
> +++ b/include/hw/acpi/generic_event_device.h
> @@ -113,5 +113,6 @@ typedef struct AcpiGedState {
>
> void build_ged_aml(Aml *table, const char* name, HotplugHandler *hotplug_dev,
> uint32_t ged_irq, AmlRegionSpace rs, hwaddr ged_base);
> +void acpi_dsdt_add_power_button(Aml *scope);
>
> #endif
> diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
> index 3072fb4ab32b..cde50da5b3ca 100644
> --- a/hw/acpi/generic_event_device.c
> +++ b/hw/acpi/generic_event_device.c
> @@ -142,6 +142,14 @@ void build_ged_aml(Aml *table, const char *name, HotplugHandler *hotplug_dev,
> aml_append(table, dev);
> }
>
> +void acpi_dsdt_add_power_button(Aml *scope)
> +{
> + Aml *dev = aml_device(ACPI_POWER_BUTTON_DEVICE);
> + aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C")));
> + aml_append(dev, aml_name_decl("_UID", aml_int(0)));
> + aml_append(scope, dev);
> +}
> +
> /* Memory read by the GED _EVT AML dynamic method */
> static uint64_t ged_evt_read(void *opaque, hwaddr addr, unsigned size)
> {
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index 1b0a584c7b62..49eacc622219 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -354,14 +354,6 @@ static void acpi_dsdt_add_gpio(Aml *scope, const MemMapEntry *gpio_memmap,
> aml_append(scope, dev);
> }
>
> -static void acpi_dsdt_add_power_button(Aml *scope)
> -{
> - Aml *dev = aml_device(ACPI_POWER_BUTTON_DEVICE);
> - aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C")));
> - aml_append(dev, aml_name_decl("_UID", aml_int(0)));
> - aml_append(scope, dev);
> -}
> -
> static void
> build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
> {
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-05-20 13:37 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 13:19 [PATCH v3 00/22] microvm: add acpi support Gerd Hoffmann
2020-05-20 13:19 ` [PATCH v3 01/22] microvm: name qboot binary qboot.bin Gerd Hoffmann
2020-05-20 13:25 ` Philippe Mathieu-Daudé
2020-05-25 11:02 ` Gerd Hoffmann
2020-05-25 12:26 ` Philippe Mathieu-Daudé
2020-05-20 13:19 ` [PATCH v3 02/22] [testing] seabios: update submodule to master snapshot Gerd Hoffmann
2020-05-20 13:19 ` [PATCH v3 03/22] [testing] seabios: update config & build rules Gerd Hoffmann
2020-05-20 13:19 ` [PATCH v3 04/22] [testing] seabios: update binaries to master snapshot Gerd Hoffmann
2020-05-20 13:19 ` [PATCH v3 05/22] acpi: make build_madt() more generic Gerd Hoffmann
2020-05-20 13:19 ` [PATCH v3 06/22] acpi: create acpi-common.c and move madt code Gerd Hoffmann
2020-05-20 13:31 ` Philippe Mathieu-Daudé
2020-05-20 13:19 ` [PATCH v3 07/22] acpi: madt: skip pci override on pci-less systems Gerd Hoffmann
2020-05-20 13:19 ` [PATCH v3 08/22] acpi: fadt: add hw-reduced sleep register support Gerd Hoffmann
2020-05-20 13:19 ` [PATCH v3 09/22] acpi: ged: rename event memory region Gerd Hoffmann
2020-05-20 13:33 ` Philippe Mathieu-Daudé
2020-05-21 7:58 ` Igor Mammedow
2020-05-20 13:19 ` [PATCH v3 10/22] acpi: ged: add control regs Gerd Hoffmann
2020-05-21 8:58 ` Igor Mammedov
2020-05-20 13:19 ` [PATCH v3 11/22] acpi: ged: add x86 device variant Gerd Hoffmann
2020-05-21 9:01 ` Igor Mammedov
2020-05-20 13:19 ` [PATCH v3 12/22] acpi: move acpi_dsdt_add_power_button() to ged Gerd Hoffmann
2020-05-20 13:32 ` Philippe Mathieu-Daudé [this message]
2020-05-21 9:03 ` Igor Mammedov
2020-05-20 13:19 ` [PATCH v3 13/22] x86: coldplug cpus Gerd Hoffmann
2020-05-20 14:07 ` Igor Mammedov
2020-05-20 13:19 ` [PATCH v3 14/22] microvm: use 2G split unconditionally Gerd Hoffmann
2020-05-20 13:34 ` Philippe Mathieu-Daudé
2020-05-21 9:14 ` Igor Mammedov
2020-05-21 9:29 ` Igor Mammedov
2020-05-25 11:45 ` Gerd Hoffmann
2020-05-25 16:36 ` Igor Mammedov
2020-05-26 4:48 ` Gerd Hoffmann
2020-05-27 12:25 ` Igor Mammedov
2020-05-27 13:06 ` Paolo Bonzini
2020-05-27 14:26 ` Igor Mammedov
2020-05-27 14:35 ` Igor Mammedov
2020-05-27 14:54 ` Paolo Bonzini
2020-05-28 7:19 ` Gerd Hoffmann
2020-05-28 7:17 ` Gerd Hoffmann
2020-05-20 13:19 ` [PATCH v3 15/22] microvm: make virtio irq base runtime configurable Gerd Hoffmann
2020-05-20 13:29 ` Philippe Mathieu-Daudé
2020-05-25 11:49 ` Gerd Hoffmann
2020-05-25 12:27 ` Philippe Mathieu-Daudé
2020-05-20 13:19 ` [PATCH v3 16/22] microvm/acpi: add minimal acpi support Gerd Hoffmann
2020-05-21 10:09 ` Igor Mammedov
2020-05-20 13:19 ` [PATCH v3 17/22] microvm/acpi: add acpi_dsdt_add_virtio() for x86 Gerd Hoffmann
2020-05-21 10:12 ` Igor Mammedov
2020-05-20 13:19 ` [PATCH v3 18/22] microvm/acpi: use GSI 16-23 for virtio Gerd Hoffmann
2020-05-21 10:13 ` Igor Mammedov
2020-05-20 13:20 ` [PATCH v3 19/22] microvm/acpi: use seabios with acpi=on Gerd Hoffmann
2020-05-21 10:14 ` Igor Mammedov
2020-05-20 13:20 ` [PATCH v3 20/22] microvm/acpi: disable virtio-mmio cmdline hack Gerd Hoffmann
2020-05-20 13:20 ` [PATCH v3 21/22] [RfC] acpi: add per machine type acpi default Gerd Hoffmann
2020-05-21 10:26 ` Igor Mammedov
2020-05-20 13:20 ` [PATCH v3 22/22] [RfC] acpi: flip default to off for microvm Gerd Hoffmann
2020-05-21 10:36 ` Igor Mammedov
2020-05-25 12:11 ` Gerd Hoffmann
2020-05-20 15:46 ` [PATCH v3 00/22] microvm: add acpi support no-reply
2020-05-20 15:50 ` no-reply
2020-05-20 15:51 ` no-reply
2020-05-20 15:53 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93396c96-32a1-b10c-be24-64b79466b420@redhat.com \
--to=philmd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=shannon.zhaosl@gmail.com \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).