From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD288C433F5 for ; Wed, 5 Oct 2022 12:09:25 +0000 (UTC) Received: from localhost ([::1]:50302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1og3DI-0004Z5-BY for qemu-devel@archiver.kernel.org; Wed, 05 Oct 2022 08:09:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1og36f-0003Bh-6D; Wed, 05 Oct 2022 08:02:33 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:19028) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1og36b-00074q-I0; Wed, 05 Oct 2022 08:02:32 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 8C01775A15D; Wed, 5 Oct 2022 14:02:22 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 459EE75A154; Wed, 5 Oct 2022 14:02:22 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 4426875A157; Wed, 5 Oct 2022 14:02:22 +0200 (CEST) Date: Wed, 5 Oct 2022 14:02:22 +0200 (CEST) From: BALATON Zoltan To: Daniel Henrique Barboza cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, clg@kaod.org, Peter Maydell Subject: Re: [PATCH v6 00/25] ppc4xx_sdram QOMify and clean ups In-Reply-To: Message-ID: <945d9dfb-412a-194d-9f86-346e6d172fc2@eik.bme.hu> References: <6ad5fa00-ac5c-3fd9-48fd-c2cb93daeb21@gmail.com> <692bbaaf-2e34-8827-f2a6-73bf5c599099@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-869782972-1664971342=:15873" Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-869782972-1664971342=:15873 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Tue, 27 Sep 2022, BALATON Zoltan wrote: > On Mon, 26 Sep 2022, Daniel Henrique Barboza wrote: >> On 9/26/22 14:09, Daniel Henrique Barboza wrote: >>> Zoltan, >>> >>> I've started to push some patches to ppc-next. Patches 1-13 are already >>> pushed >>> and I'm running tests on patches 14-17. Assuming everything is ok we'll be >>> left with patches 18-25 to work on. >> >> Patches 01-17 queued in ppc-next. >> >> If a next version is needed you can resend just 18-25. > > Thanks. Hope somebody can review the remaining ones too. Patches 18-20 are > just moving stuff to ppc4xx_sdram.c which are now in 3 patches for easier > review with --color-moved, 21-22 and 25 are already reviewed by Philippe so > only 23-24 need more attention. Ping for revewing patches mentioned above. Regards, BALATON Zoltan >>> On 9/24/22 09:27, BALATON Zoltan wrote: >>>> This is the end of the QOMify series started by Cédric. This series >>>> handles the SDRAM controller models to clean them up, QOMify and unify >>>> them and at least partially clean up the mess that has accumulated >>>> around these in the past. This includes the not yet merged patches >>>> from the last series and new ones that change the DDR2 version used by >>>> sam460ex. >>>> >>>> v6: Split patch moving sdram controller models together into smaller >>>> steps >>>> v5: Add functions the enable sdram controller and call it from boards >>>> v4: address more review comments >>>> v3: Fix patches that got squashed during rebase >>>> v2: address some review comments and try to avoid compile problem with >>>> gcc 12.2 (untested) >>>> >>>> BALATON Zoltan (25): >>>>    ppc440_bamboo: Remove unnecessary memsets >>>>    ppc4xx: Introduce Ppc4xxSdramBank struct >>>>    ppc4xx_sdram: Get rid of the init RAM hack >>>>    ppc4xx: Use Ppc4xxSdramBank in ppc4xx_sdram_banks() >>>>    ppc440_bamboo: Add missing 4 MiB valid memory size >>>>    ppc4xx_sdram: Move size check to ppc4xx_sdram_init() >>>>    ppc4xx_sdram: QOM'ify >>>>    ppc4xx_sdram: Drop extra zeros for readability >>>>    ppc440_sdram: Split off map/unmap of sdram banks for later reuse >>>>    ppc440_sdram: Implement enable bit in the DDR2 SDRAM controller >>>>    ppc440_sdram: Get rid of the init RAM hack >>>>    ppc440_sdram: Rename local variable for readability >>>>    ppc4xx_sdram: Rename functions to prevent name clashes >>>>    ppc440_sdram: Move RAM size check to ppc440_sdram_init >>>>    ppc440_sdram: QOM'ify >>>>    ppc440_uc.c: Move some macros to ppc4xx.h >>>>    ppc440_uc.c: Remove unneeded parenthesis >>>>    ppc440_uc.c: Move DDR2 SDRAM controller model to ppc4xx_sdram.c >>>>    ppc4xx_devs.c: Move DDR SDRAM controller model to ppc4xx_sdram.c >>>>    ppc4xx_sdram: Move ppc4xx_sdram_banks() to ppc4xx_sdram.c >>>>    ppc4xx_sdram: Use hwaddr for memory bank size >>>>    ppc4xx_sdram: Rename local state variable for brevity >>>>    ppc4xx_sdram: Generalise bank setup >>>>    ppc4xx_sdram: Convert DDR SDRAM controller to new bank handling >>>>    ppc4xx_sdram: Add errp parameter to ppc4xx_sdram_banks() >>>> >>>>   hw/ppc/meson.build      |   3 +- >>>>   hw/ppc/ppc405.h         |   8 +- >>>>   hw/ppc/ppc405_boards.c  |  13 +- >>>>   hw/ppc/ppc405_uc.c      |  33 +- >>>>   hw/ppc/ppc440.h         |   4 - >>>>   hw/ppc/ppc440_bamboo.c  |  25 +- >>>>   hw/ppc/ppc440_uc.c      | 267 +------------- >>>>   hw/ppc/ppc4xx_devs.c    | 413 ---------------------- >>>>   hw/ppc/ppc4xx_sdram.c   | 753 ++++++++++++++++++++++++++++++++++++++++ >>>>   hw/ppc/sam460ex.c       |  44 +-- >>>>   hw/ppc/trace-events     |   1 + >>>>   include/hw/ppc/ppc4xx.h |  65 +++- >>>>   12 files changed, 859 insertions(+), 770 deletions(-) >>>>   create mode 100644 hw/ppc/ppc4xx_sdram.c >>>> >> > --3866299591-869782972-1664971342=:15873--