From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v6] nbd: well form nbd_iter_channel_error errp handler
Date: Wed, 27 Nov 2019 13:49:58 -0600 [thread overview]
Message-ID: <949f6fe4-5dde-0cef-84e3-e029787c7b12@redhat.com> (raw)
In-Reply-To: <20191127190840.15773-1-vsementsov@virtuozzo.com>
[adding Markus]
On 11/27/19 1:08 PM, Vladimir Sementsov-Ogievskiy wrote:
> Make nbd_iter_channel_error errp handler well formed:
> rename local_err to errp_in, as it is IN-parameter here (which is
> unusual for Error**).
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>
> v6: fix commit message
> add Eric's r-b
I'm surprised that you aren't including Markus on a lot of these patches
- even though you've posted a lot of them as separate threads to make
them easier for individual maintainers to pick up, it would also be
possible for Markus to pick up a bunch of them at once through his error
tree.
At any rate, I'll queue this one through my NBD tree for 5.0 if it does
not make it through Markus' error tree or the trivial tree sooner.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-11-27 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 19:08 [PATCH v6] nbd: well form nbd_iter_channel_error errp handler Vladimir Sementsov-Ogievskiy
2019-11-27 19:49 ` Eric Blake [this message]
2019-11-27 20:07 ` Vladimir Sementsov-Ogievskiy
2019-11-29 13:25 ` Markus Armbruster
2019-11-29 14:17 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=949f6fe4-5dde-0cef-84e3-e029787c7b12@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).