From: KONRAD Frederic <frederic.konrad@adacore.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Fabien Chouteau" <chouteau@adacore.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Jiri Gaisler <jiri@gaisler.se>
Subject: Re: [PATCH 2/2] hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses
Date: Fri, 25 Oct 2019 13:54:28 +0200 [thread overview]
Message-ID: <952771de-3f81-5d54-7dae-8aba1780c8f2@adacore.com> (raw)
In-Reply-To: <20191025110114.27091-3-philmd@redhat.com>
Le 10/25/19 à 1:01 PM, Philippe Mathieu-Daudé a écrit :
> The Plug & Play region of the AHB/APB bridge can be accessed
> by various word size, however the implementation is clearly
> restricted to 32-bit:
>
> static uint64_t grlib_apb_pnp_read(void *opaque, hwaddr offset, unsigned size)
> {
> APBPnp *apb_pnp = GRLIB_APB_PNP(opaque);
>
> return apb_pnp->regs[offset >> 2];
> }
>
> Set the MemoryRegionOps::impl min/max fields to 32-bit, so
> memory.c::access_with_adjusted_size() can adjust when the
> access is not 32-bit.
>
> This is required to run RTEMS on leon3, the grlib scanning
> functions do byte accesses.
>
> Reported-by: Jiri Gaisler <jiri@gaisler.se>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/misc/grlib_ahb_apb_pnp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/misc/grlib_ahb_apb_pnp.c b/hw/misc/grlib_ahb_apb_pnp.c
> index f3c015d2c3..e230e25363 100644
> --- a/hw/misc/grlib_ahb_apb_pnp.c
> +++ b/hw/misc/grlib_ahb_apb_pnp.c
> @@ -242,6 +242,10 @@ static const MemoryRegionOps grlib_apb_pnp_ops = {
> .read = grlib_apb_pnp_read,
> .write = grlib_apb_pnp_write,
> .endianness = DEVICE_BIG_ENDIAN,
> + .impl = {
> + .min_access_size = 4,
> + .max_access_size = 4,
> + },
> };
>
> static void grlib_apb_pnp_realize(DeviceState *dev, Error **errp)
>
Reviewed-by: KONRAD Frederic <frederic.konrad@adacore.com>
Thanks
next prev parent reply other threads:[~2019-10-25 11:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 11:01 [PATCH 0/2] hw/sparc/leon3: Fixes for the AHB/APB bridge Philippe Mathieu-Daudé
2019-10-25 11:01 ` [PATCH 1/2] hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers Philippe Mathieu-Daudé
2019-10-25 11:53 ` KONRAD Frederic
2019-11-05 14:02 ` Laurent Vivier
2019-10-25 11:01 ` [PATCH 2/2] hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses Philippe Mathieu-Daudé
2019-10-25 11:54 ` KONRAD Frederic [this message]
2019-11-05 14:02 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=952771de-3f81-5d54-7dae-8aba1780c8f2@adacore.com \
--to=frederic.konrad@adacore.com \
--cc=atar4qemu@gmail.com \
--cc=chouteau@adacore.com \
--cc=jiri@gaisler.se \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).