Re: [Qemu-devel] [qemu-s390x] [PATCH v2 0/7] tcg: probe_write() refactorings

[David Hildenbrand <david@redhat.com>]

On 26.08.19 09:51, David Hildenbrand wrote:
> Based on tcg-next. The last two patches from v1 are now part of
> "[PATCH 0/6] exec: Cleanup watchpoints" from richard.
> 
> Fix and refactore some things around probe_write() in s390x code. Introduce
> probe_write() for CONFIG_USER_ONLY.
> 
> This is the first step of some changes necessary to handle fault-safe
> access accross multiple pages on s390x. The next step is making
> probe_write() return an address, similar to tlb_vaddr_to_host(), and
> introduing probe_read().
> 
> v1 -> v2:
> - "tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code"
> -- Perform only a single !guest_addr_valid(addr) check.
> - "tcg: Enforce single page access in probe_write()"
> -- Also add the check for CONFIG_USER_ONLY
> 
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Riku Voipio <riku.voipio@iki.fi>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Cc: Aleksandar Markovic <amarkovic@wavecomp.com>
> Cc: Aleksandar Rikalo <arikalo@wavecomp.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
> 
> David Hildenbrand (7):
>   s390x/tcg: Use guest_addr_valid() instead of h2g_valid() in
>     probe_write_access()
>   s390x/tcg: Fix length calculation in probe_write_access()
>   tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code
>   tcg: Enforce single page access in probe_write()
>   mips/tcg: Call probe_write() for CONFIG_USER_ONLY as well
>   hppa/tcg: Call probe_write() also for CONFIG_USER_ONLY
>   s390x/tcg: Pass a size to probe_write() in do_csst()
> 
>  accel/tcg/cputlb.c        |  2 ++
>  accel/tcg/user-exec.c     | 17 +++++++++++++++++
>  include/exec/exec-all.h   |  4 ++--
>  target/hppa/op_helper.c   |  2 --
>  target/mips/op_helper.c   |  8 +++-----
>  target/s390x/mem_helper.c | 13 ++-----------
>  6 files changed, 26 insertions(+), 20 deletions(-)
> 

Richard, in case there is no more feedback, will you take these patches
via your tree?

-- 

Thanks,

David / dhildenb