From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>, Sergio Lopez <slp@redhat.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-block] [PATCH v2] nbd/server: attach client channel to the export's AioContext
Date: Fri, 20 Sep 2019 17:03:31 -0500 [thread overview]
Message-ID: <9839e070-d59d-78fb-b47e-521ac8dc9c72@redhat.com> (raw)
In-Reply-To: <598fd2ca-14e6-12fd-c3fc-7b9c8e198952@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1253 bytes --]
On 9/20/19 2:11 PM, Eric Blake wrote:
> On 9/20/19 1:49 PM, John Snow wrote:
>>
>
>>>> To fix this, as soon we have the export corresponding to the client,
>>>> we call qio_channel_attach_aio_context() to attach the QIOChannel
>>>> context to the export's AioContext. This matches with the logic at
>>>> blk_aio_attached().
>>>>
>
>>>
>>> I assume this patch has been superseded by Eric's later patches?
>>
>> Nevermind -- my filtering got messed up slightly and I missed the
>> followup. I see that Eric staged this.
>
> I actually think both patches are needed: this one covers transactions,
> while my later patch was on top of this to protect shutdown. But now
> you've made me curious; I'll see if my patch hoisted in front still
> solves everything, or if we really do need both.
>
Nope, both patches are still needed. Sergio's fixes the assertion:
(qemu) qemu-kvm: io/channel.c:411: qio_channel_restart_read:
Assertion `qemu_get_current_aio_context() ==
qemu_coroutine_get_aio_context(co)' failed.
while mine fixes:
+qemu: qemu_mutex_unlock_impl: Operation not permitted
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-09-20 22:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 11:00 [Qemu-devel] [PATCH v2] nbd/server: attach client channel to the export's AioContext Sergio Lopez
2019-09-20 12:38 ` Eric Blake
2019-09-20 18:12 ` [Qemu-block] " John Snow
2019-09-20 18:49 ` John Snow
2019-09-20 19:11 ` Eric Blake
2019-09-20 22:03 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9839e070-d59d-78fb-b47e-521ac8dc9c72@redhat.com \
--to=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).