qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] target/xtensa: don't generate extra EXCP_DEBUG on exception
Date: Thu, 15 Apr 2021 15:29:53 -0700	[thread overview]
Message-ID: <98830153-5ae3-4d92-4ac2-4f76a8b2d523@linaro.org> (raw)
In-Reply-To: <20210415205517.23599-1-jcmvbkbc@gmail.com>

On 4/15/21 1:55 PM, Max Filippov wrote:
> target/xtensa used to generate an extra EXCP_DEBUG exception before the
> first instruction executed after an interrupt or an exception is taken
> to allow single-stepping that instruction in the debugger.
> This is no longer needed after the following commits:
> a7ba744f4082 ("tcg/cpu-exec: precise single-stepping after an exception")
> ba3c35d9c402 ("tcg/cpu-exec: precise single-stepping after an interrupt")
> Drop exception state tracking/extra EXCP_DEBUG generation code.
> 
> Signed-off-by: Max Filippov<jcmvbkbc@gmail.com>
> ---
> This patch depends on the "target/xtensa: Make sure that tb->size != 0"
> patch.
> 
>   target/xtensa/cpu.c        | 1 -
>   target/xtensa/cpu.h        | 7 -------
>   target/xtensa/exc_helper.c | 5 -----
>   target/xtensa/translate.c  | 6 ------
>   4 files changed, 19 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


      reply	other threads:[~2021-04-15 22:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 20:55 [PATCH] target/xtensa: don't generate extra EXCP_DEBUG on exception Max Filippov
2021-04-15 22:29 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98830153-5ae3-4d92-4ac2-4f76a8b2d523@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).