From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, Jean-Christophe Dubois <jcd@tribudubois.net>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH-for-6.0?] hw/arm/imx25_pdk: Fix error message for invalid RAM size
Date: Wed, 7 Apr 2021 15:59:24 -0700 [thread overview]
Message-ID: <98c04529-d9a3-1a1b-65e1-a0b51da90081@linaro.org> (raw)
In-Reply-To: <20210407225608.1882855-1-f4bug@amsat.org>
On 4/7/21 3:56 PM, Philippe Mathieu-Daudé wrote:
> The i.MX25 PDK board has 2 banks for SDRAM, each can
> address up to 256 MiB. So the total RAM usable for this
> board is 512M. When we ask for more we get a misleading
> error message:
>
> $ qemu-system-arm -M imx25-pdk -m 513M
> qemu-system-arm: Invalid RAM size, should be 128 MiB
>
> Update the error message to better match the reality:
>
> $ qemu-system-arm -M imx25-pdk -m 513M
> qemu-system-arm: RAM size more than 512 MiB is not supported
>
> Fixes: bf350daae02 ("arm/imx25_pdk: drop RAM size fixup")
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> hw/arm/imx25_pdk.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-04-07 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 22:56 [PATCH-for-6.0?] hw/arm/imx25_pdk: Fix error message for invalid RAM size Philippe Mathieu-Daudé
2021-04-07 22:59 ` Richard Henderson [this message]
2021-04-08 19:56 ` Igor Mammedov
2021-05-02 16:29 ` Philippe Mathieu-Daudé
2021-05-04 10:39 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98c04529-d9a3-1a1b-65e1-a0b51da90081@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=jcd@tribudubois.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).