From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: huangy81@chinatelecom.cn, qemu-devel <qemu-devel@nongnu.org>,
QEMU Trivial <qemu-trivial@nongnu.org>
Cc: Eric Blake <eblake@redhat.com>, Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH] docs: fix qemu incorrect tag
Date: Fri, 5 Nov 2021 14:26:51 +0100 [thread overview]
Message-ID: <98d98c4b-9e34-700c-c659-2dd6f169a4c8@redhat.com> (raw)
In-Reply-To: <2f6070f08d63fd2281d324c70bb5f8db3b4c803c.1636116975.git.huangy81@chinatelecom.cn>
Cc'ing qemu-trivial@
On 11/5/21 14:01, huangy81@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> The last modification of the patchset may be 2 month before
> merging dirtyrate implementation, it used the wrong tag, so
> fix with 6.2.
Maybe:
The patchset merged in 71864eadd9a ("migration/dirtyrate:
introduce struct and adjust DirtyRateStat") was targeting
QEMU 6.1 but got merged later, so correct the tag for 6.2.
Anyhow,
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> ---
> qapi/migration.json | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 87146ce..f0aefda 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1740,7 +1740,7 @@
> #
> # @dirty-rate: dirty rate.
> #
> -# Since: 6.1
> +# Since: 6.2
> #
> ##
> { 'struct': 'DirtyRateVcpu',
> @@ -1774,7 +1774,7 @@
> #
> # @dirty-bitmap: calculate dirtyrate by dirty bitmap.
> #
> -# Since: 6.1
> +# Since: 6.2
> #
> ##
> { 'enum': 'DirtyRateMeasureMode',
> @@ -1796,13 +1796,13 @@
> # @calc-time: time in units of second for sample dirty pages
> #
> # @sample-pages: page count per GB for sample dirty pages
> -# the default value is 512 (since 6.1)
> +# the default value is 512 (since 6.2)
> #
> # @mode: mode containing method of calculate dirtyrate includes
> -# 'page-sampling' and 'dirty-ring' (Since 6.1)
> +# 'page-sampling' and 'dirty-ring' (Since 6.2)
> #
> # @vcpu-dirty-rate: dirtyrate for each vcpu if dirty-ring
> -# mode specified (Since 6.1)
> +# mode specified (Since 6.2)
> #
> # Since: 5.2
> #
>
next prev parent reply other threads:[~2021-11-05 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 13:01 [PATCH] docs: fix qemu incorrect tag huangy81
2021-11-05 13:26 ` Philippe Mathieu-Daudé [this message]
2021-11-06 11:33 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98d98c4b-9e34-700c-c659-2dd6f169a4c8@redhat.com \
--to=philmd@redhat.com \
--cc=eblake@redhat.com \
--cc=huangy81@chinatelecom.cn \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).