From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6454AC33CB3 for ; Tue, 14 Jan 2020 14:53:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C5AE24672 for ; Tue, 14 Jan 2020 14:53:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C5AE24672 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irNZ0-0007Nr-1a for qemu-devel@archiver.kernel.org; Tue, 14 Jan 2020 09:53:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34349) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irNW7-0006Lc-FY for qemu-devel@nongnu.org; Tue, 14 Jan 2020 09:50:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irNW3-0004gB-OG for qemu-devel@nongnu.org; Tue, 14 Jan 2020 09:50:03 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:59083) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1irNW3-0004g7-FP for qemu-devel@nongnu.org; Tue, 14 Jan 2020 09:49:59 -0500 Received: from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MryCb-1jTTZ70lnR-00nyV6; Tue, 14 Jan 2020 15:49:44 +0100 Subject: Re: [PATCH v5 19/20] linux-user: Add support for KCOV_ ioctls To: Aleksandar Markovic , qemu-devel@nongnu.org References: <1578947683-21011-1-git-send-email-aleksandar.markovic@rt-rk.com> <1578947683-21011-20-git-send-email-aleksandar.markovic@rt-rk.com> From: Laurent Vivier Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: <992afe33-3000-c2a3-e326-c2cb2a55c8ff@vivier.eu> Date: Tue, 14 Jan 2020 15:49:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <1578947683-21011-20-git-send-email-aleksandar.markovic@rt-rk.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:2+fMWlY4GU2WD7tYS5NNVwowenGqY7lpVCWzZLR7HL/n5eXz2jq DPIrE3iTPf3Q9be63KXqrwOClgExOLM8pGhbbJWGhla8b4NCxlIdNbsSVD+Z5hhJAOvLk4F 4sd9goKr41vHBa/meXSTF1xT9XPQuziZQXWddVanopN3Nol62yqHhl6QfTxHdaGwM6nK4jJ HaJkYJ3zVP/mexkLdXVOg== X-UI-Out-Filterresults: notjunk:1;V03:K0:VaxQFGgAg8g=:8CKEc0E6vo1LczUASZQ4R4 Swvmc0SRSqIeMfzElR2sKZW47UETbTl4BFERKXX4Iby5XQVAff0uuAB4oq9BUDqp5d42DBbOk 5r1bVFljzTxskEZ+FJcc/RQ4u9DNiDBd/MjOuEeu3tLbai4KxPPWnqhxoKS4Ce8DDAnYPgBXY z1npXyjQB8BwdTVknac1wmVuIx5hPz22Q6YOQtb1WhLgkaXD3gVlM0xTWoJA+3Es6ryOpD7aF Wv7qPGkIySvRLovZntYi3mfcCGmFMKORNLMry+PuwQn65QEg26rNGVmnf+R5oUSGz1uDyqTPJ 1Z/nGkb0Liid6SJS+RV/cO//NpUePIDaQekpcdA8WgfYZTZISZ0C1EIMbLJ1DYJt39/gvwBUS rwGWJsluc4TozMQm2ggzUac2u7hBS2bklzjWR5vnBUyTA+peAhASdFxdOcUqpAMjYReNFvh89 oxqc9czhaI9gI9xyV4mJlo9XUoE0IQNWkbS+9mSRZwoxhoCj3EbwRacihq4oLHnPYxIfh6zx0 Sh9AxJuOON2Ys5zt7ar1UoUGeKqfGevmPLfULPO7ajO4ogG5QHMaS6gpdPkfbO2jPvTVipFBL 9ujxCZjQtnzWODIhwVpCQlbJM5xTHFZayNZw84cA/aXQGkFoWt8DjQyhuyHecEgn7YziaQ0r9 5LT/Y1+cNCgY/kb7Kq431zvVzXiIAS52O9/CgGu5oUkJ3SZ9TY9xPI/ynajplCF9+lkqrL8Vc 2X70h0N8YwptmF9TVQZBF04wrmY7Wr7hmr1+gGLaO3QzNxzH7paf1fEhjT+G8vRlOP7vLxA1z NrdJBaV/NJ0vvH0VRe9CMgy1zHk/N/rZAUOy1aIv65sojC5RrKdxvDGEHeoqy9/3HGbAdPmiw WABNB5YdYLpmUBoYz2I08hL0GekdH7H1aHiaAduTk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.135 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amarkovic@wavecomp.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 13/01/2020 à 21:34, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > KCOV_ENABLE and KCOV_DISABLE play the role in kernel coverage > tracing. These ioctls do not use the third argument of ioctl() > system call and are straightforward to implement in QEMU. > > Signed-off-by: Aleksandar Markovic > --- > linux-user/ioctls.h | 5 +++++ > linux-user/syscall.c | 3 +++ > linux-user/syscall_defs.h | 4 ++++ > 3 files changed, 12 insertions(+) > > diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h > index d72cd76..39b3825 100644 > --- a/linux-user/ioctls.h > +++ b/linux-user/ioctls.h > @@ -552,3 +552,8 @@ > IOCTL_IGNORE(TIOCSTART) > IOCTL_IGNORE(TIOCSTOP) > #endif > + > +#ifdef CONFIG_KCOV > + IOCTL(KCOV_ENABLE, 0, TYPE_NULL) > + IOCTL(KCOV_DISABLE, 0, TYPE_NULL) > +#endif > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 171c0ca..6edcb0d 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -73,6 +73,9 @@ > #ifdef CONFIG_SENDFILE > #include > #endif > +#ifdef CONFIG_KCOV > +#include > +#endif > > #define termios host_termios > #define winsize host_winsize > diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h > index 225dcfb..87e390d 100644 > --- a/linux-user/syscall_defs.h > +++ b/linux-user/syscall_defs.h > @@ -2457,6 +2457,10 @@ struct target_mtpos { > #define TARGET_MTIOCGET TARGET_IOR('m', 2, struct target_mtget) > #define TARGET_MTIOCPOS TARGET_IOR('m', 3, struct target_mtpos) > > +/* kcov ioctls */ > +#define TARGET_KCOV_ENABLE TARGET_IO('c', 100) > +#define TARGET_KCOV_DISABLE TARGET_IO('c', 101) > + > struct target_sysinfo { > abi_long uptime; /* Seconds since boot */ > abi_ulong loads[3]; /* 1, 5, and 15 minute load averages */ > Reviewed-by: Laurent Vivier