Re: [PATCH v3 02/12] vfio-user: build library

From: Jag Raman <jag.raman@oracle.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
	"John Johnson" <john.g.johnson@oracle.com>,
	"thuth@redhat.com" <thuth@redhat.com>,
	"swapnil.ingle@nutanix.com" <swapnil.ingle@nutanix.com>,
	"john.levon@nutanix.com" <john.levon@nutanix.com>,
	"philmd@redhat.com" <philmd@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@gmail.com>,
	"thanos.makatos@nutanix.com" <thanos.makatos@nutanix.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"alex.bennee@linaro.org" <alex.bennee@linaro.org>
Subject: Re: [PATCH v3 02/12] vfio-user: build library
Date: Fri, 29 Oct 2021 14:17:43 +0000	[thread overview]
Message-ID: <9A1823A8-DA30-4665-93CD-349F058A52CA@oracle.com> (raw)
In-Reply-To: <YXltdeUNi1JPuyB7@stefanha-x1.localdomain>

Hi Stefan,

> On Oct 27, 2021, at 11:17 AM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> 
> On Mon, Oct 11, 2021 at 01:31:07AM -0400, Jagannathan Raman wrote:
>> diff --git a/hw/remote/Kconfig b/hw/remote/Kconfig
>> index 08c16e235f..f9e512d44a 100644
>> --- a/hw/remote/Kconfig
>> +++ b/hw/remote/Kconfig
>> @@ -1,4 +1,9 @@
>> +config VFIO_USER_SERVER
>> +    bool
>> +    default n
> 
> Does VFIO_USER_SERVER depend on MULTIPROCESS?

Yes, VFIO_USER_SERVER presently depends on MULTIPROCESS.

This is because it needs some object and functions implemented by multiprocess
such as TYPE_REMOTE_MACHINE and TYPE_REMOTE_PCIHOST.

> 
>> diff --git a/tests/acceptance/multiprocess.py b/tests/acceptance/multiprocess.py
>> index 96627f022a..7383c6eb58 100644
>> --- a/tests/acceptance/multiprocess.py
>> +++ b/tests/acceptance/multiprocess.py
>> @@ -67,6 +67,7 @@ def do_test(self, kernel_url, initrd_url, kernel_command_line,
>>     def test_multiprocess_x86_64(self):
>>         """
>>         :avocado: tags=arch:x86_64
>> +        :avocado: tags=distro:centos
>>         """
>>         kernel_url = ('https://archives.fedoraproject.org/pub/archive/fedora'
>>                       '/linux/releases/31/Everything/x86_64/os/images'
>> @@ -82,6 +83,7 @@ def test_multiprocess_x86_64(self):
>>     def test_multiprocess_aarch64(self):
>>         """
>>         :avocado: tags=arch:aarch64
>> +        :avocado: tags=distro:ubuntu
>>         """
>>         kernel_url = ('https://archives.fedoraproject.org/pub/archive/fedora'
>>                       '/linux/releases/31/Everything/aarch64/os/images'
> 
> Did you tag them with different distros in order to get coverage on both
> CentOS and Ubuntu (even though that's orthogonal to x86_64 vs aarch64)?
> Maybe a comment is necessary so it's clear why these tags are in place
> because the test isn't actually limited to that distro.

OK, I’ll add a comment to explain this.

For background, we disabled multiprocess by default in this series. This is
because, not all docker images have the json-c package available to build
libvfio-user library. So we had to enable it on selected docker images where
that package would be available. As such, we also had to limit the multiprocess
acceptance tests to the distros which had multiprocess enabled.

Going by “.gitlab-ci.d/buildtest.yml” file, the distros that support x86_64 target
are centos (build-system-centos) and opensuse (build-system-opensuse). So
we picked centos for x86_64, as running this test on other builds could
cause a failure. Likewise, ubuntu supported aarch64.

--
Jag