From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1526C433DB for ; Mon, 8 Mar 2021 15:04:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 645306521F for ; Mon, 8 Mar 2021 15:04:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 645306521F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJHQv-0003mN-Ev for qemu-devel@archiver.kernel.org; Mon, 08 Mar 2021 10:04:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJHPy-0002lp-Bv for qemu-devel@nongnu.org; Mon, 08 Mar 2021 10:03:34 -0500 Received: from mx2.suse.de ([195.135.220.15]:56198) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJHPw-0008Fp-JK for qemu-devel@nongnu.org; Mon, 08 Mar 2021 10:03:34 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F0141AE15; Mon, 8 Mar 2021 15:03:30 +0000 (UTC) Subject: Re: [PATCH v26 00/20] i386 cleanup PART 2 To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Peter Maydell , =?UTF-8?Q?Alex_Benn=c3=a9e?= , "Daniel P . Berrange" References: <20210301085450.1732-1-cfontana@suse.de> <6230ef40-c0ec-875e-dbd3-46fb5925322e@amsat.org> <81208ea0-f389-14d0-c366-0579dee3376d@suse.de> From: Claudio Fontana Message-ID: <9a451974-3d46-64b7-e7ef-c70a05e534cc@suse.de> Date: Mon, 8 Mar 2021 16:03:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Jim Fehlig , Roman Bolshakov , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/8/21 3:57 PM, Philippe Mathieu-Daudé wrote: > On 3/8/21 2:52 PM, Claudio Fontana wrote: >> On 3/8/21 2:27 PM, Philippe Mathieu-Daudé wrote: >>> Hi Claudio, >>> >>> On 3/8/21 1:57 PM, Claudio Fontana wrote: >>>> Hi, >>>> >>>> anything else for me to do here? >>>> >>>> The latest rebased state of this series should be always available here: >>>> >>>> https://gitlab.com/hw-claudio/qemu/-/tree/i386_cleanup_8 >>>> >>>> When it comes to the ARM cleanup series, >>>> I would like to have the tests pass for ARM, before doing even more changes, could you help me there Philippe? >>>> >>>> Maybe applying some of your changes on top would fix the failures? I tried, for example with the arm-cpu-features ones, but it didn't work for me.. >>> >>> TBH I wrote these patches during my personal spare time and this >>> became a real Pandora box that drained too much energy. I prefer >>> to step back and focus on finishing smaller tasks before burning >>> out. That said I appreciate your effort and am interested in >>> following / reviewing your work. >>> >>> Regards, >>> >>> Phil. >>> >> >> Thanks Philippe for sharing this, and I agree completely, it is very draining. >> >> The effort of making tests happy that run in artificial environments in particular often feels to me >> as too disconnected from actually ensuring that there is no real run time regression. >> >> qtest_enabled() (implicitly, or explicitly via open-ended else statements) is another painful variable to keep in mind in cpu and machine code, so it is not helpful in my view. >> >> I'll try to push more to get the tests running again, if you have any comment or idea, feel free to just point me in the right direction, >> that is very valuable to me, even without working code. > > Basically I gave up after realizing from Daniel reviews that we need > QMP commands to query QEMU at runtime its built-in features, so we > have build-agnostic tests easier to maintain. I agree this is the > best way to resolve this particular case, but also scale for various > other cases. > Well, yes, but in order to get things to work, even just a kvm-build fix would be good until we have the perfect solution, no? We also fixed the tcg tests when doing this for i386, so I think we can fix these issues for arm too. But this doesn't mean that we don't need the QMP commands to query QEMU at runtime for its "built-in"/module-loaded features. We need that too, and I suspect this will be more and more needed by libvirt, as QEMU modularizes. I just think the two things could proceed in parallel.. Ciao, Claudio