From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF65DC43603 for ; Thu, 12 Dec 2019 04:42:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9653A20652 for ; Thu, 12 Dec 2019 04:42:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rIC3UGOv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9653A20652 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifGJ5-0007B1-L5 for qemu-devel@archiver.kernel.org; Wed, 11 Dec 2019 23:42:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48962) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifGIT-0006mP-IM for qemu-devel@nongnu.org; Wed, 11 Dec 2019 23:41:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifGIS-0003ac-Jf for qemu-devel@nongnu.org; Wed, 11 Dec 2019 23:41:53 -0500 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:34611) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ifGIS-0003YQ-CI for qemu-devel@nongnu.org; Wed, 11 Dec 2019 23:41:52 -0500 Received: by mail-pg1-x544.google.com with SMTP id r11so491551pgf.1 for ; Wed, 11 Dec 2019 20:41:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TMZ0jDyFGMuzuCun35FlQjcRk8vnwVUTT98KZNlN13M=; b=rIC3UGOvk9L2dFuquPAhkVi0JGGUefnwwMeATGvEcJT9T9T0Ao/kbJWcrGIS3HG64H z6FPG4zIdt8ULJz/sD5A5B6ifRVIY2XburA/bFv9i3stuC3NtBD3qJm9lEgN5JYJqMZU XDSbUbHPhs+VTkW3zlTPBTera4He3/UqM7dOE6Ck0HL+wRZ7U0/hf1Cioz4kXANyTPqh JA11thxmywFY96WnRpL18925n1P6u/QduKAJ9nnjm1aSNIc7RbLg6SDrLK8+wDJOhTpx rj+/by9AKOGeibcBFqPzA94dPftUfTETF3AeReKNooSF+fdxo+hNOVIBqkWaWHsKgCu0 VOUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TMZ0jDyFGMuzuCun35FlQjcRk8vnwVUTT98KZNlN13M=; b=JDokP0SI2NA29Mdrqrw3Y5hJt8tIOvtPjvN+ylJPy9QrNmJJZY548bzQMqKtw4ydWG WqhD8Nw5K/PdiW8O/21JjUcyfVtHrzPDNHzGCShU9WvK9WKuSrydF8ULAXbznrtdNmao xoVreaTlaLr6YcsFGxG4dHraGB273FMBdQygoOQa4wCs8uZBfZhwoXx9ZI1rUQNRHRE0 IjsYN8EVNsTN3hUe0zva+4hDFX/tEamBpTyEYM3Vtklp3S2fLbsvt8rLV30usGes98Ve O0D2GoLfUYxNfS76QEQnS8a+NXeJqsOo0zFSqCbDNzwyV+G29wMYXxY575+hTpY5YlGH BT4w== X-Gm-Message-State: APjAAAWlk2+L2/3Xx1hs4gBB9BrDOJVGOuhlRNJbeU5AeVrrfck+mH/o ch++uQGy1DpuRA5caBVR7PjMkQ== X-Google-Smtp-Source: APXvYqwK6/C7GUruSSPXAiesSBseeFs/8Mu2J3mL+fJ8sDvqVh+HY5vX+pLmTsjNeg4OhLLvK3mpQQ== X-Received: by 2002:aa7:870c:: with SMTP id b12mr7866804pfo.82.1576125711350; Wed, 11 Dec 2019 20:41:51 -0800 (PST) Received: from [192.168.1.11] (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id e6sm4945379pfh.32.2019.12.11.20.41.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2019 20:41:50 -0800 (PST) Subject: Re: [PATCH v2 02/18] vl: move icount configuration earlier To: Paolo Bonzini , qemu-devel@nongnu.org References: <1575903705-12925-1-git-send-email-pbonzini@redhat.com> <1575903705-12925-3-git-send-email-pbonzini@redhat.com> From: Richard Henderson Message-ID: <9b07e930-97cc-544c-d72e-22c5503bce0c@linaro.org> Date: Wed, 11 Dec 2019 20:41:48 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <1575903705-12925-3-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::544 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, elmarco@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/9/19 7:01 AM, Paolo Bonzini wrote: > Once qemu_tcg_configure is turned into a QOM property setter, it will not > be able to set a default value for mttcg_enabled. Setting the default will > move to the TCG instance_init function, which currently runs before "-icount" > is processed. > > However, it is harmless to do configure_icount for all accelerators; we will > just fail later if a non-TCG accelerator is selected. So do that. > > Reviewed-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > vl.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) Reviewed-by: Richard Henderson r~