From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B7CC4CEC9 for ; Tue, 17 Sep 2019 19:50:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F350120862 for ; Tue, 17 Sep 2019 19:50:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qFnPRKGE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F350120862 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAJUO-0007Nk-0y for qemu-devel@archiver.kernel.org; Tue, 17 Sep 2019 15:50:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48768) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAJRX-00050j-Nr for qemu-devel@nongnu.org; Tue, 17 Sep 2019 15:47:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAJRW-0006j5-Id for qemu-devel@nongnu.org; Tue, 17 Sep 2019 15:47:19 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:38123) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iAJRW-0006iu-Cl for qemu-devel@nongnu.org; Tue, 17 Sep 2019 15:47:18 -0400 Received: by mail-wr1-x443.google.com with SMTP id l11so4444075wrx.5 for ; Tue, 17 Sep 2019 12:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oQeH/mztuXf3vq0eWv8W6xjsjG4JJWjy8XIK1haLLVs=; b=qFnPRKGEE9NX720h0qkefIyp672Y4ztlT9/zUYmQoq3/LEy3c3nxHQxDgq9GRxwutL bNewvizDIv0hy0q5M+2L5Yz5+F46khcd+0YeajmwEYFlrKq/amz0ATqlLmm+LZVuz4Et cfvPTim8QFOVWuB6hdsdtQokA99oAOR9RJi+E72BqYjyKTgRVzoFqwXGsF3F9GP++mrv CR6L1UAwXTvv95/2BFtIiTNxchkID/hRHEUQSZL45N3K2UWSq5LRqzYougpv5cbsAIGB bpTlb0SYSxTUeN8WVOXaF9uu0x9yvsBk2xKBcznsb3gvhOQUrbPO5J46n7gSpv4wGBJI LPoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oQeH/mztuXf3vq0eWv8W6xjsjG4JJWjy8XIK1haLLVs=; b=ZE1C3sTf5Rt0VwoKeeDxXk5uMLBjPJWeRY7VGhzG4e4aYRE1+ML5u+rMZcBcPFsC+x yaN6gZ9F8jLFXuk3rhgZDUHBcQNbaYDUsdMbztC85YBcBBfSGQb5QwWjc0gvW97UPeSn sPYy2lmccNONCiX1gcxybpjOSbWI+frfN4E+9B8YNPAVairx1ZEVCU9lGYw5/jpmWYPO ma0WZQ77BzyTH7/8DocoqGatI86h3snYirqm8OG5CRq98fQ1C+gjp7fJMtbvC0ril0pN peJvhETjQjAdnv3fU3cW2cB14j8YO7uGFdPIjgfM78+SMX7gOzKDPkLizHLBM5dqWVU7 ZskQ== X-Gm-Message-State: APjAAAXwq7xzWvsi2X7aLYhv5LXq2nIQ/i0sV/yO+QqUAmN61ImFODEs Xb+CZs3eoPezCX+Pmqgx9FU= X-Google-Smtp-Source: APXvYqw1mRque88o81h6NUES7DaFjJuEVekibpX/D2bWpv7arR0iNbVishhsYko7Ey/Crkn3gA59lQ== X-Received: by 2002:a5d:434f:: with SMTP id u15mr249554wrr.16.1568749637106; Tue, 17 Sep 2019 12:47:17 -0700 (PDT) Received: from ?IPv6:fd00:835b:d940:d4fc:1::ca? (2a01-036c-0113-74ef-0001-0000-0000-00ca.pool6.digikabel.hu. [2a01:36c:113:74ef:1::ca]) by smtp.gmail.com with ESMTPSA id c132sm4915810wme.27.2019.09.17.12.47.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 12:47:16 -0700 (PDT) From: "=?UTF-8?B?Wm9sdMOhbiBLxZF2w6Fnw7M=?=" X-Google-Original-From: =?UTF-8?B?Wm9sdMOhbiBLxZF2w6Fnw7M=?= To: Stefan Hajnoczi , qemu-devel@nongnu.org References: <20190911145818.18962-1-stefanha@redhat.com> <20190911145818.18962-3-stefanha@redhat.com> Message-ID: <9b2c9131-41d1-aee2-c40d-0f448c83b497@gmail.com> Date: Tue, 17 Sep 2019 21:47:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190911145818.18962-3-stefanha@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: Re: [Qemu-devel] [PATCH 2/2] audio: add -audiodev pa, in|out.latency= to documentation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2019-09-11 16:58, Stefan Hajnoczi wrote: > The "latency" parameter wasn't covered by the documentation. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Zoltán Kővágó > --- > How is this parameter related to buffer-length? Pulseaudio being a client-server architecture is a bit different than the other backends, plus it also has to mix multiple streams. buffer-length corresponds to the buffer inside qemu, while latency corresponds to pulseaudio. For playback, the latency should be "maximum latency that the application can deal with", if a different client request a lower latency, our latency will decrease too. It's up to the server to figure out an optimal buffer size on the server side of the things. For recording it's the size of the buffer we will read at a time from pulseaudio. > --- > qemu-options.hx | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/qemu-options.hx b/qemu-options.hx > index a4f9f74f52..82154cecf8 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -470,6 +470,7 @@ DEF("audiodev", HAS_ARG, QEMU_OPTION_audiodev, > "-audiodev pa,id=id[,prop[=value][,...]]\n" > " server= PulseAudio server address\n" > " in|out.name= source/sink device name\n" > + " in|out.latency= desired latency in microseconds\n" > #endif > #ifdef CONFIG_AUDIO_SDL > "-audiodev sdl,id=id[,prop[=value][,...]]\n" > @@ -630,6 +631,9 @@ Sets the PulseAudio @var{server} to connect to. > @item in|out.name=@var{sink} > Use the specified source/sink for recording/playback. > > +@item in|out.latency=@var{usecs} > +Desired latency in microseconds. > + > @end table > > @item -audiodev sdl,id=@var{id}[,@var{prop}[=@var{value}][,...]] >