From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98254C433E2 for ; Thu, 16 Jul 2020 06:08:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65B6420578 for ; Thu, 16 Jul 2020 06:08:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hOsNbcI9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65B6420578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jvx4V-0001mK-Nq for qemu-devel@archiver.kernel.org; Thu, 16 Jul 2020 02:08:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jvx3i-0000xo-EE for qemu-devel@nongnu.org; Thu, 16 Jul 2020 02:07:54 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:20250 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jvx3f-0002EF-9h for qemu-devel@nongnu.org; Thu, 16 Jul 2020 02:07:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594879670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=knwO7RwYQKuJ2UM5mbdYylCoJAMAOp3ETRj6uEeCO34=; b=hOsNbcI96+qYUV0m3NY3xHQ5B1ZkXzy5HjsxgzlTfz3Rs6yi/hHgf9GdZC36CfWzUWU4xO lY6JGehj7gwrQYtVN5INES6I6JkvkjJ/Yt8fDP596reyAajIV/BE2aycy/Laccz91s5Mkn lLUkz9qZGCprJK8CB6hD4IrBlW5VGPo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-31-zi0zKrDfN5Oe6As6I1KFxw-1; Thu, 16 Jul 2020 02:07:44 -0400 X-MC-Unique: zi0zKrDfN5Oe6As6I1KFxw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AAA1D1081; Thu, 16 Jul 2020 06:07:42 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-234.ams2.redhat.com [10.36.112.234]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 64AEF5C1C3; Thu, 16 Jul 2020 06:07:39 +0000 (UTC) Subject: Re: [PATCH for-5.1 1/2] msf2: Unbreak device-list-properties for "msf-soc" To: sundeep subbaraya , Markus Armbruster References: <20200715140440.3540942-1-armbru@redhat.com> <20200715140440.3540942-2-armbru@redhat.com> <87wo34u9fv.fsf@dusky.pond.sub.org> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <9b3f870c-481f-79f1-e55e-074ee0d95633@redhat.com> Date: Thu, 16 Jul 2020 08:07:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/16 00:51:36 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-riscv@nongnu.org, Sagar Karandikar , Bastian Koppelmann , Alistair Francis , Mark Cave-Ayland , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , QEMU Developers , Beniamino Galvani , nieklinnenbank@gmail.com, qemu-arm , palmer@dabbelt.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 16/07/2020 04.59, sundeep subbaraya wrote: > On Wed, Jul 15, 2020 at 8:12 PM Markus Armbruster wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> On 7/15/20 4:04 PM, Markus Armbruster wrote: >>>> Watch this: >>>> >>>> $ qemu-system-aarch64 -M ast2600-evb -S -display none -qmp stdio >>>> {"QMP": {"version": {"qemu": {"micro": 50, "minor": 0, "major": 5}, "package": "v5.0.0-2464-g3a9163af4e"}, "capabilities": ["oob"]}} >>>> {"execute": "qmp_capabilities"} >>>> {"return": {}} >>>> {"execute": "device-list-properties", "arguments": {"typename": "msf2-soc"}} >>>> Unsupported NIC model: ftgmac100 >>>> armbru@dusky:~/work/images$ echo $? >>>> 1 >>>> >>>> This is what breaks "make check SPEED=slow". >>>> >>>> Root cause is m2sxxx_soc_initfn()'s messing with nd_table[] via >>>> qemu_check_nic_model(). That's wrong. >>>> >>>> We fixed the exact same bug for device "allwinner-a10" in commit >>>> 8aabc5437b "hw/arm/allwinner-a10: Do not use nd_table in instance_init >>>> function". Fix this instance the same way: move the offending code to >>>> m2sxxx_soc_realize(), where it's less wrong, and add a FIXME comment. >>> >>> That addresses this other thread, right? >>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg720658.html >> >> Correct! I wasn't aware of it, thanks for making the connection. >> > > Thanks Markus for the fix. It's rather just a work-around that avoids the crash than a real fix. I think we can use it for the upcoming 5.1 release, but it would be great if you could rework this code for 5.2, so that the nd_table handling is moved to msf2-som.c instead. Thanks, Thomas