From: Andrea Bolognani <abologna@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard W . M . Jones" <rjones@redhat.com>,
qemu-devel@nongnu.org, "Pino Toscano" <ptoscano@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>, 周文青 <1151451036@qq.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-block@nongnu.org, "Max Reitz" <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API
Date: Wed, 14 Aug 2019 16:51:48 +0200 [thread overview]
Message-ID: <9becb1b8d13703740411ae0e1e6e0580fe6a1bc7.camel@redhat.com> (raw)
In-Reply-To: <ca03335f-55a1-322f-401d-a02a2d115b66@redhat.com>
On Wed, 2019-08-14 at 16:15 +0200, Philippe Mathieu-Daudé wrote:
> On 8/14/19 3:27 PM, Andrea Bolognani wrote:
> > On Wed, 2019-08-14 at 14:15 +0200, Philippe Mathieu-Daudé wrote:
> > > The libssh packaged by a distribution can predate version 0.8,
> > > but still provides the newer API introduced after version 0.7.
> > >
> > > Using the deprecated API leads to build failure, as on Ubuntu 18.04:
> > >
> > > CC block/ssh.o
> > > block/ssh.c: In function 'check_host_key_hash':
> > > block/ssh.c:444:5: error: 'ssh_get_publickey' is deprecated [-Werror=deprecated-declarations]
> > > r = ssh_get_publickey(s->session, &pubkey);
> > > ^
> > > In file included from block/ssh.c:27:0:
> > > /usr/include/libssh/libssh.h:489:31: note: declared here
> > > SSH_DEPRECATED LIBSSH_API int ssh_get_publickey(ssh_session session, ssh_key *key);
> > > ^~~~~~~~~~~~~~~~~
> > > rules.mak:69: recipe for target 'block/ssh.o' failed
> > > make: *** [block/ssh.o] Error 1
> > >
> > > Fix by using the newer API if available.
> > >
> > > Suggested-by: Andrea Bolognani <abologna@redhat.com>
> > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > > ---
> > > block/ssh.c | 2 +-
> > > configure | 7 +++++++
> > > 2 files changed, 8 insertions(+), 1 deletion(-)
> >
> > Did I really suggest this? I have no recollection of doing so, or
> > even getting involved with libssh support in QEMU at all for that
> > matter.
>
> I took this suggestion from
> https://www.redhat.com/archives/libvir-list/2018-May/msg00597.html
I see :)
I feel like adding a Suggested-by because of something that was
posted on an unrelated project's mailing list is stretching the
definition of the tag a bit, so if you end up having to respin I
think it would be reasonable to drop it, but honestly it's not a
big deal either way: I was just curious.
--
Andrea Bolognani / Red Hat / Virtualization
next prev parent reply other threads:[~2019-08-14 14:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 12:15 [Qemu-devel] [PATCH 0/4] configure: Fix libssh on Ubuntu 18.04 Philippe Mathieu-Daudé
2019-08-14 12:15 ` [Qemu-devel] [RFC PATCH 1/4] configure: Improve libssh check Philippe Mathieu-Daudé
2019-08-14 12:36 ` Pino Toscano
2019-08-14 12:15 ` [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API Philippe Mathieu-Daudé
2019-08-14 12:35 ` Pino Toscano
2019-08-14 13:27 ` Andrea Bolognani
2019-08-14 14:15 ` Philippe Mathieu-Daudé
2019-08-14 14:51 ` Andrea Bolognani [this message]
2019-08-14 15:14 ` Philippe Mathieu-Daudé
2019-08-15 8:52 ` Andrea Bolognani
2019-08-14 12:15 ` [Qemu-devel] [PATCH 3/4] configure: Improve checking libssh version is 0.8 Philippe Mathieu-Daudé
2019-08-14 12:39 ` Pino Toscano
2019-08-14 12:15 ` [Qemu-devel] [PATCH 4/4] configure: Log the libssh version detected Philippe Mathieu-Daudé
2019-08-14 12:29 ` Richard W.M. Jones
2019-08-14 12:41 ` Pino Toscano
2019-08-14 16:45 ` [Qemu-devel] [PATCH 0/4] configure: Fix libssh on Ubuntu 18.04 no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9becb1b8d13703740411ae0e1e6e0580fe6a1bc7.camel@redhat.com \
--to=abologna@redhat.com \
--cc=1151451036@qq.com \
--cc=alex.bennee@linaro.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=ptoscano@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).