From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Claudio Fontana" <cfontana@suse.de>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Cameron Esfahani" <dirty@apple.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Roman Bolshakov" <r.bolshakov@yadro.com>,
"Wenchao Wang" <wenchao.wang@intel.com>,
"Sunil Muthuswamy" <sunilmut@microsoft.com>,
"Colin Xu" <colin.xu@intel.com>
Subject: Re: [PATCH for-6.1 4/4] configure: Poison all current target-specific #defines
Date: Thu, 15 Apr 2021 13:21:44 +0200 [thread overview]
Message-ID: <9c7313b0-2b5c-03e2-fe04-2f0bfa2f6470@redhat.com> (raw)
In-Reply-To: <529f4022-aa17-2b41-294d-a293b0461690@redhat.com>
On 15/04/2021 10.34, Philippe Mathieu-Daudé wrote:
> +Richard/Claudio
>
> On 4/14/21 1:20 PM, Thomas Huth wrote:
>> We are generating a lot of target-specific defines in the *-config-devices.h
>> and *-config-target.h files. Using them in common code is wrong and leads
>> to very subtle bugs since a "#ifdef CONFIG_SOMETHING" is not working there
>> as expected. To avoid these issues, we are already poisoning many of the
>> macros in include/exec/poison.h - but it's cumbersome to maintain this
>> list manually. Thus let's generate an additional list of poisoned macros
>> automatically from the current config switches - this should give us a
>> much better test coverage via the different CI configurations.
>>
>> Note that CONFIG_TCG (which is also defined in config-host.h) and
>> CONFIG_USER_ONLY are special, so we have to filter these out.
>
> I know if we poison CONFIG_TCG, almost nothing build, but I fail to
> see how it is different from the other accelerators.
You could argue that TCG is not specific to a target, i.e. it is either
available for all targets, or it is disabled for all targets, so this is
rather like a host config option than a target specific option.
>> diff --git a/configure b/configure
>> index 4f374b4889..a0f0601e7e 100755
>> --- a/configure
>> +++ b/configure
>> @@ -6440,6 +6440,11 @@ if test -n "${deprecated_features}"; then
>> echo " features: ${deprecated_features}"
>> fi
>>
>
> Maybe a one line comment (but since it is obvious, I don't mind):
>
> # Filter out CONFIG_TCG and CONFIG_USER_ONLY which are special
Ok, makes sense, I can add that.
>> +sed -n -e '/CONFIG_TCG/d' -e '/CONFIG_USER_ONLY/d' \
>> + -e '/^#define / { s///; s/ .*//; s/^/#pragma GCC poison /p; }' \
>> + *-config-devices.h *-config-target.h | \
>> + sort -u > config-poison.h
>> +
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks!
Thomas
prev parent reply other threads:[~2021-04-15 11:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 11:20 [PATCH for-6.1 0/4] Poison more CONFIG switches Thomas Huth
2021-04-14 11:20 ` [PATCH for-6.1 1/4] include/sysemu: Poison all accelerator CONFIG switches in common code Thomas Huth
2021-04-14 16:56 ` Philippe Mathieu-Daudé
2021-04-14 11:20 ` [PATCH for-6.1 2/4] migration: Move populate_vfio_info() into a separate file Thomas Huth
2021-04-14 12:22 ` Dr. David Alan Gilbert
2021-04-14 12:33 ` Philippe Mathieu-Daudé
2021-05-03 6:04 ` Thomas Huth
2021-04-14 11:20 ` [PATCH for-6.1 3/4] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code Thomas Huth
2021-04-14 13:55 ` Markus Armbruster
2021-04-15 6:15 ` Thomas Huth
2021-04-15 7:44 ` Markus Armbruster
2021-04-15 8:03 ` Thomas Huth
2021-04-14 11:20 ` [PATCH for-6.1 4/4] configure: Poison all current target-specific #defines Thomas Huth
2021-04-15 8:34 ` Philippe Mathieu-Daudé
2021-04-15 11:21 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c7313b0-2b5c-03e2-fe04-2f0bfa2f6470@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=cfontana@suse.de \
--cc=colin.xu@intel.com \
--cc=dgilbert@redhat.com \
--cc=dirty@apple.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=r.bolshakov@yadro.com \
--cc=richard.henderson@linaro.org \
--cc=sunilmut@microsoft.com \
--cc=wenchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).