Re: [PATCH] gitlab-ci: Restrict jobs using Docker to runners having 'docker' tag

[Thomas Huth <thuth@redhat.com>]

On 19/03/2021 01.43, Philippe Mathieu-Daudé wrote:
> When a job is based on a Docker image [1], or is using a Docker
> service, it requires a runner with Docker installed.
> 
> Gitlab shared runners provide the 'docker' tag when they have it
> installed.
> 
> Are Gitlab shared runners are limited resources, we'd like to

s/Are/As/

> add more runners to QEMU repositories hosted on Gitlab. If a
> runner doesn't provide Docker, our jobs requiring it will fail.
> 
> Use the standard 'docker' tag to mark the jobs requiring Docker
> on the runner.
> 
> [1] https://docs.gitlab.com/ee/ci/yaml/#image
> [2] https://docs.gitlab.com/ee/ci/yaml/#services
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
[...]
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index f65cb11c4d3..d4511cf7dea 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -14,6 +14,8 @@ include:
>     - local: '/.gitlab-ci.d/crossbuilds.yml'
>   
>   .native_build_job_template: &native_build_job_definition
> +  tags:
> +  - docker
>     stage: build
>     image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest
>     before_script:
> @@ -38,6 +40,8 @@ include:
>         fi
>   
>   .native_test_job_template: &native_test_job_definition
> +  tags:
> +  - docker
>     stage: test
>     image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest
>     script:

If you add it to the templates ... won't this disable most of the jobs on 
the dedicated runners that don't have docker? Wouldn't it be better to add 
the tag only to the jobs that run "make check-tcg" ?

  Thomas