From: Pavel Dovgalyuk <dovgaluk@ispras.ru>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@gmail.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, alex.bennee@linaro.org,
pavel.dovgaluk@ispras.ru, rth@twiddle.net
Subject: Re: [PATCH] replay: fix replay shutdown for console mode
Date: Mon, 1 Jun 2020 13:36:02 +0300 [thread overview]
Message-ID: <9d0d9986-e225-104b-b83d-fb7dd14f25d7@ispras.ru> (raw)
In-Reply-To: <159012995470.27967.18129611453659045726.stgit@pasha-ThinkPad-X280>
ping
On 22.05.2020 09:45, Pavel Dovgalyuk wrote:
> When QEMU is used without any graphical window,
> QEMU execution is terminated with the signal (e.g., Ctrl-C).
> Signal processing in QEMU does not include
> qemu_system_shutdown_request call. That is why shutdown
> event is not recorded by record/replay in this case.
> This patch adds shutdown event to the end of the record log.
> Now every replay will shutdown the machine at the end.
>
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
> ---
> 0 files changed
>
> diff --git a/replay/replay.c b/replay/replay.c
> index 53edad1377..83ed9e0e24 100644
> --- a/replay/replay.c
> +++ b/replay/replay.c
> @@ -366,6 +366,11 @@ void replay_finish(void)
> /* finalize the file */
> if (replay_file) {
> if (replay_mode == REPLAY_MODE_RECORD) {
> + /*
> + * Can't do it in the signal handler, therefore
> + * add shutdown event here for the case of Ctrl-C.
> + */
> + replay_shutdown_request(SHUTDOWN_CAUSE_HOST_SIGNAL);
> /* write end event */
> replay_put_event(EVENT_END);
>
>
next prev parent reply other threads:[~2020-06-01 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 6:45 [PATCH] replay: fix replay shutdown for console mode Pavel Dovgalyuk
2020-05-22 11:27 ` no-reply
2020-06-01 10:36 ` Pavel Dovgalyuk [this message]
2020-06-04 19:01 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d0d9986-e225-104b-b83d-fb7dd14f25d7@ispras.ru \
--to=dovgaluk@ispras.ru \
--cc=Pavel.Dovgaluk@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).