From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, qemu-riscv@nongnu.org, laurent@vivier.eu
Subject: Re: [PATCH 16/21] linux-user/riscv: Implement setup_sigtramp
Date: Wed, 16 Jun 2021 18:50:14 +0200 [thread overview]
Message-ID: <9d712d66-ad8d-e08c-e793-dbb06264e19a@amsat.org> (raw)
In-Reply-To: <20210616011209.1446045-17-richard.henderson@linaro.org>
On 6/16/21 3:12 AM, Richard Henderson wrote:
> Create and record the rt signal trampoline.
>
> This fixes a bug wrt libgcc fallback unwinding. It expects
> the stack pointer to point to the siginfo_t, whereas we had
> inexplicably placed our private signal trampoline at the start
> of the signal frame instead of the end. Now moot because we
> have removed it from the stack frame entirely.
>
> Cc: qemu-riscv@nongnu.org
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/riscv/target_signal.h | 2 ++
> linux-user/riscv/signal.c | 22 +++++++++++++---------
> 2 files changed, 15 insertions(+), 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2021-06-16 16:54 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 1:11 [PATCH 00/21] linux-user: Move signal trampolines to new page Richard Henderson
2021-06-16 1:11 ` [PATCH 01/21] linux-user: Add infrastructure for a signal trampoline page Richard Henderson
2021-06-16 13:36 ` Max Filippov
2021-06-16 1:11 ` [PATCH 02/21] linux-user/aarch64: Implement setup_sigtramp Richard Henderson
2021-06-16 17:00 ` Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 03/21] linux-user/arm: Force v2 frames for fdpic Richard Henderson
2021-06-16 17:01 ` Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 04/21] linux-user/arm: Implement setup_sigtramp Richard Henderson
2021-06-16 13:46 ` Alex Bennée
2021-06-16 13:49 ` Alex Bennée
2021-06-16 17:40 ` Richard Henderson
2021-06-16 1:11 ` [PATCH 05/21] linux-user/alpha: " Richard Henderson
2021-06-16 16:56 ` Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 06/21] linux-user/cris: " Richard Henderson
2021-06-16 16:37 ` Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 07/21] linux-user/hexagon: " Richard Henderson
2021-06-16 8:07 ` Taylor Simpson
2021-06-16 15:05 ` Richard Henderson
2021-06-16 15:50 ` Richard Henderson
2021-06-16 21:37 ` Taylor Simpson
2021-06-16 23:15 ` Richard Henderson
2021-06-16 1:11 ` [PATCH 08/21] linux-user/hppa: Document non-use of setup_sigtramp Richard Henderson
2021-06-16 10:46 ` Philippe Mathieu-Daudé
2021-06-16 21:16 ` Alex Bennée
2021-06-16 1:11 ` [PATCH 09/21] linux-user/i386: Implement setup_sigtramp Richard Henderson
2021-06-16 1:11 ` [PATCH 10/21] linux-user/m68k: " Richard Henderson
2021-06-16 16:42 ` Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 11/21] linux-user/microblaze: " Richard Henderson
2021-06-16 16:43 ` Philippe Mathieu-Daudé
2021-06-16 1:12 ` [PATCH 12/21] linux-user/mips: " Richard Henderson
2021-06-16 16:48 ` Philippe Mathieu-Daudé
2021-06-16 1:12 ` [PATCH 13/21] linux-user/nios2: Document non-use of setup_sigtramp Richard Henderson
2021-06-16 1:12 ` [PATCH 14/21] linux-user/openrisc: Implement setup_sigtramp Richard Henderson
2021-06-16 16:49 ` Philippe Mathieu-Daudé
2021-06-17 0:24 ` Stafford Horne
2021-06-16 1:12 ` [PATCH 15/21] linux-user/ppc: " Richard Henderson
2021-06-16 1:12 ` [PATCH 16/21] linux-user/riscv: " Richard Henderson
2021-06-16 16:50 ` Philippe Mathieu-Daudé [this message]
2021-06-18 1:29 ` Alistair Francis
2021-06-16 1:12 ` [PATCH 17/21] linux-user/s390x: " Richard Henderson
2021-06-16 16:52 ` Philippe Mathieu-Daudé
2021-06-16 1:12 ` [PATCH 18/21] linux-user/sh4: " Richard Henderson
2021-06-16 16:53 ` Philippe Mathieu-Daudé
2021-06-16 1:12 ` [PATCH 19/21] linux-user/sparc: " Richard Henderson
2021-06-16 1:12 ` [PATCH 20/21] linux-user/xtensa: " Richard Henderson
2021-06-16 13:35 ` Max Filippov
2021-06-16 1:12 ` [PATCH 21/21] linux-user: Remove default for TARGET_ARCH_HAS_SIGTRAMP_PAGE Richard Henderson
2021-06-16 16:54 ` Philippe Mathieu-Daudé
2021-06-16 15:05 ` [PATCH 00/21] linux-user: Move signal trampolines to new page Alex Bennée
2021-06-16 15:09 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d712d66-ad8d-e08c-e793-dbb06264e19a@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).