From: Richard Henderson <richard.henderson@linaro.org>
To: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, alex.bennee@linaro.org
Subject: Re: [PATCH] replay: fix watchpoint processing for reverse debugging
Date: Tue, 25 May 2021 16:11:19 -0700 [thread overview]
Message-ID: <9dcfaaf0-e88a-f15f-a587-2024bf942b69@linaro.org> (raw)
In-Reply-To: <162072430303.827403.7379783546934958566.stgit@pasha-ThinkPad-X280>
On 5/11/21 2:11 AM, Pavel Dovgalyuk wrote:
> This patch enables reverse debugging with watchpoints.
> Reverse continue scans the execution to find the breakpoints
> and watchpoints that should fire. It uses helper function
> replay_breakpoint() for that. But this function needs to access
> icount, which can't be correct in the middle of TB.
> Therefore, in case of watchpoint, we have to retranslate the block
> to allow this access.
>
> Signed-off-by: Pavel Dovgalyuk<Pavel.Dovgalyuk@ispras.ru>
> ---
> softmmu/physmem.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Queued to tcg-next, thanks.
r~
prev parent reply other threads:[~2021-05-25 23:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 9:11 [PATCH] replay: fix watchpoint processing for reverse debugging Pavel Dovgalyuk
2021-05-25 6:40 ` Pavel Dovgalyuk
2021-05-25 23:11 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dcfaaf0-e88a-f15f-a587-2024bf942b69@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=pavel.dovgalyuk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).