QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Amit Shah <amit@kernel.org>
To: Pan Nengyuan <pannengyuan@huawei.com>, mst@redhat.com
Cc: liyiting@huawei.com, kuhn.chenqun@huawei.com,
	qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com
Subject: Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer
Date: Fri, 06 Dec 2019 09:56:47 +0100
Message-ID: <9e0aba878c29bdda0a8badee3919bc0a46ca0604.camel@kernel.org> (raw)
In-Reply-To: <32796046-ef9b-6157-3bd0-23eef4d4950b@huawei.com>

On Fri, 2019-12-06 at 10:17 +0800, Pan Nengyuan wrote:
> On 2019/12/6 0:45, Amit Shah wrote:
> > On Wed, 2019-12-04 at 15:31 +0800, pannengyuan@huawei.com wrote:
> > > From: Pan Nengyuan <pannengyuan@huawei.com>
> > 
> > Shouldn't this be From: mst?
> > 
> > I didn't find a ref to the original patch to confirm if you had to
> > adapt it in any way, though.
> > 
> 
> Here is the original
> patch: 
> https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg00402.html
> 
> I just change one line(set used_elems to NULL). In next version, I
> will
> change function name from virtio_delete_queue to virtio_queue_cleanup
> (It's too similar between "virtio_del_queue" and
> "virtio_delete_queue"):
> 
https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg00877.html
> .
> 
> According to these, should I change it in next version?

Sure, please change it.  Please ensure 'From:' is Michael, but in the
sign-off area, you can mention how you changed the original patch, e.g.
see the "[PMM: ...]" in



https://lore.kernel.org/qemu-devel/20191126141239.8219-5-peter.maydell@linaro.org/

Also, please CC me on the entire series.

Thanks,




  reply index

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04  7:31 pannengyuan
2019-12-04  7:31 ` [PATCH v2 2/3] virtio-balloon: fix memory leak while attach virtio-balloon device pannengyuan
2019-12-04 10:16   ` Laurent Vivier
2019-12-04  7:31 ` [PATCH v2 3/3] virtio-serial-bus: fix memory leak while attach virtio-serial-bus pannengyuan
2019-12-04 10:17   ` Laurent Vivier
2019-12-04 14:41   ` Eric Blake
2019-12-09 16:51   ` Michael S. Tsirkin
2019-12-04  8:33 ` [PATCH v2 1/3] virtio: add ability to delete vq through a pointer Pankaj Gupta
2019-12-05  2:30   ` Pan Nengyuan
2019-12-05  4:51     ` Pankaj Gupta
2019-12-09 15:58   ` Michael S. Tsirkin
2019-12-04  9:40 ` Laurent Vivier
2019-12-04 14:40 ` Eric Blake
2019-12-05  2:35   ` Pan Nengyuan
2019-12-05 16:45 ` Amit Shah
2019-12-06  2:17   ` Pan Nengyuan
2019-12-06  8:56     ` Amit Shah [this message]
2019-12-06  9:00       ` Pan Nengyuan
2019-12-09 16:43 ` Michael S. Tsirkin
2019-12-09 16:58   ` Michael S. Tsirkin
2019-12-10  2:08     ` Pan Nengyuan

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e0aba878c29bdda0a8badee3919bc0a46ca0604.camel@kernel.org \
    --to=amit@kernel.org \
    --cc=kuhn.chenqun@huawei.com \
    --cc=liyiting@huawei.com \
    --cc=mst@redhat.com \
    --cc=pannengyuan@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
		qemu-devel@nongnu.org
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git