qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>,
	Peter Maydell <peter.maydell@linaro.org>,
	Jason Wang <jasowang@redhat.com>,
	Laurent Vivier <laurent@vivier.eu>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 0/3] hw: More dma_memory_read/write() API cleanup
Date: Sat, 22 Feb 2020 19:39:14 +0000	[thread overview]
Message-ID: <9e4081f7-3ae0-fb8f-462a-d196ec499d19@ilande.co.uk> (raw)
In-Reply-To: <20200221132550.22156-1-philmd@redhat.com>

On 21/02/2020 13:25, Philippe Mathieu-Daudé wrote:

> Following up "global exec/memory/dma APIs cleanup"
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg681475.html
> 
> Few more cleanups in PCNET & SCSI ESP devices.
> 
> Philippe Mathieu-Daudé (3):
>   hw/dma/sparc32_dma: Make espdma_memory_[read/write] static
>   hw/scsi/esp: Let ESPDMAMemoryReadWriteFunc take void pointer and
>     size_t
>   hw/net/pcnet: Let phys_mem_read/write take void pointer and boolean
> 
>  hw/net/pcnet.h                 |  4 ++--
>  include/hw/scsi/esp.h          |  2 +-
>  include/hw/sparc/sparc32_dma.h |  6 ++----
>  hw/dma/sparc32_dma.c           |  8 ++++----
>  hw/net/pcnet-pci.c             |  5 +++--
>  hw/net/pcnet.c                 | 16 ++++++++--------
>  hw/scsi/esp-pci.c              |  6 +++---
>  7 files changed, 23 insertions(+), 24 deletions(-)

LGTM.

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.


      parent reply	other threads:[~2020-02-22 19:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-21 13:25 [PATCH 0/3] hw: More dma_memory_read/write() API cleanup Philippe Mathieu-Daudé
2020-02-21 13:25 ` [PATCH 1/3] hw/dma/sparc32_dma: Make espdma_memory_[read/write] static Philippe Mathieu-Daudé
2020-02-21 13:27   ` Peter Maydell
2020-02-21 13:25 ` [PATCH 2/3] hw/scsi/esp: Let ESPDMAMemoryReadWriteFunc take void pointer and size_t Philippe Mathieu-Daudé
2020-02-21 13:25 ` [PATCH 3/3] hw/net/pcnet: Let phys_mem_read/write take void pointer and boolean Philippe Mathieu-Daudé
2020-02-21 16:34 ` [PATCH 0/3] hw: More dma_memory_read/write() API cleanup Paolo Bonzini
2020-02-22 19:39 ` Mark Cave-Ayland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e4081f7-3ae0-fb8f-462a-d196ec499d19@ilande.co.uk \
    --to=mark.cave-ayland@ilande.co.uk \
    --cc=fam@euphon.net \
    --cc=jasowang@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).