From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5225FC4361B for ; Thu, 17 Dec 2020 11:38:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D779823741 for ; Thu, 17 Dec 2020 11:38:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D779823741 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kprbi-0007Yg-Oy for qemu-devel@archiver.kernel.org; Thu, 17 Dec 2020 06:38:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kprX2-0002SY-Qg for qemu-devel@nongnu.org; Thu, 17 Dec 2020 06:33:17 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:33115) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kprX1-0005ja-46 for qemu-devel@nongnu.org; Thu, 17 Dec 2020 06:33:16 -0500 Received: from [192.168.100.1] ([82.252.144.198]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MsI0K-1jwOWo0l8U-00tn77; Thu, 17 Dec 2020 12:33:12 +0100 Subject: Re: [PATCH v2 3/4] linux-user/sparc: Don't restore %g7 in sparc64_set_context() To: Peter Maydell , qemu-devel@nongnu.org References: <20201106152738.26026-1-peter.maydell@linaro.org> <20201106152738.26026-4-peter.maydell@linaro.org> From: Laurent Vivier Message-ID: <9ee3d3b4-ca5c-dbc8-d735-300d172a4290@vivier.eu> Date: Thu, 17 Dec 2020 12:33:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201106152738.26026-4-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:03lrXPLIF3EzbLw+cuzW2QtEkjbIJnRYge4Qdghd6ZFfze9pK3q pTdqYpKMFLQovyx2giY3YNpTulT6R0rH3fT5dLp9A9ELZqnM45yRfVrMmJAnJQ9EhdGTSRG ZBrB2PsByU6Y2+FSTqEsncKiUlRSNT3IimfxnO1/aSpyUT3t/Y1zf+5F/XuhCoM2Qhwn8N8 tyEgdq5haPSZUK+KvoYsg== X-UI-Out-Filterresults: notjunk:1;V03:K0:4CaY6t+w6Gs=:SqI/q/WhNl3kWHQwd4gctN Wu4vw9nHbnAeNmvhGsugkB58993p2nWO/Z8q4FqM6lrCO6yT0moqNYKkoycKGtWiES5z/jipp y6+Zd8mjsBoRJr/Rm2gDToD14iJ+SGz4hx2cGczAFQa70wz9hQ0mGjpGDqyyTnogxiQAP09/K LMg+u8a0XzPmtZOjNmmz667/7/VyvG4D09YSmczt+UbF/tXVg/3QFkn574ZsxPsLkIuP/tokJ yFbSjw/+bARCbEYi9r8JSdvnJCB90YhmRO0JZspRXoYmgL/a3jlUA6hrrvsjGmn1/AvdEvIpT yURVhVdnwJgGmXmsE7bYkNN7wgWZypgdXM5uSJUcib27MzbmMAYY3E9X0oyOiEmftsOdk+luF OZkSk1m5dXMImmfNr5okJMAlO6lM8nMWUWysIdxJLKFQjN/O9iTYmmxikjnvGb3KfwMXPtxfv StckApJzMw== Received-SPF: none client-ip=217.72.192.74; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Giuseppe Musacchio , Richard Henderson , Mark Cave-Ayland Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 06/11/2020 à 16:27, Peter Maydell a écrit : > The kernel does not restore the g7 register in sparc64_set_context(); > neither should we. (We still save it in sparc64_get_context().) > > Signed-off-by: Peter Maydell > --- > linux-user/sparc/signal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/sparc/signal.c b/linux-user/sparc/signal.c > index 43dcd137f51..ed32c7abd17 100644 > --- a/linux-user/sparc/signal.c > +++ b/linux-user/sparc/signal.c > @@ -447,7 +447,7 @@ void sparc64_set_context(CPUSPARCState *env) > __get_user(env->gregs[4], (&(*grp)[SPARC_MC_G4])); > __get_user(env->gregs[5], (&(*grp)[SPARC_MC_G5])); > __get_user(env->gregs[6], (&(*grp)[SPARC_MC_G6])); > - __get_user(env->gregs[7], (&(*grp)[SPARC_MC_G7])); > + /* Skip g7 as that's the thread register in userspace */ > > /* > * Note that unlike the kernel, we didn't need to mess with the > Applied to my linux-user-for-6.0 branch. Thanks, Laurent