From: Laszlo Ersek <lersek@redhat.com>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: Thread safety of coroutine-sigaltstack
Date: Fri, 22 Jan 2021 22:34:14 +0100 [thread overview]
Message-ID: <9f9dbda6-0011-36af-1f5b-22d15c7eb09f@redhat.com> (raw)
In-Reply-To: <7353bcda-6363-6f56-75ad-5e2e9e0dbb16@redhat.com>
On 01/22/21 21:38, Laszlo Ersek wrote:
> On 01/21/21 18:24, Paolo Bonzini wrote:
>> On 21/01/21 17:44, Peter Maydell wrote:
>>> On Thu, 21 Jan 2021 at 16:10, Daniel P. Berrangé <berrange@redhat.com>
>>> wrote:
>>>> FWIW The libucontext impl is all ASM based and has coverage for all the
>>>> arches we care about:
>>>>
>>>> https://github.com/kaniini/libucontext
>>>>
>>>> so doesn't seem like there's a need for coroutine-asm if we can rely
>>>> on libucontext for portability where neede.
>>>
>>> The README for that notes a couple of pretty major omissions:
>>> * it doesn't handle floating point registers
>>> * it doesn't do anything about the signal mask
>>> I'm pretty sure that not handling the fp regs could cause breakage
>>> for Arm at least (depending on what the compiler chooses to do
>>> in the functions that work with the ucontext functions). The
>>> signal mask stuff might be OK for us because of the carefully
>>> limited use we make of the ucontext functions, but it would be
>>> a bit of a pain to have to analyse that code for both sets of semantics.
>>
>> The lack of signal mask handling is an improvement for us. :) We want
>> the signal mask to be per thread, not per coroutine.
>
> I didn't quite get this when I first read it, but now that I'm digging
> through the code, I have a follow-up comment.
>
> According to POSIX, passing savemask=0 to sigsetjmp() may or may not
> save the current signal mask, into "env". A nonzero savemask is required
> to save the signal mask, but a zero savemask is not forbidden to -- it
> is only not required to:
>
> https://pubs.opengroup.org/onlinepubs/9699919799/functions/sigsetjmp.html#tag_16_554_07
>
> Note that since this function is defined in terms of setjmp(), if
> savemask is zero, it is unspecified whether the signal mask is
> saved.
>
> And I feel that's a bit of a problem, because when we first exit the
> trampoline -- executed as a signal handler -- via sigsetjmp(), *all
> signals* are masked, and sigsetjmp might actually stash that mask in
> "tr_reenter", because savemask=0 does not suffice for forbidding that.
>
> When we reenter the trampoline via siglongjmp(tr_reenter), and
> subsequently call coroutine_bootstrap(), it's possible (per POSIX, see
> above) that all signals are masked again. And then that could further be
> remembered in "self->env", in coroutine_bootstrap(). Which would be
> wrong IMO; co-routines in general should receive synchronous signals if
> they mess up somewhere (terminating the process).
>
> IOW, just before the call to coroutine_bootstrap(),
> coroutine_trampoline() should explicitly restore the signal mask that
> was in effect when qemu_coroutine_new() was entered.
>
> Has this been a problem in practice, or should we ignore it?
>
> IOW, should we assume "savemask=0" for *never* saving the signal mask?
>
> The behavior of "savemask=0" is a platform trait that platforms are not
> required to document (the behavior is unspecified, not
> implementation-defined), so it really boils down to where this code
> actually runs...
>
> NB Linux is more specific:
>
> https://man7.org/linux/man-pages/man3/setjmp.3.html
>
> sigsetjmp() and siglongjmp()
> sigsetjmp() and siglongjmp() also perform nonlocal gotos, but
> provide predictable handling of the process signal mask.
>
> If, and only if, the savesigs argument provided to sigsetjmp() is
> nonzero, the process's current signal mask is saved in env and
> will be restored if a siglongjmp() is later performed with this
> env.
>
> Cue "and only if".
... I notice commit 6ab7e5465a4d ("Replace all setjmp()/longjmp() with
sigsetjmp()/siglongjmp()", 2013-02-23) chose the Linux definition, not
the POSIX one.
Thanks
Laszlo
next prev parent reply other threads:[~2021-01-22 21:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 16:26 Thread safety of coroutine-sigaltstack Max Reitz
2021-01-20 16:50 ` Paolo Bonzini
2021-01-20 16:58 ` Eric Blake
2021-01-20 17:25 ` Laszlo Ersek
2021-01-21 9:27 ` Max Reitz
2021-01-21 13:34 ` Laszlo Ersek
2021-01-21 15:42 ` Max Reitz
2021-01-21 16:04 ` Daniel P. Berrangé
2021-01-21 16:05 ` Laszlo Ersek
2021-01-21 15:14 ` Paolo Bonzini
2021-01-21 16:07 ` Daniel P. Berrangé
2021-01-21 16:44 ` Peter Maydell
2021-01-21 17:24 ` Paolo Bonzini
2021-01-22 20:38 ` Laszlo Ersek
2021-01-22 21:34 ` Laszlo Ersek [this message]
2021-01-22 21:41 ` Laszlo Ersek
2021-01-22 7:55 ` Markus Armbruster
2021-01-22 8:48 ` Max Reitz
2021-01-22 10:14 ` Peter Maydell
2021-01-22 10:16 ` Max Reitz
2021-01-22 12:24 ` Laszlo Ersek
2021-01-23 0:06 ` Laszlo Ersek
2021-01-23 13:35 ` Peter Maydell
2021-01-25 22:15 ` Laszlo Ersek
2021-01-25 22:45 ` Paolo Bonzini
2021-01-26 8:57 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f9dbda6-0011-36af-1f5b-22d15c7eb09f@redhat.com \
--to=lersek@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).