From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD22AC433E0 for ; Tue, 4 Aug 2020 17:42:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB57F207FC for ; Tue, 4 Aug 2020 17:42:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB57F207FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=joshdubois.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k30x7-0006fk-U6 for qemu-devel@archiver.kernel.org; Tue, 04 Aug 2020 13:42:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k30wE-00063I-Ec for qemu-devel@nongnu.org; Tue, 04 Aug 2020 13:41:22 -0400 Received: from jax4mhob13.myregisteredsite.com ([64.69.218.93]:44812) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k30wC-0002p7-Vs for qemu-devel@nongnu.org; Tue, 04 Aug 2020 13:41:22 -0400 Received: from mailpod.hostingplatform.com (atl4qobmail01pod1.registeredsite.com [10.30.71.113]) by jax4mhob13.myregisteredsite.com (8.14.4/8.14.4) with ESMTP id 074HfDOX023253 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 4 Aug 2020 13:41:19 -0400 Received: (qmail 6687 invoked by uid 0); 4 Aug 2020 17:41:13 -0000 X-TCPREMOTEIP: 50.93.248.134 X-Authenticated-UID: josh@joshdubois.com Received: from unknown (HELO ?192.168.1.5?) (josh@joshdubois.com@50.93.248.134) by 0 with ESMTPA; 4 Aug 2020 17:41:13 -0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH] trace/simple: Allow enabling simple traces from command line From: Josh DuBois In-Reply-To: <87h7tkm70n.fsf@dusky.pond.sub.org> Date: Tue, 4 Aug 2020 12:41:12 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20200723053359.256928-1-josh@joshdubois.com> <20200729130535.GI37763@stefanha-x1.localdomain> <87h7tkm70n.fsf@dusky.pond.sub.org> To: Markus Armbruster X-Mailer: Apple Mail (2.3608.80.23.2.2) Received-SPF: neutral client-ip=64.69.218.93; envelope-from=josh@joshdubois.com; helo=jax4mhob13.myregisteredsite.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/04 13:41:19 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi , Josh DuBois , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Aug 3, 2020, at 4:08 AM, Markus Armbruster wrote: >=20 >>=20 >> - prior to db25d56c014aa1a96319c663e0a60346a223b31e, just like today, >> QEMU built with simple tracing will always produce a trace- = file, >> regardless of whether the user asks for traces at runtime. >=20 > When you send a patch with a Fixes: tag, consider cc'ing people = involved > in the commit being fixed. I might have spotted the regression. Sure, this makes sense. =20 > I missed the CLI issue. I just wanted my directories not littered = with > trace files ;) >=20 > Stefan, what shall we do for 5.1? >=20 > If we keep littering, the annoyance will make me drop the trace = backend > "simple" from my build tests. I might even remember to put it back = when > the fix arrives. I haven't seen another response, but I just noticed a 'last call' for = 5.1. If this means something is going to get excluded from regular = build tests, that seems important - I for one have no objection to = simply reverting this - 1b7157be3a8c4300fc8044d40f4b2e64a152a1b4 <-- my = "fix." I will try to send a better fix along sometime soonish, but I probably = won't get to that before 5.1. If the nuisance of the trace- files = is causing real-world problems for someone actually doing regular = development, that seems more important than the command line issue, to = me. Just my $0.02. Cheers, and sorry if your build dirs do end up littered again.=