From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: "qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
"fam@euphon.net" <fam@euphon.net>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Denis Lunev <den@virtuozzo.com>,
"armbru@redhat.com" <armbru@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"mreitz@redhat.com" <mreitz@redhat.com>,
"jsnow@redhat.com" <jsnow@redhat.com>
Subject: Re: [PATCH v5 00/15] Apply COR-filter to the block-stream permanently
Date: Mon, 1 Jun 2020 13:57:06 +0000 [thread overview]
Message-ID: <AM6PR08MB407077857517F552E121D413F48A0@AM6PR08MB4070.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <1589363456-1035571-1-git-send-email-andrey.shinkevich@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 4263 bytes --]
PINGING...
Please
________________________________
From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Sent: Wednesday, May 13, 2020 12:50 PM
To: qemu-block@nongnu.org <qemu-block@nongnu.org>
Cc: qemu-devel@nongnu.org <qemu-devel@nongnu.org>; kwolf@redhat.com <kwolf@redhat.com>; mreitz@redhat.com <mreitz@redhat.com>; armbru@redhat.com <armbru@redhat.com>; fam@euphon.net <fam@euphon.net>; jsnow@redhat.com <jsnow@redhat.com>; stefanha@redhat.com <stefanha@redhat.com>; eblake@redhat.com <eblake@redhat.com>; Denis Lunev <den@virtuozzo.com>; Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>; Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Subject: [PATCH v5 00/15] Apply COR-filter to the block-stream permanently
With this series, all the block-stream COR operations pass through
the COR-filter. The patches 01-08/15 are taken from the series
"block: Deal with filters" by Max Reitz, the full version of that
can be found in the branches:
https://git.xanclic.moe/XanClic/qemu child-access-functions-v6
https://github.com/XanClic/qemu child-access-functions-v6
When running iotests, apply "char-socket: Fix race condition"
to avoid sporadic segmentation faults.
v5:
01: Included forgotten file block/copy-on-read.h
v4:
01: Initialization of the COR-filter BDRVStateCOR member.
v3:
01: The COR filter insert/remove functions moved to block/copy-on-read.c
to be a part of API.
02: block/stream.c code refactoring.
03: The separate call to block_job_add_bdrv() is used to block operations
on the active node after the filter inserted and the job created.
04: The iotests case 030::test_overlapping_4 was modified to unbound
the block-stream job from the base node.
05: The COR driver functions preadv/pwritev replaced with their analogous
preadv/pwritev_part.
v2:
01: No more skipping filters while checking for operation blockers.
However, we exclude filters between the bottom node and base
because we do not set the operation blockers for filters anymore.
02: As stated above, we do not set the operation blockers for filters
anymore. So, skip filters when we block operations for the target
node.
03: The comment added for the patch 4/7.
04: The QAPI target version changed to 5.1.
05: The 'filter-node-name' now excluded from using in the test #030.
If we need it no more in a final version of the series, the patch
5/7 may be removed.
06: The COR-filter included into the frozen chain of a block-stream job.
The 'above_base' node pointer is left because it is essential for
finding the base node in case of filters above.
Andrey Shinkevich (7):
block: prepare block-stream for using COR-filter
copy-on-read: Support change filename functions
copy-on-read: Support preadv/pwritev_part functions
copy-on-read: add filter append/drop functions
qapi: add filter-node-name to block-stream
iotests: prepare 245 for using filter in block-stream
block: apply COR-filter to block-stream jobs
Max Reitz (8):
block: Mark commit and mirror as filter drivers
copy-on-read: Support compressed writes
block: Add child access functions
block: Add chain helper functions
block: Include filters when freezing backing chain
block: Use CAFs in block status functions
commit: Deal with filters when blocking intermediate nodes
block: Use CAFs when working with backing chains
block.c | 275 ++++++++++++++++++++++++++++++++++-------
block/commit.c | 85 ++++++++++---
block/copy-on-read.c | 159 ++++++++++++++++++++++--
block/copy-on-read.h | 36 ++++++
block/io.c | 19 +--
block/mirror.c | 6 +-
block/monitor/block-hmp-cmds.c | 4 +-
block/stream.c | 89 +++++++++----
blockdev.c | 19 ++-
include/block/block.h | 6 +-
include/block/block_int.h | 67 +++++++++-
qapi/block-core.json | 6 +
tests/qemu-iotests/030 | 17 +--
tests/qemu-iotests/141.out | 2 +-
tests/qemu-iotests/245 | 10 +-
15 files changed, 661 insertions(+), 139 deletions(-)
create mode 100644 block/copy-on-read.h
--
1.8.3.1
[-- Attachment #2: Type: text/html, Size: 7306 bytes --]
prev parent reply other threads:[~2020-06-01 13:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 9:50 [PATCH v5 00/15] Apply COR-filter to the block-stream permanently Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 01/15] block: Mark commit and mirror as filter drivers Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 02/15] copy-on-read: Support compressed writes Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 03/15] block: Add child access functions Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 04/15] block: Add chain helper functions Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 05/15] block: Include filters when freezing backing chain Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 06/15] block: Use CAFs in block status functions Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 07/15] commit: Deal with filters when blocking intermediate nodes Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 08/15] block: Use CAFs when working with backing chains Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 09/15] block: prepare block-stream for using COR-filter Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 10/15] copy-on-read: Support change filename functions Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 11/15] copy-on-read: Support preadv/pwritev_part functions Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 12/15] copy-on-read: add filter append/drop functions Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 13/15] qapi: add filter-node-name to block-stream Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 14/15] iotests: prepare 245 for using filter in block-stream Andrey Shinkevich
2020-05-13 9:50 ` [PATCH v5 15/15] block: apply COR-filter to block-stream jobs Andrey Shinkevich
2020-06-01 13:57 ` Andrey Shinkevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR08MB407077857517F552E121D413F48A0@AM6PR08MB4070.eurprd08.prod.outlook.com \
--to=andrey.shinkevich@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@virtuozzo.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).