From: Sai Pavan Boddu <saipava@xilinx.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Ying Fang" <fangying1@huawei.com>,
"'Marc-André Lureau'" <marcandre.lureau@redhat.com>,
"'Philippe Mathieu-Daudé'" <philmd@redhat.com>
Subject: RE: [PATCH v2 3/3] usb/hcd-xhci: Split pci wrapper for xhci base model
Date: Thu, 25 Jun 2020 18:08:38 +0000 [thread overview]
Message-ID: <BY5PR02MB67723A0D247E4D2BC60A0710CA920@BY5PR02MB6772.namprd02.prod.outlook.com> (raw)
In-Reply-To: <87y2obzhsc.fsf@dusky.pond.sub.org>
Hi Markus,
> -----Original Message-----
> From: Markus Armbruster <armbru@redhat.com>
> Sent: Thursday, June 25, 2020 1:42 PM
> To: Sai Pavan Boddu <saipava@xilinx.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>; Peter Maydell
> <peter.maydell@linaro.org>; Thomas Huth <thuth@redhat.com>; Eduardo
> Habkost <ehabkost@redhat.com>; qemu-devel@nongnu.org; Alistair Francis
> <alistair.francis@wdc.com>; 'Marc-André Lureau'
> <marcandre.lureau@redhat.com>; Ying Fang <fangying1@huawei.com>;
> Paolo Bonzini <pbonzini@redhat.com>; 'Philippe Mathieu-Daudé'
> <philmd@redhat.com>
> Subject: Re: [PATCH v2 3/3] usb/hcd-xhci: Split pci wrapper for xhci base
> model
>
> Sai Pavan Boddu <sai.pavan.boddu@xilinx.com> writes:
>
> > This patch sets the base to use xhci as sysbus model, for which pci
> > specific hooks are moved to hcd-xhci-pci.c. As a part of this
> > requirment msi/msix interrupts handling is moved under XHCIPCIState,
> > and XHCIState is non qom object, make use of 'container_of' calls to
> > retrive XHCIPciState. Made required changes for qemu-xhci-nec.
> >
> > Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
>
> I can't see a "sysbus model". What I can see is
>
> TYPE_DEVICE
> |
> TYPE_PCI_DEVICE
> |
> TYPE_XHCI_PCI (renamed from TYPE_XHCI)
> / \
> TYPE_QEMU_XHCI TYPE_NEC_XHCI
>
> All but the two leaves are abstract.
>
> Do you intend to add a "sysbus model" in a future patch?
[Sai Pavan Boddu] Yes. I would be sending it along with that a device which would be using it. (i.e for zynqmp soc )
Let me know, if its good to include hcd-xhci-sysbus.c here ?
Regards,
Sai Pavan
next prev parent reply other threads:[~2020-06-25 18:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 14:16 [PATCH v2 0/3] Make hcd-xhci independent of pci hooks Sai Pavan Boddu
2020-06-24 14:16 ` [PATCH v2 1/3] usb/hcd-xhci: Make dma read/writes hooks pci free Sai Pavan Boddu
2020-06-24 16:13 ` Philippe Mathieu-Daudé
2020-06-24 14:16 ` [PATCH v2 2/3] usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c Sai Pavan Boddu
2020-06-25 8:06 ` Markus Armbruster
2020-06-25 8:17 ` Philippe Mathieu-Daudé
2020-07-20 8:00 ` Sai Pavan Boddu
2020-07-20 8:07 ` Thomas Huth
2020-07-22 7:49 ` Sai Pavan Boddu
2020-07-22 8:38 ` Thomas Huth
2020-07-22 9:17 ` Markus Armbruster
2020-06-24 14:16 ` [PATCH v2 3/3] usb/hcd-xhci: Split pci wrapper for xhci base model Sai Pavan Boddu
2020-06-25 8:11 ` Markus Armbruster
2020-06-25 18:08 ` Sai Pavan Boddu [this message]
2020-06-26 6:12 ` Markus Armbruster
2020-06-26 10:19 ` Sai Pavan Boddu
2020-06-27 6:53 ` Markus Armbruster
2020-06-29 19:38 ` Gerd Hoffmann
2020-06-30 17:55 ` Sai Pavan Boddu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR02MB67723A0D247E4D2BC60A0710CA920@BY5PR02MB6772.namprd02.prod.outlook.com \
--to=saipava@xilinx.com \
--cc=alistair.francis@wdc.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fangying1@huawei.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).