From: Sai Pavan Boddu <saipava@xilinx.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Francisco Eduardo Iglesias" <figlesia@xilinx.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Vikram Garhwal" <fnuv@xilinx.com>,
"Markus Armbruster" <armbru@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Edgar Iglesias" <edgari@xilinx.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Ying Fang" <fangying1@huawei.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paul Zimmerman" <pauldzim@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: RE: [PATCH v12 1/3] misc: Add versal-usb2-ctrl-regs module
Date: Wed, 28 Oct 2020 13:50:16 +0000 [thread overview]
Message-ID: <BY5PR02MB67725BCB101936D51A8F1ED8CA170@BY5PR02MB6772.namprd02.prod.outlook.com> (raw)
In-Reply-To: <CAFEAcA_HX6gYE8yt6Qi2x1NKCWZ+GySgUW65r-cLobzN=z4rCQ@mail.gmail.com>
Hi Peter,
> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Wednesday, October 28, 2020 6:44 PM
> To: Sai Pavan Boddu <saipava@xilinx.com>
> Cc: Markus Armbruster <armbru@redhat.com>; Marc-André Lureau
> <marcandre.lureau@redhat.com>; Paolo Bonzini <pbonzini@redhat.com>;
> Gerd Hoffmann <kraxel@redhat.com>; Edgar Iglesias <edgari@xilinx.com>;
> Francisco Eduardo Iglesias <figlesia@xilinx.com>; QEMU Developers <qemu-
> devel@nongnu.org>; Alistair Francis <alistair.francis@wdc.com>; Eduardo
> Habkost <ehabkost@redhat.com>; Ying Fang <fangying1@huawei.com>;
> Philippe Mathieu-Daudé <philmd@redhat.com>; Vikram Garhwal
> <fnuv@xilinx.com>; Paul Zimmerman <pauldzim@gmail.com>
> Subject: Re: [PATCH v12 1/3] misc: Add versal-usb2-ctrl-regs module
>
> On Wed, 28 Oct 2020 at 12:58, Sai Pavan Boddu <saipava@xilinx.com> wrote:
> >
> > Hi Peter,
> >
> > > -----Original Message-----
> > > From: Sai Pavan Boddu
> > > Sent: Monday, October 26, 2020 10:59 PM
> > > To: Peter Maydell <peter.maydell@linaro.org>
> > > Cc: Markus Armbruster <armbru@redhat.com>; Marc-André Lureau
> > > <marcandre.lureau@redhat.com>; Paolo Bonzini <pbonzini@redhat.com>;
> > > Gerd Hoffmann <kraxel@redhat.com>; Edgar Iglesias
> > > <edgari@xilinx.com>; Francisco Eduardo Iglesias
> > > <figlesia@xilinx.com>; QEMU Developers <qemu- devel@nongnu.org>;
> > > Alistair Francis <alistair.francis@wdc.com>; Eduardo Habkost
> > > <ehabkost@redhat.com>; Ying Fang <fangying1@huawei.com>; Philippe
> > > Mathieu-Daudé <philmd@redhat.com>; Vikram Garhwal
> <fnuv@xilinx.com>;
> > > Paul Zimmerman <pauldzim@gmail.com>
> > > Subject: RE: [PATCH v12 1/3] misc: Add versal-usb2-ctrl-regs module
> > >
> > > Hi Peter,
> > >
> > > > -----Original Message-----
> > > > From: Peter Maydell <peter.maydell@linaro.org>
> > > > Sent: Monday, October 26, 2020 9:33 PM
> > > > To: Sai Pavan Boddu <saipava@xilinx.com>
> > > > Cc: Markus Armbruster <armbru@redhat.com>; Marc-André Lureau
> > > > <marcandre.lureau@redhat.com>; Paolo Bonzini
> > > > <pbonzini@redhat.com>; Gerd Hoffmann <kraxel@redhat.com>; Edgar
> > > > Iglesias <edgari@xilinx.com>; Francisco Eduardo Iglesias
> > > > <figlesia@xilinx.com>; QEMU Developers
> > > > <qemu- devel@nongnu.org>; Alistair Francis
> > > > <alistair.francis@wdc.com>; Eduardo Habkost <ehabkost@redhat.com>;
> > > > Ying Fang <fangying1@huawei.com>; Philippe Mathieu-Daudé
> > > > <philmd@redhat.com>; Vikram Garhwal <fnuv@xilinx.com>; Paul
> > > > Zimmerman
> > > <pauldzim@gmail.com>;
> > > > Sai Pavan Boddu <saipava@xilinx.com>
> > > > Subject: Re: [PATCH v12 1/3] misc: Add versal-usb2-ctrl-regs
> > > > module
> > > >
> > > > On Thu, 22 Oct 2020 at 13:11, Sai Pavan Boddu
> > > > <sai.pavan.boddu@xilinx.com>
> > > > wrote:
> > > > >
> > > > > This module emulates control registers of versal usb2
> > > > > controller, this is added just to make guest happy. In general
> > > > > this module would control the phy-reset signal from usb
> > > > > controller, data coherency of the transactions, signals the host system
> errors received from controller.
> > > > >
> > > > > Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
> > > > > Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> > > > > ---
> > > > > hw/misc/meson.build | 1 +
> > > > > hw/misc/xlnx-versal-usb2-ctrl-regs.c | 229
> > > > +++++++++++++++++++++++++++
> > > > > include/hw/misc/xlnx-versal-usb2-ctrl-regs.h | 45 ++++++
> > > >
> > > > This seems a bit odd. If it's a USB device (or part of a USB
> > > > device) then it should be under hw/usb, shouldn't it?
> > > [Sai Pavan Boddu] This is a top level wrapper over hcd-dwc3 device,
> > > which is specific to versal soc. It's mostly dummy which controls
> > > the phy-reset and does frame length adjustments. It was added just
> > > to make guest happy, that is the reason it has been added to misc devices.
> > > >
> > > > > +static void ir_status_postw(RegisterInfo *reg, uint64_t val64) {
> > > > > + VersalUsb2CtrlRegs *s = XILINX_VERSAL_USB2_CTRL_REGS(reg-
> > > >opaque);
> > > > > + /*
> > > > > + * TODO: This should also clear USBSTS.HSE field in USB XHCI
> register.
> > > > > + * May be combine both the modules.
> > > > > + */
> > > >
> > > > What does the hardware for this look like? You've modelled it as
> > > > two completely separate devices (this one and the
> > > > TYPE_USB_DWC3) but would it be closer to the hardware structure to
> > > > have a top-level device which has-a DWC3 ?
> > > [Sai Pavan Boddu] Yes, we can look at it such way. But as its
> > > specific to versal SOC, we have crafted it out and stitched them in SOC file.
> > >
> > > Regards,
> > > Sai Pavan
> > [Sai Pavan Boddu] I would be sending V13 without doing any changes with
> this patch and addressing other comments, Please review over V13.
>
> You have my review comments above. I think the way you've structured this
> isn't really the best way to do it.
[Sai Pavan Boddu] Ok, I would move this into USB folder as its related.
But this device is not like a top level module of DWC3 model, is used for handling phy-reset signal & power management of usb port.
It's not a good idea to embedded this device into DWC3 module.
Anyway, I would attempt to create a subsystem by making dwc3 and usb2-ctrl-regs child of one device.
Regards,
Sai Pavan
>
> thanks
> -- PMM
next prev parent reply other threads:[~2020-10-28 13:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 12:17 [PATCH v12 0/3] Add Versal usb model Sai Pavan Boddu
2020-10-22 12:17 ` [PATCH v12 1/3] misc: Add versal-usb2-ctrl-regs module Sai Pavan Boddu
2020-10-26 16:02 ` Peter Maydell
2020-10-26 17:28 ` Sai Pavan Boddu
2020-10-28 12:58 ` Sai Pavan Boddu
2020-10-28 13:14 ` Peter Maydell
2020-10-28 13:50 ` Sai Pavan Boddu [this message]
2020-10-22 12:17 ` [PATCH v12 2/3] usb: Add DWC3 model Sai Pavan Boddu
2020-10-22 12:17 ` [PATCH v12 3/3] Versal: Connect DWC3 controller with virt-versal Sai Pavan Boddu
2020-10-26 16:05 ` Peter Maydell
2020-10-26 19:28 ` Sai Pavan Boddu
2020-10-23 9:27 ` [PATCH v12 0/3] Add Versal usb model Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR02MB67725BCB101936D51A8F1ED8CA170@BY5PR02MB6772.namprd02.prod.outlook.com \
--to=saipava@xilinx.com \
--cc=alistair.francis@wdc.com \
--cc=armbru@redhat.com \
--cc=edgari@xilinx.com \
--cc=ehabkost@redhat.com \
--cc=fangying1@huawei.com \
--cc=figlesia@xilinx.com \
--cc=fnuv@xilinx.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pauldzim@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).