qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* Ping: [PATCH] Set icon for QEMU binary on Mac OS
@ 2021-04-07 15:01 Programmingkid
  0 siblings, 0 replies; 4+ messages in thread
From: Programmingkid @ 2021-04-07 15:01 UTC (permalink / raw)
  To: Peter Maydell; +Cc: QEMU devel list

I haven't heard anything about this patch for a while. 

From 45650a7f52deb8c2c436d71a3fcf5326287c2e05 Mon Sep 17 00:00:00 2001
From: John Arbuckle <programmingkidx@gmail.com>
Date: Tue, 2 Feb 2021 08:35:43 -0500
Subject: [PATCH] Set icon for QEMU binary on Mac OS

Before switching the build system over to Meson, an icon was
added to the QEMU binary on Mac OS. This patch adds back that
feature.

Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
---
 meson.build | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/meson.build b/meson.build
index f00b7754fd..7f534f4e75 100644
--- a/meson.build
+++ b/meson.build
@@ -2183,6 +2183,26 @@ foreach target : target_dirs
                link_args: link_args,
                gui_app: exe['gui'])
 
+# set QEMU's icon on Mac OS
+if targetos == 'darwin'
+    newiconpart1 = custom_target('Icon for ' + exe_name + ' - part 1',
+          depends : emulator,
+          input : emulator,
+          output : 'new icon for ' + exe_name + ' - 1',
+          command : ['Rez', '-append',
+           meson.source_root() + '/pc-bios/qemu.rsrc', '-o',
+           meson.current_build_dir() / exe['name']],
+          build_by_default : true)
+
+    custom_target('Icon for ' + exe_name + ' - part 2',
+          depends : newiconpart1,
+          input : emulator,
+          output : 'new icon for ' + exe_name + ' - 2',
+          command : ['SetFile', '-a', 'C',
+           meson.current_build_dir() / exe['name']],
+          build_by_default : true)
+endif
+
     if exe_sign
       emulators += {exe['name'] : custom_target(exe['name'],
                    install: true,
-- 
2.24.3 (Apple Git-128)




^ permalink raw reply	[flat|nested] 4+ messages in thread

* ping: [PATCH] Set icon for QEMU binary on Mac OS
@ 2021-05-29 14:36 Programmingkid
  0 siblings, 0 replies; 4+ messages in thread
From: Programmingkid @ 2021-05-29 14:36 UTC (permalink / raw)
  To: Peter Maydell, QEMU devel list; +Cc: Paolo Bonzini

Ping, 

please implement this patch. The default icon on Mac OS 11 is not very good looking.


https://lore.kernel.org/qemu-devel/20210202134410.9274-1-programmingkidx@gmail.com/

Before switching the build system over to Meson, an icon was
added to the QEMU binary on Mac OS. This patch adds back that
feature.

Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
---

meson.build
| 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)


diff
--git a/meson.build b/meson.build
index f00b7754fd..7f534f4e75 100644
--- a/meson.build
+++ b/meson.build

@@ -2183,6 +2183,26 @@ foreach target : target_dirs

               link_args: link_args,
               gui_app: exe['gui'])


+# set QEMU's icon on Mac OS
+if targetos == 'darwin'
+    newiconpart1 = custom_target('Icon for ' + exe_name + ' - part 1',
+          depends : emulator,
+          input : emulator,
+          output : 'new icon for ' + exe_name + ' - 1',
+          command : ['Rez', '-append',
+           meson.source_root() + '/pc-bios/qemu.rsrc', '-o',
+           meson.current_build_dir() / exe['name']],
+          build_by_default : true)
+
+    custom_target('Icon for ' + exe_name + ' - part 2',
+          depends : newiconpart1,
+          input : emulator,
+          output : 'new icon for ' + exe_name + ' - 2',
+          command : ['SetFile', '-a', 'C',
+           meson.current_build_dir() / exe['name']],
+          build_by_default : true)
+endif
+

    if exe_sign
      emulators += {exe['name'] : custom_target(exe['name'],
                   install: true,
-- 
2.24.3 (Apple Git-128)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Ping: [PATCH] Set icon for QEMU binary on Mac OS
  2021-04-23 21:08 Programmingkid
@ 2021-04-24  8:58 ` Peter Maydell
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2021-04-24  8:58 UTC (permalink / raw)
  To: Programmingkid; +Cc: Paolo Bonzini, QEMU devel list

On Fri, 23 Apr 2021 at 22:08, Programmingkid <programmingkidx@gmail.com> wrote:
>
> This patch was submitted in February and I haven't heard anything about it since. Could this be included in the up coming release please?

It's about two weeks late to get into 6.0, I'm afraid.

Cc'ing Paolo for review since it's a meson.build change.

-- PMM

> https://lore.kernel.org/qemu-devel/20210202134410.9274-1-programmingkidx@gmail.com/
>
> Before switching the build system over to Meson, an icon was
> added to the QEMU binary on Mac OS. This patch adds back that
> feature.
>
> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
> ---
>
> meson.build
>  | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
>
> diff
>  --git a/meson.build b/meson.build
> index f00b7754fd..7f534f4e75 100644
> --- a/meson.build
> +++ b/meson.build
>
> @@ -2183,6 +2183,26 @@ foreach target : target_dirs
>
>                 link_args: link_args,
>                 gui_app: exe['gui'])
>
>
> +# set QEMU's icon on Mac OS
> +if targetos == 'darwin'
> +    newiconpart1 = custom_target('Icon for ' + exe_name + ' - part 1',
> +          depends : emulator,
> +          input : emulator,
> +          output : 'new icon for ' + exe_name + ' - 1',
> +          command : ['Rez', '-append',
> +           meson.source_root() + '/pc-bios/qemu.rsrc', '-o',
> +           meson.current_build_dir() / exe['name']],
> +          build_by_default : true)
> +
> +    custom_target('Icon for ' + exe_name + ' - part 2',
> +          depends : newiconpart1,
> +          input : emulator,
> +          output : 'new icon for ' + exe_name + ' - 2',
> +          command : ['SetFile', '-a', 'C',
> +           meson.current_build_dir() / exe['name']],
> +          build_by_default : true)
> +endif
> +
>
>      if exe_sign
>        emulators += {exe['name'] : custom_target(exe['name'],
>                     install: true,
> --
> 2.24.3 (Apple Git-128)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Ping: [PATCH] Set icon for QEMU binary on Mac OS
@ 2021-04-23 21:08 Programmingkid
  2021-04-24  8:58 ` Peter Maydell
  0 siblings, 1 reply; 4+ messages in thread
From: Programmingkid @ 2021-04-23 21:08 UTC (permalink / raw)
  To: Peter Maydell; +Cc: QEMU devel list

This patch was submitted in February and I haven't heard anything about it since. Could this be included in the up coming release please?


https://lore.kernel.org/qemu-devel/20210202134410.9274-1-programmingkidx@gmail.com/

Before switching the build system over to Meson, an icon was
added to the QEMU binary on Mac OS. This patch adds back that
feature.

Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
---
 
meson.build
 | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)


diff
 --git a/meson.build b/meson.build
index f00b7754fd..7f534f4e75 100644
--- a/meson.build
+++ b/meson.build

@@ -2183,6 +2183,26 @@ foreach target : target_dirs

                link_args: link_args,
                gui_app: exe['gui'])
 

+# set QEMU's icon on Mac OS
+if targetos == 'darwin'
+    newiconpart1 = custom_target('Icon for ' + exe_name + ' - part 1',
+          depends : emulator,
+          input : emulator,
+          output : 'new icon for ' + exe_name + ' - 1',
+          command : ['Rez', '-append',
+           meson.source_root() + '/pc-bios/qemu.rsrc', '-o',
+           meson.current_build_dir() / exe['name']],
+          build_by_default : true)
+
+    custom_target('Icon for ' + exe_name + ' - part 2',
+          depends : newiconpart1,
+          input : emulator,
+          output : 'new icon for ' + exe_name + ' - 2',
+          command : ['SetFile', '-a', 'C',
+           meson.current_build_dir() / exe['name']],
+          build_by_default : true)
+endif
+

     if exe_sign
       emulators += {exe['name'] : custom_target(exe['name'],
                    install: true,
-- 
2.24.3 (Apple Git-128)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-05-29 14:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 15:01 Ping: [PATCH] Set icon for QEMU binary on Mac OS Programmingkid
2021-04-23 21:08 Programmingkid
2021-04-24  8:58 ` Peter Maydell
2021-05-29 14:36 ping: " Programmingkid

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).