qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Obinata Hiroyuki <hiroyuki.obinata@gmail.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
	Alistair Francis <Alistair.Francis@wdc.com>,
	"open list:RISC-V TCG CPUs" <qemu-riscv@nongnu.org>,
	qemu-devel@nongnu.org,
	Sagar Karandikar <sagark@eecs.berkeley.edu>
Subject: Re: [PATCH] remove unnecessary ifdef TARGET_RISCV64
Date: Sat, 2 Nov 2019 10:16:45 +0900	[thread overview]
Message-ID: <CA+0n8CN3YC56nMpZqCQD_kCzFaZN+uign5NGj=SgAW5E+tKQLA@mail.gmail.com> (raw)
In-Reply-To: <mhng-7b7098a1-1195-4532-80ab-2d7c51ebd2ed@palmer-si-x1c4>

[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]

Thanks!

2019年11月2日(土) 1:58 Palmer Dabbelt <palmer@dabbelt.com>:

> On Tue, 29 Oct 2019 17:23:18 PDT (-0700), hiroyuki.obinata@gmail.com
> wrote:
> > From: "hiroyuki.obinata" <hiroyuki.obinata@gmail.com>
> >
> > Signed-off-by: Hiroyuki Obinata <hiroyuki.obinata@gmail.com>
> > ---
> >  target/riscv/translate.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/target/riscv/translate.c b/target/riscv/translate.c
> > index adeddb85f6..5c4dd21a98 100644
> > --- a/target/riscv/translate.c
> > +++ b/target/riscv/translate.c
> > @@ -64,12 +64,10 @@ static const int tcg_memop_lookup[8] = {
> >      [0] = MO_SB,
> >      [1] = MO_TESW,
> >      [2] = MO_TESL,
> > +    [3] = MO_TEQ,
> >      [4] = MO_UB,
> >      [5] = MO_TEUW,
> > -#ifdef TARGET_RISCV64
> > -    [3] = MO_TEQ,
> >      [6] = MO_TEUL,
> > -#endif
> >  };
> >  #endif
>
> Reviewed-by: Palmer Dabbelt <palmer@dabbelt.com>
>
> This is a non-functional change (the code in question was already wrapped
> in an
> "#ifdef TARGET_RISCV64", so this internal one was redundant), so I'm happy
> to
> include it during the soft freeze.
>
> I've added this to the queue for my next PR.
>

[-- Attachment #2: Type: text/html, Size: 1948 bytes --]

      reply	other threads:[~2019-11-02  1:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30  0:23 [PATCH] remove unnecessary ifdef TARGET_RISCV64 hiroyuki.obinata
2019-11-01 16:58 ` Palmer Dabbelt
2019-11-02  1:16   ` Obinata Hiroyuki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+0n8CN3YC56nMpZqCQD_kCzFaZN+uign5NGj=SgAW5E+tKQLA@mail.gmail.com' \
    --to=hiroyuki.obinata@gmail.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=palmer@dabbelt.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=sagark@eecs.berkeley.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).