From: Joelle van Dyne <j@getutm.app>
To: Thomas Huth <thuth@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 9/9] block: check availablity for preadv/pwritev on mac
Date: Mon, 19 Oct 2020 15:20:40 -0700 [thread overview]
Message-ID: <CA+E+eSAO0-0FFTBuM7c54cXOQMJkUhcPZ=kf-=RtSvwKdjmViA@mail.gmail.com> (raw)
In-Reply-To: <54ea1dc9-f4e5-7827-6d05-c574b8c411d1@redhat.com>
On Mon, Oct 19, 2020 at 1:27 AM Thomas Huth <thuth@redhat.com> wrote:
>
> On 19/10/2020 03.39, Joelle van Dyne wrote:
> > From: osy <osy86@users.noreply.github.com>
>
> That "From:" line looks wrong ... could you please fix the "Author" of your
> patches / your git config?
osy wrote the original changes. I joined the UTM project to help bring
the changes upstream with permission. However, they have agreed that
if required that we can use my name as the author.
>
> > macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure
> > will succeed with CONFIG_PREADV even when targeting a lower OS version. We
> > therefore need to check at run time if we can actually use these APIs.
>
> That sounds like the wrong approach to me ... could you please try to fix
> the check in "configure" instead? E.g. by running compile_prog with
> "-Werror", so that the test fails if there is no valid prototype available?
It's not that simple. Xcode 11 and below (supporting macOS 10.15 and
below, iOS 13 and below, etc) does not have preadv/pwritev symbols
defined and would fail to compile. Xcode 12 (supporting macOS 11 and
below, iOS 14 and below, etc) have preadv/pwritev weakly defined so if
it runs on, for example, 10.15, it would abort. There is no way to
determine at compile time if you can use preadv/pwritev or not when
building with Xcode 12. The availability checks are Apple's preferred
way to handle this kind of situation (they discourage directly
checking if an API exists on a system).
-j
>
> Thomas
>
next prev parent reply other threads:[~2020-10-19 22:22 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 1:39 [PATCH v2 0/9] iOS and Apple Silicon host support Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 1/9] configure: option to disable host block devices Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 2/9] configure: cross-compiling without cross_prefix Joelle van Dyne
2020-10-19 8:07 ` Thomas Huth
2020-10-19 8:09 ` Thomas Huth
2020-10-19 11:24 ` BALATON Zoltan via
2020-10-19 22:24 ` Joelle van Dyne
2020-10-20 5:15 ` Thomas Huth
2020-10-20 8:34 ` Paolo Bonzini
2020-10-25 19:24 ` Joelle van Dyne
2020-10-26 7:54 ` Paolo Bonzini
2020-10-26 15:33 ` Joelle van Dyne
2020-10-26 16:15 ` Paolo Bonzini
2020-10-26 18:51 ` Thomas Huth
2020-10-19 1:39 ` [PATCH v2 3/9] qemu: add support for iOS host Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 4/9] coroutine: add libucontext as external library Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 5/9] tcg: add const hints for code pointers Joelle van Dyne
2020-10-19 23:19 ` Richard Henderson
2020-10-19 23:26 ` Joelle van Dyne
2020-10-19 23:27 ` Richard Henderson
2020-10-19 23:36 ` Joelle van Dyne
2020-10-19 23:41 ` Richard Henderson
2020-10-19 1:39 ` [PATCH v2 6/9] tcg: implement mirror mapped JIT for iOS Joelle van Dyne
2020-10-19 11:48 ` BALATON Zoltan via
2020-10-19 22:39 ` Joelle van Dyne
2020-10-19 23:45 ` BALATON Zoltan via
2020-10-20 0:19 ` Richard Henderson
2020-10-25 19:46 ` Joelle van Dyne
2020-10-25 20:51 ` Joelle van Dyne
2020-10-25 23:43 ` Alexander Bulekov
2020-10-19 1:39 ` [PATCH v2 7/9] tcg: mirror mapping RWX pages for iOS optional Joelle van Dyne
2020-10-20 1:27 ` Richard Henderson
2020-10-19 1:39 ` [PATCH v2 8/9] tcg: support JIT on Apple Silicon Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 9/9] block: check availablity for preadv/pwritev on mac Joelle van Dyne
2020-10-19 8:27 ` Thomas Huth
2020-10-19 22:20 ` Joelle van Dyne [this message]
2020-10-20 5:19 ` Thomas Huth
2020-10-19 8:29 ` [PATCH v2 0/9] iOS and Apple Silicon host support Thomas Huth
2020-10-26 15:30 ` Joelle van Dyne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+E+eSAO0-0FFTBuM7c54cXOQMJkUhcPZ=kf-=RtSvwKdjmViA@mail.gmail.com' \
--to=j@getutm.app \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).