qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cleber Rosa Junior <crosa@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Fam Zheng" <fam@euphon.net>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Erik Skultety" <eskultet@redhat.com>,
	"Stefan Hajnoczi" <stefanha@gmail.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Andrea Bolognani" <abologna@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Willian Rampazzo" <wrampazz@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook
Date: Wed, 9 Jun 2021 10:21:09 -0400	[thread overview]
Message-ID: <CA+bd_6JO2URtPSAe4faWx_0ybWAXVki45ho7vh1oHo2jyi59zw@mail.gmail.com> (raw)
In-Reply-To: <87wnr3i2hy.fsf@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 5716 bytes --]

On Wed, Jun 9, 2021 at 9:36 AM Alex Bennée <alex.bennee@linaro.org> wrote:

>
> Cleber Rosa <crosa@redhat.com> writes:
>
> > To run basic jobs on custom runners, the environment needs to be
> > properly set up.  The most common requirement is having the right
> > packages installed.
> >
> > The playbook introduced here covers the QEMU's project s390x and
> > aarch64 machines.  At the time this is being proposed, those machines
> > have already had this playbook applied to them.
> >
> > Signed-off-by: Cleber Rosa <crosa@redhat.com>
> > ---
> >  docs/devel/ci.rst                      | 30 ++++++++
> >  scripts/ci/setup/build-environment.yml | 98 ++++++++++++++++++++++++++
> >  scripts/ci/setup/inventory.template    |  1 +
> >  3 files changed, 129 insertions(+)
> >  create mode 100644 scripts/ci/setup/build-environment.yml
> >  create mode 100644 scripts/ci/setup/inventory.template
> >
> > diff --git a/docs/devel/ci.rst b/docs/devel/ci.rst
> > index 585b7bf4b8..35c6b5e269 100644
> > --- a/docs/devel/ci.rst
> > +++ b/docs/devel/ci.rst
> > @@ -26,3 +26,33 @@ gitlab-runner, is called a "custom runner".
> >  The GitLab CI jobs definition for the custom runners are located under::
> >
> >    .gitlab-ci.d/custom-runners.yml
> > +
> > +Machine Setup Howto
> > +-------------------
> > +
> > +For all Linux based systems, the setup can be mostly automated by the
> > +execution of two Ansible playbooks.  Create an ``inventory`` file
> > +under ``scripts/ci/setup``, such as this::
> > +
> > +  fully.qualified.domain
> > +  other.machine.hostname
> > +
> > +You may need to set some variables in the inventory file itself.  One
> > +very common need is to tell Ansible to use a Python 3 interpreter on
> > +those hosts.  This would look like::
> > +
> > +  fully.qualified.domain ansible_python_interpreter=/usr/bin/python3
> > +  other.machine.hostname ansible_python_interpreter=/usr/bin/python3
> > +
> > +Build environment
> > +~~~~~~~~~~~~~~~~~
> > +
> > +The ``scripts/ci/setup/build-environment.yml`` Ansible playbook will
> > +set up machines with the environment needed to perform builds and run
> > +QEMU tests.  It covers a number of different Linux distributions and
> > +FreeBSD.
> > +
> > +To run the playbook, execute::
> > +
> > +  cd scripts/ci/setup
> > +  ansible-playbook -i inventory build-environment.yml
>
> I tried this to re-update aarch64.ci.qemu.org and another ubuntu box I
> have up and running as a VM and I got a failure when checking facts:
>
>   14:26:26 [alex@zen:~/l/q/s/c/setup] review/custom-runners-v6|✚1…(+1/-1)
> + ansible-playbook -i inventory build-environment.yml
>
>   PLAY [Installation of basic packages to build QEMU]
> *************************************************************************************************************************
>
>   TASK [Gathering Facts]
> ******************************************************************************************************************************************************
>   ok: [aarch64.ci.qemu.org]
>   ok: [hackbox-ubuntu-2004]
>
>   TASK [Update apt cache]
> *****************************************************************************************************************************************************
>   fatal: [aarch64.ci.qemu.org]: FAILED! => {"msg": "The conditional check
> 'ansible_facts['distribution'] == 'Ubuntu'' failed. The error was: error
> while evaluating conditional (ansible_facts['distribution'] == 'Ubuntu'):
> 'dict object' has no attribute 'distribution'\n\nThe error appears to have
> been in '/home/alex/lsrc/qemu.git/scripts/ci/setup/build-environment.yml':
> line 5, column 7, but may\nbe elsewhere in the file depending on the exact
> syntax problem.\n\nThe offending line appears to be:\n\n  tasks:\n    -
> name: Update apt cache\n      ^ here\n"}
>   fatal: [hackbox-ubuntu-2004]: FAILED! => {"msg": "The conditional check
> 'ansible_facts['distribution'] == 'Ubuntu'' failed. The error was: error
> while evaluating conditional (ansible_facts['distribution'] == 'Ubuntu'):
> 'dict object' has no attribute 'distribution'\n\nThe error appears to have
> been in '/home/alex/lsrc/qemu.git/scripts/ci/setup/build-environment.yml':
> line 5, column 7, but may\nbe elsewhere in the file depending on the exact
> syntax problem.\n\nThe offending line appears to be:\n\n  tasks:\n    -
> name: Update apt cache\n      ^ here\n"}
>           to retry, use: --limit
> @/home/alex/lsrc/qemu.git/scripts/ci/setup/build-environment.retry
>
>   PLAY RECAP
> ******************************************************************************************************************************************************************
>   aarch64.ci.qemu.org        : ok=1    changed=0    unreachable=0
> failed=1
>   hackbox-ubuntu-2004        : ok=1    changed=0    unreachable=0
> failed=1
>
>
>
Hi Alex,

Thanks for checking this version out.  It looks like this is similar to
what happened to you during v5 and hackmox-ubuntu-2004.  Because I had no
issues running the playbook against aarch64.ci.qemu.org, I am now betting
that this is an issue with the ansible installation on the "controller"
machine, that is, the one that drives the playbook execution (the "zen"
host, according to your output).

About the error, the syntax itself is correct[1], but I bet there may be
differences between ansible versions.  Could you please share the output of
"ansible --version" on that machine?

Thanks again,
- Cleber.

[1] -
https://docs.ansible.com/ansible/latest/user_guide/playbooks_conditionals.html#ansible-facts-distribution


> --
> Alex Bennée
>
>

[-- Attachment #2: Type: text/html, Size: 7440 bytes --]

  reply	other threads:[~2021-06-09 14:22 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08  3:14 [PATCH v6 0/4] GitLab Custom Runners and Jobs (was: QEMU Gating CI) Cleber Rosa
2021-06-08  3:14 ` [PATCH v6 1/4] Jobs based on custom runners: documentation and configuration placeholder Cleber Rosa
2021-06-08 18:29   ` Wainer dos Santos Moschetta
2021-06-09 13:24   ` Alex Bennée
2021-06-09 14:22   ` Thomas Huth
2021-06-09 14:24   ` Willian Rampazzo
2021-06-08  3:14 ` [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook Cleber Rosa
2021-06-08 18:48   ` Wainer dos Santos Moschetta
2021-06-09 16:13     ` Willian Rampazzo
2021-06-29 15:23       ` Cleber Rosa
2021-06-29 15:06     ` Cleber Rosa
2021-06-09 13:31   ` Alex Bennée
2021-06-09 14:21     ` Cleber Rosa Junior [this message]
2021-06-09 15:26       ` Alex Bennée
2021-06-09 17:09         ` Cleber Rosa Junior
2021-06-11 10:40           ` Alex Bennée
2021-06-28 23:07             ` Cleber Rosa
2021-06-09 17:16   ` Willian Rampazzo
2021-06-10  8:13     ` Erik Skultety
2021-06-29 23:35       ` Cleber Rosa
2021-06-29 23:30     ` Cleber Rosa
2021-06-08  3:14 ` [PATCH v6 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook Cleber Rosa
2021-06-08 19:04   ` Wainer dos Santos Moschetta
2021-06-29 23:51     ` Cleber Rosa
2021-06-09 17:46   ` Willian Rampazzo
2021-06-30  0:04     ` Cleber Rosa
2021-06-10  6:23   ` Thomas Huth
2021-06-30  0:18     ` Cleber Rosa
2021-06-08  3:14 ` [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines Cleber Rosa
2021-06-08  6:29   ` Philippe Mathieu-Daudé
2021-06-08 13:36     ` Cleber Rosa Junior
2021-06-08 19:07       ` Wainer dos Santos Moschetta
2021-06-09 15:09         ` Stefan Hajnoczi
2021-06-30  0:47           ` Cleber Rosa
2021-06-09 14:54       ` Stefan Hajnoczi
2021-06-30  0:40         ` Cleber Rosa
2021-06-11 11:00       ` Alex Bennée
2021-06-30  1:08         ` Cleber Rosa
2021-06-30 14:24           ` Willian Rampazzo
2021-06-09 14:22     ` Stefan Hajnoczi
2021-06-08 18:27   ` Wainer dos Santos Moschetta
2021-06-09 15:53     ` Alex Bennée
2021-06-30  0:30     ` Cleber Rosa
2021-06-09 18:56   ` Willian Rampazzo
2021-06-10  6:18   ` Thomas Huth
2021-06-30  1:02     ` Cleber Rosa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+bd_6JO2URtPSAe4faWx_0ybWAXVki45ho7vh1oHo2jyi59zw@mail.gmail.com \
    --to=crosa@redhat.com \
    --cc=abologna@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=eskultet@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    --cc=wrampazz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).