From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Cc: "peter.maydell@linaro.org" <peter.maydell@linaro.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Stefan Sandström" <Stefan.Sandstrom@axis.com>
Subject: Re: [PULL v1 3/3] target/cris: Plug leakage of TCG temporaries
Date: Mon, 22 Feb 2021 11:23:57 +0100 [thread overview]
Message-ID: <CAAdtpL4WJUW4k8ML-n6q8-O7my=25H=8uCRrJv4zs3kkM=PdNA@mail.gmail.com> (raw)
In-Reply-To: <20210222101912.GC22843@toto>
[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]
Le lun. 22 févr. 2021 11:19, Edgar E. Iglesias <edgar.iglesias@xilinx.com>
a écrit :
> On Mon, Feb 22, 2021 at 08:50:46AM +0000, Stefan Sandström wrote:
> > Hi,
> >
> > > On 22 Feb 2021, at 09:41, Philippe Mathieu-Daudé <f4bug@amsat.org>
> wrote:
> > >
> > > Hi Edgar,
> > >
> > > On 2/22/21 9:33 AM, Edgar E. Iglesias wrote:
> > >> From: Stefan Sandstrom <stefans@axis.com>
> > >>
> > >> Add and fix deallocation of temporary TCG registers in CRIS code
> > >> generation.
> > >>
> > >> Tested-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > >> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > >> Change-Id: I17fce5d95bdc4418337ba885d53ba97afb1bafcc
> > > Out of curiosity, what is this Change-Id?
> >
> > It is used by the Gerrit Code Review tool (
> https://gerrit-review.googlesource.com/Documentation/user-changeid.html).
> > When using Gerrit as a git-server, you install a git hook that always
> adds this, so it is an artifact from storing a clone of the QEMU repos on a
> gerrit server.
>
I see, thanks.
> I'll try to remember to remove it if I end up posting more patches.
> >
>
>
> Thanks,
>
> Peter, do you need an updated PR without the tag or can you handle it when
> merging?
>
I don't think this single line is important enough to justify another pull
request ;)
Best regards,
> Edgar
>
[-- Attachment #2: Type: text/html, Size: 2764 bytes --]
next prev parent reply other threads:[~2021-02-22 10:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 8:33 [PULL v1 0/3] CRIS queue Edgar E. Iglesias
2021-02-22 8:33 ` [PULL v1 1/3] target/cris: Use MMUAccessType enum type when possible Edgar E. Iglesias
2021-02-22 8:33 ` [PULL v1 2/3] target/cris: Let cris_mmu_translate() use MMUAccessType access_type Edgar E. Iglesias
2021-02-22 8:33 ` [PULL v1 3/3] target/cris: Plug leakage of TCG temporaries Edgar E. Iglesias
2021-02-22 8:41 ` Philippe Mathieu-Daudé
2021-02-22 8:50 ` Edgar E. Iglesias
2021-02-22 8:50 ` Stefan Sandström
2021-02-22 10:19 ` Edgar E. Iglesias
2021-02-22 10:23 ` Philippe Mathieu-Daudé [this message]
2021-02-22 17:25 ` [PULL v1 0/3] CRIS queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAdtpL4WJUW4k8ML-n6q8-O7my=25H=8uCRrJv4zs3kkM=PdNA@mail.gmail.com' \
--to=f4bug@amsat.org \
--cc=Stefan.Sandstrom@axis.com \
--cc=edgar.iglesias@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).