From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF7D1C64E7B for ; Mon, 30 Nov 2020 12:45:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F10B12074A for ; Mon, 30 Nov 2020 12:45:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F10B12074A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjiYh-0000Ey-Kb for qemu-devel@archiver.kernel.org; Mon, 30 Nov 2020 07:45:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjiMJ-00085Q-Tt for qemu-devel@nongnu.org; Mon, 30 Nov 2020 07:32:48 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:41357) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjiMI-0004PO-6G for qemu-devel@nongnu.org; Mon, 30 Nov 2020 07:32:47 -0500 Received: by mail-ot1-f66.google.com with SMTP id f48so2580017otf.8 for ; Mon, 30 Nov 2020 04:32:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=k20zwZ0ZqIEi1h73V6C2xT4zImJSwz/OVH7ZvS1IzKo=; b=A8hzS2Csl5Z1slft5/VYtvd4DZsnkzQYHqvd64G8L6cUG8lOPDGka6vBRRZ9UPO6e0 MpPoQ9TnQmEctBmIhTWP2H9M4iGFr4RHVV3TocykGDfxDEuAtIJpneVu964uFpmpleQk cD9DasfWm87SjWt49BMwzGO+GKvbplNP5MQNUALKaTxq9+cS09Uu5OVDHvQ5Eta36mqv Gem5DmfxzE2B/pQ/PDiY57eX/LAqWc2Pu5MyPPdI36Md21LPjlkfGjwHETDo8d1tvilr 90Tit6o9ujwEw6yGAIRggU52bnnTymnBRNwaf0GTqM+g/sLbR3NcTvU8susnIcip9GBr eZMA== X-Gm-Message-State: AOAM533hZ1UqgcOBvakLQe4SImihjL7ZvRKUyvzcl9IF3guzhr45XFDB g8p/Kx6BYGpc5LXdz+L33hZ2pnNkWJ/Ib8t1zCFe2+thaIw= X-Google-Smtp-Source: ABdhPJyFzcczfGpCn1b3qr7gQGm+FARpIGIe4QGK+WXQ1jet3oMkxyPVikQF7aefJOczkwsaAGkgOxSCJNccqRLKD3U= X-Received: by 2002:a05:6830:134b:: with SMTP id r11mr12025680otq.126.1606739564665; Mon, 30 Nov 2020 04:32:44 -0800 (PST) MIME-Version: 1.0 References: <20201130122639.2431070-1-f4bug@amsat.org> In-Reply-To: <20201130122639.2431070-1-f4bug@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Date: Mon, 30 Nov 2020 13:32:33 +0100 Message-ID: Subject: Re: [PATCH] decodetree: Allow use of hex/bin format for argument field values To: "qemu-devel@nongnu.org Developers" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=209.85.210.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ot1-f66.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Richard Henderson , Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Nov 30, 2020 at 1:26 PM Philippe Mathieu-Daud=C3=A9 wrote: > ISA datasheets often use binary or hexadecimal constant values. > By doing base conversion, we might introduce bugs. Safer is to > copy/paste the datasheet value. > Add support for bin/hex constants in argument field token. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > Is there a more pythonic way to write this if/elif/else > loop without re.fullmatch? BTW I discarded the simple "int(value, 0)" to have strict checks, but if this is enough it is certainly simpler. > --- > scripts/decodetree.py | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/scripts/decodetree.py b/scripts/decodetree.py > index 47aa9caf6d1..d2ecc61813f 100644 > --- a/scripts/decodetree.py > +++ b/scripts/decodetree.py > @@ -849,9 +849,15 @@ def parse_generic(lineno, parent_pat, name, toks): > continue > > # 'Foo=3Dnumber' sets an argument field to a constant value > - if re.fullmatch(re_C_ident + '=3D[+-]?[0-9]+', t): > + if re.fullmatch(re_C_ident + '=3D[+-]?(0[bx])?[0-9]+', t): > (fname, value) =3D t.split('=3D') > - value =3D int(value) > + if re.fullmatch('[+-]?0b[0-9]+', value): > + base =3D 2 > + elif re.fullmatch('[+-]?0x[0-9]+', value): > + base =3D 16 > + else: > + base =3D 10 > + value =3D int(value, base) > flds =3D add_field(lineno, flds, fname, ConstField(value)) > continue > > -- > 2.26.2 >