From: "Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: Laurent Vivier <laurent@vivier.eu>,
Richard Henderson <richard.henderson@linaro.org>,
Lucien Murray-Pitts <lucienmp.qemu@gmail.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/2] target/m68k: increase size of m68k CPU features from uint32_t to uint64_t
Date: Sun, 25 Sep 2022 16:43:24 +0200 [thread overview]
Message-ID: <CAAdtpL6ACE=YgZoMa5XSiKiwR4TXiRtJ9MMtpAwyehL3ev7sGw@mail.gmail.com> (raw)
In-Reply-To: <20220925134804.139706-2-mark.cave-ayland@ilande.co.uk>
On Sun, Sep 25, 2022 at 3:53 PM Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
>
> There are already 32 feature bits in use, so change the size of the m68k
> CPU features to uint64_t (along with the associated m68k_feature()
> functions) to allow up to 64 feature bits to be used.
>
> At the same time make use of the BIT_ULL() macro when reading/writing
> the CPU feature bits to improve readability, and also update m68k_feature()
> to return a bool rather than an int.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> target/m68k/cpu.c | 4 ++--
> target/m68k/cpu.h | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2022-09-25 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 13:48 [PATCH 0/2] target/m68k: MacOS supervisor/user mode switch fixes - part 2 Mark Cave-Ayland
2022-09-25 13:48 ` [PATCH 1/2] target/m68k: increase size of m68k CPU features from uint32_t to uint64_t Mark Cave-Ayland
2022-09-25 14:43 ` Philippe Mathieu-Daudé via [this message]
2022-09-26 21:35 ` Laurent Vivier
2022-09-25 13:48 ` [PATCH 2/2] target/m68k: use M68K_FEATURE_MOVEFROMSR_PRIV feature for move_from_sr privilege check Mark Cave-Ayland
2022-09-26 21:35 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAdtpL6ACE=YgZoMa5XSiKiwR4TXiRtJ9MMtpAwyehL3ev7sGw@mail.gmail.com' \
--to=qemu-devel@nongnu.org \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=lucienmp.qemu@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).