From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 023D4C2D0E5 for ; Wed, 25 Mar 2020 19:29:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6ACD20740 for ; Wed, 25 Mar 2020 19:29:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6ACD20740 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHBim-0007fz-08 for qemu-devel@archiver.kernel.org; Wed, 25 Mar 2020 15:29:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54004) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHBaK-0003Rr-BT for qemu-devel@nongnu.org; Wed, 25 Mar 2020 15:21:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHBaJ-00015o-7I for qemu-devel@nongnu.org; Wed, 25 Mar 2020 15:21:04 -0400 Received: from mail-yb1-f195.google.com ([209.85.219.195]:33763) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jHBaJ-00015G-3M; Wed, 25 Mar 2020 15:21:03 -0400 Received: by mail-yb1-f195.google.com with SMTP id p196so1851437ybc.0; Wed, 25 Mar 2020 12:21:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=T7mqDw2HPhBZ7XgToqhMzKZGp93hboGgHXk/bjxfHVU=; b=eqFcCiEyGEceAY7Ni2/THtgjmatmVtSr5OxGEmAMH93XToMezN8EEyOpbbm4d2b25s BlsbWh1QioWa0svn/bnnfTIIOgq1HUuYzgXIg5+hNT4OvICyLvYK+IigvWkTkyGH9EGT f2udFp6fvsjivPTdGeuNM/7VE+VzuSpD4a3nMWQ88nEuuuxg+r28t8BpKJLhAo84w12n w5EW6jeCJMWxrUNOSibgfGngb17DjJQ1XjgLzB1ka88sMhaF7aCcH/pLWLHm7bG0CJu7 MgFHOCiBZM7il5+BinXhiVSo7X2EXzbCOddGJlYlcKvz6MqBjmBS8YmbPym5MzBTViWf aBcg== X-Gm-Message-State: ANhLgQ17s1PER9pkddXYVNPsbmr22FQ9Eqg9BbwAkG1KWK3jA1z2HtG/ 6gh9Qg4ttQftQP1UEDKBhu4EcC8idrUIKPgE4jHPT1768+c= X-Google-Smtp-Source: ADFU+vvfrqMG8fqoX/dokfqqLXlix3EsPQSyGDtnBsA5mfZ881GiL16nL9rSiXq6eBauuYk7jPQI6HGtLexiZ30o30I= X-Received: by 2002:a25:6d54:: with SMTP id i81mr7843704ybc.323.1585164060908; Wed, 25 Mar 2020 12:21:00 -0700 (PDT) MIME-Version: 1.0 References: <20200325191830.16553-1-f4bug@amsat.org> In-Reply-To: <20200325191830.16553-1-f4bug@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Date: Wed, 25 Mar 2020 20:20:49 +0100 Message-ID: Subject: Re: [PATCH-for-5.0 00/12] hw: Add missing error-propagation code To: "qemu-devel@nongnu.org Developers" , Stefan Hajnoczi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.219.195 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Burton , Sagar Karandikar , "Michael S. Tsirkin" , Jason Wang , Mark Cave-Ayland , Alistair Francis , "Edgar E. Iglesias" , Peter Maydell , Markus Armbruster , Aleksandar Markovic , Palmer Dabbelt , Aleksandar Rikalo , Richard Henderson , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Eduardo Habkost , Alistair Francis , qemu-arm , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Andrew Baumann , Jean-Christophe Dubois , "qemu-ppc@nongnu.org list:PowerPC" , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Mar 25, 2020 at 8:18 PM Philippe Mathieu-Daud=C3=A9 wrote: > > This series is inspired of Peter fix: > "hw/arm/xlnx-zynqmp.c: fix some error-handling code" > https://www.mail-archive.com/qemu-devel@nongnu.org/msg691636.html > > Add a cocci script to fix the other places. > > Based-on: <20200324134947.15384-1-peter.maydell@linaro.org> > > Philippe Mathieu-Daud=3DC3=3DA9 (12): Hmm is that a git-publish bug? > scripts/coccinelle: Add script to catch missing error_propagate() > calls > hw/arm/bcm2835_peripherals: Add missing error-propagation code > hw/arm/fsl-imx: Add missing error-propagation code > hw/arm/stm32fx05_soc: Add missing error-propagation code > hw/i386/x86: Add missing error-propagation code > hw/dma/xilinx_axidma: Add missing error-propagation code > hw/mips/cps: Add missing error-propagation code > hw/mips/boston: Add missing error-propagation code > hw/mips/mips_malta: Add missing error-propagation code > hw/misc/macio/macio: Add missing error-propagation code > hw/net/xilinx_axienet: Add missing error-propagation code > hw/riscv/sifive_u: Add missing error-propagation code > > ...ect_property_missing_error_propagate.cocci | 58 +++++++++++++++++++ > hw/arm/bcm2835_peripherals.c | 8 +++ > hw/arm/fsl-imx25.c | 8 +++ > hw/arm/fsl-imx6.c | 8 +++ > hw/arm/stm32f205_soc.c | 4 ++ > hw/arm/stm32f405_soc.c | 4 ++ > hw/dma/xilinx_axidma.c | 3 + > hw/i386/x86.c | 4 ++ > hw/mips/boston.c | 17 ++---- > hw/mips/cps.c | 52 +++++++++++++++++ > hw/mips/mips_malta.c | 19 ++++-- > hw/misc/macio/macio.c | 4 ++ > hw/net/xilinx_axienet.c | 3 + > hw/riscv/sifive_u.c | 8 +++ > 14 files changed, 184 insertions(+), 16 deletions(-) > create mode 100644 scripts/coccinelle/object_property_missing_error_prop= agat=3D > e.cocci > > --=3D20 > 2.21.1 >