Il gio 27 mag 2021, 14:07 Stefan Hajnoczi <stefanha@redhat.com> ha scritto:

> On Tue, May 18, 2021 at 12:07:51PM +0200, Emanuele Giuseppe Esposito wrote:
> >      } else {
> >          /*
> >           * We enable copy-range, but keep small copy_size, until first
> >           * successful copy_range (look at block_copy_do_copy).
> >           */
>
> Is this comment still correct? It appears that this branch of the if
> statement does not always enable copy-range (the !use_copy_range case).
>

It is correct, but it applies only if use_copy_range is true (the patch
doesn't change this).

Paolo

> -        s->use_copy_range = use_copy_range;
> > -        s->copy_size = MAX(s->cluster_size, BLOCK_COPY_MAX_BUFFER);
> > +        s->method = use_copy_range ? COPY_RANGE_SMALL : COPY_READ_WRITE;
>