From: Cindy Lu <lulu@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
Michael Tsirkin <mst@redhat.com>,
mhabets@solarflare.com, qemu-devel@nongnu.org, hanand@xilinx.com,
rob.miller@broadcom.com, saugatm@xilinx.com,
Markus Armbruster <armbru@redhat.com>,
hch@infradead.org, Eugenio Perez Martin <eperezma@redhat.com>,
jgg@mellanox.com, shahafs@mellanox.com, kevin.tian@intel.com,
parav@mellanox.com, vmireyno@marvell.com, "Liang,
Cunming" <cunming.liang@intel.com>,
gdawar@xilinx.com, jiri@mellanox.com, xiao.w.wang@intel.com,
Stefan Hajnoczi <stefanha@redhat.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>,
Ariel Adam <aadam@redhat.com>,
rdunlap@infradead.org,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"Zhu, Lingshan" <lingshan.zhu@intel.com>
Subject: Re: [RFC v2 2/9] net: use the function qemu_get_peer
Date: Sat, 9 May 2020 14:49:52 +0800 [thread overview]
Message-ID: <CACLfguUbYCL8hYATfSoRZ4nO3vTjaDGw8tRH3GzerZpGyx1Znw@mail.gmail.com> (raw)
In-Reply-To: <ef489ec2-1af9-3987-8f36-2993104e48d7@redhat.com>
On Sat, May 9, 2020 at 10:20 AM Jason Wang <jasowang@redhat.com> wrote:
>
>
> On 2020/5/9 上午12:32, Cindy Lu wrote:
> > user the qemu_get_peer to replace the old process
>
>
> The title should be "vhost_net: use the function qemu_get_peer".
>
> Thanks
>
Sure, I will fix this
>
> >
> > Signed-off-by: Cindy Lu <lulu@redhat.com>
> > ---
> > hw/net/vhost_net.c | 14 +++++++++-----
> > 1 file changed, 9 insertions(+), 5 deletions(-)
> >
> > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> > index 6b82803fa7..d1d421e3d9 100644
> > --- a/hw/net/vhost_net.c
> > +++ b/hw/net/vhost_net.c
> > @@ -306,7 +306,9 @@ int vhost_net_start(VirtIODevice *dev, NetClientState *ncs,
> > BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(dev)));
> > VirtioBusState *vbus = VIRTIO_BUS(qbus);
> > VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(vbus);
> > + struct vhost_net *net;
> > int r, e, i;
> > + NetClientState *peer;
> >
> > if (!k->set_guest_notifiers) {
> > error_report("binding does not support guest notifiers");
> > @@ -314,9 +316,9 @@ int vhost_net_start(VirtIODevice *dev, NetClientState *ncs,
> > }
> >
> > for (i = 0; i < total_queues; i++) {
> > - struct vhost_net *net;
> >
> > - net = get_vhost_net(ncs[i].peer);
> > + peer = qemu_get_peer(ncs, i);
> > + net = get_vhost_net(peer);
> > vhost_net_set_vq_index(net, i * 2);
> >
> > /* Suppress the masking guest notifiers on vhost user
> > @@ -335,7 +337,8 @@ int vhost_net_start(VirtIODevice *dev, NetClientState *ncs,
> > }
> >
> > for (i = 0; i < total_queues; i++) {
> > - r = vhost_net_start_one(get_vhost_net(ncs[i].peer), dev);
> > + peer = qemu_get_peer(ncs, i);
> > + r = vhost_net_start_one(get_vhost_net(peer), dev);
> >
> > if (r < 0) {
> > goto err_start;
> > @@ -343,7 +346,7 @@ int vhost_net_start(VirtIODevice *dev, NetClientState *ncs,
> >
> > if (ncs[i].peer->vring_enable) {
> > /* restore vring enable state */
> > - r = vhost_set_vring_enable(ncs[i].peer, ncs[i].peer->vring_enable);
> > + r = vhost_set_vring_enable(peer, peer->vring_enable);
> >
> > if (r < 0) {
> > goto err_start;
> > @@ -355,7 +358,8 @@ int vhost_net_start(VirtIODevice *dev, NetClientState *ncs,
> >
> > err_start:
> > while (--i >= 0) {
> > - vhost_net_stop_one(get_vhost_net(ncs[i].peer), dev);
> > + peer = qemu_get_peer(ncs , i);
> > + vhost_net_stop_one(get_vhost_net(peer), dev);
> > }
> > e = k->set_guest_notifiers(qbus->parent, total_queues * 2, false);
> > if (e < 0) {
>
next prev parent reply other threads:[~2020-05-09 6:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 16:32 [RFC v2 0/9] vDPA support in qemu Cindy Lu
2020-05-08 16:32 ` [RFC v2 1/9] net: introduce qemu_get_peer Cindy Lu
2020-05-08 16:32 ` [RFC v2 2/9] net: use the function qemu_get_peer Cindy Lu
2020-05-09 2:19 ` Jason Wang
2020-05-09 6:49 ` Cindy Lu [this message]
2020-05-08 16:32 ` [RFC v2 3/9] virtio_net: introduce vhost_set_state Cindy Lu
2020-05-09 2:25 ` Jason Wang
2020-05-09 7:08 ` Cindy Lu
2020-05-08 16:32 ` [RFC v2 4/9] vhost-vdpa: introduce vhost-vdpa net client Cindy Lu
2020-05-08 16:41 ` Eric Blake
2020-05-09 7:17 ` Cindy Lu
2020-05-09 2:40 ` Jason Wang
2020-05-09 7:31 ` Cindy Lu
2020-05-08 16:32 ` [RFC v2 5/9] vhost-vdpa: implement vhost-vdpa backend Cindy Lu
2020-05-09 3:00 ` Jason Wang
2020-05-09 3:07 ` Jason Wang
2020-05-09 8:14 ` Cindy Lu
2020-05-21 12:40 ` Stefan Hajnoczi
2020-05-25 15:33 ` Cindy Lu
2020-05-25 16:15 ` Stefan Hajnoczi
2020-05-08 16:32 ` [RFC v2 6/9] virtio-bus: introduce queue_enabled method Cindy Lu
2020-05-09 3:01 ` Jason Wang
2020-05-09 6:50 ` Cindy Lu
2020-05-08 16:32 ` [RFC v2 7/9] virito-pci: implement " Cindy Lu
2020-05-09 3:02 ` Jason Wang
2020-05-09 12:01 ` Philippe Mathieu-Daudé
2020-05-11 5:08 ` Cindy Lu
2020-05-08 16:32 ` [RFC v2 8/9] vhost_net: set vq ready during start if necessary Cindy Lu
2020-05-09 3:03 ` Jason Wang
2020-05-09 6:51 ` Cindy Lu
2020-05-08 16:32 ` [RFC v2 9/9] vhost: introduce vhost_set_vring_ready method Cindy Lu
2020-05-09 3:05 ` Jason Wang
2020-05-09 3:10 ` [RFC v2 0/9] vDPA support in qemu Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACLfguUbYCL8hYATfSoRZ4nO3vTjaDGw8tRH3GzerZpGyx1Znw@mail.gmail.com \
--to=lulu@redhat.com \
--cc=aadam@redhat.com \
--cc=armbru@redhat.com \
--cc=cohuck@redhat.com \
--cc=cunming.liang@intel.com \
--cc=eperezma@redhat.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=jgg@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kevin.tian@intel.com \
--cc=lingshan.zhu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=mhabets@solarflare.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=qemu-devel@nongnu.org \
--cc=rdunlap@infradead.org \
--cc=rob.miller@broadcom.com \
--cc=saugatm@xilinx.com \
--cc=shahafs@mellanox.com \
--cc=stefanha@redhat.com \
--cc=vmireyno@marvell.com \
--cc=xiao.w.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).