From: Cindy Lu <lulu@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: rdunlap@infradead.org, Michael Tsirkin <mst@redhat.com>,
mhabets@solarflare.com, qemu-devel@nongnu.org,
rob.miller@broadcom.com, saugatm@xilinx.com,
Markus Armbruster <armbru@redhat.com>,
hch@infradead.org, Eugenio Perez Martin <eperezma@redhat.com>,
jgg@mellanox.com, Shahaf Shuler <shahafs@mellanox.com>,
kevin.tian@intel.com, parav@mellanox.com, vmireyno@marvell.com,
"Liang, Cunming" <cunming.liang@intel.com>,
gdawar@xilinx.com, jiri@mellanox.com, xiao.w.wang@intel.com,
Stefan Hajnoczi <stefanha@redhat.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>, Ariel Adam <aadam@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
hanand@xilinx.com, "Zhu, Lingshan" <lingshan.zhu@intel.com>
Subject: Re: [RFC v3 8/8] vhost-vdpa: introduce vhost-vdpa net client
Date: Wed, 3 Jun 2020 16:49:03 +0800 [thread overview]
Message-ID: <CACLfguUpFOW4CgMu=B6jOs6-eO56+JtPE-Xd+jGmNW2+Kh_ibw@mail.gmail.com> (raw)
In-Reply-To: <6ac66cf2-30d3-d87c-9ca5-0785f05984ad@redhat.com>
Hi Jason,
On Wed, Jun 3, 2020 at 4:43 PM Jason Wang <jasowang@redhat.com> wrote:
>
>
> On 2020/6/3 下午4:19, Cindy Lu wrote:
> >>> +static void vhost_vdpa_cleanup(NetClientState *nc)
> >>> +{
> >>> + VhostVDPAState *s = DO_UPCAST(VhostVDPAState, nc, nc);
> >>> +
> >>> + if (s->vhost_net) {
> >>> + vhost_net_cleanup(s->vhost_net);
> >>> + g_free(s->vhost_net);
> >>> + s->vhost_net = NULL;
> >>> + }
> >>> +
> >>> + qemu_purge_queued_packets(nc);
> >> Why this is needed?
> >>
> >> Thanks
> >>
> > This is to clean the packet in the queue while the vdpa remove, I
> > will double check this part
>
>
> Note we don't have a software backup driver for qemu currently (we
> probably need one in the future).
>
> So we can't fallback into userspace which means the packet can not be
> queued by qemu.
>
Got it, Thanks Jason, I will remove this part
> Thanks
>
next prev parent reply other threads:[~2020-06-03 8:50 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 14:06 [RFC v3 0/8] vDPA support in qemu Cindy Lu
2020-05-29 14:06 ` [RFC v3 1/8] net: introduce qemu_get_peer Cindy Lu
2020-06-11 9:07 ` Laurent Vivier
2020-06-11 13:12 ` Cindy Lu
2020-05-29 14:06 ` [RFC v3 2/8] vhost_net: use the function qemu_get_peer Cindy Lu
2020-06-16 7:47 ` Laurent Vivier
2020-05-29 14:06 ` [RFC v3 3/8] virtio-bus: introduce queue_enabled method Cindy Lu
2020-06-16 7:49 ` Laurent Vivier
2020-06-16 12:22 ` Cindy Lu
2020-05-29 14:06 ` [RFC v3 4/8] virtio-pci: implement " Cindy Lu
2020-06-16 7:56 ` Laurent Vivier
2020-05-29 14:06 ` [RFC v3 5/8] vhost: introduce vhost_set_vring_ready method Cindy Lu
2020-06-16 8:04 ` Laurent Vivier
2020-06-16 12:21 ` Cindy Lu
2020-05-29 14:06 ` [RFC v3 6/8] vhost-backend: export the vhost backend helper Cindy Lu
2020-06-16 8:16 ` Laurent Vivier
2020-06-17 3:03 ` Cindy Lu
2020-05-29 14:06 ` [RFC v3 7/8] vhost-vdpa: introduce vhost-vdpa backend Cindy Lu
2020-06-03 2:52 ` Jason Wang
2020-06-03 5:23 ` Cindy Lu
2020-06-03 2:53 ` Jason Wang
2020-06-03 5:23 ` Cindy Lu
2020-06-03 6:43 ` Jason Wang
2020-06-03 8:20 ` Cindy Lu
2020-06-04 10:39 ` Eugenio Perez Martin
2020-06-04 11:33 ` Michael S. Tsirkin
2020-06-08 14:46 ` Cindy Lu
2020-06-08 20:14 ` Eric Blake
2020-06-09 3:42 ` Cindy Lu
2020-06-15 14:44 ` Laurent Vivier
2020-06-16 8:52 ` Cindy Lu
2020-05-29 14:06 ` [RFC v3 8/8] vhost-vdpa: introduce vhost-vdpa net client Cindy Lu
2020-05-29 14:22 ` Eric Blake
2020-06-01 1:41 ` Cindy Lu
2020-06-03 6:39 ` Jason Wang
2020-06-03 8:19 ` Cindy Lu
2020-06-03 8:43 ` Jason Wang
2020-06-03 8:49 ` Cindy Lu [this message]
2020-05-29 20:29 ` [RFC v3 0/8] vDPA support in qemu no-reply
2020-05-29 20:33 ` no-reply
2020-05-29 20:37 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACLfguUpFOW4CgMu=B6jOs6-eO56+JtPE-Xd+jGmNW2+Kh_ibw@mail.gmail.com' \
--to=lulu@redhat.com \
--cc=aadam@redhat.com \
--cc=armbru@redhat.com \
--cc=cohuck@redhat.com \
--cc=cunming.liang@intel.com \
--cc=eperezma@redhat.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=jgg@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kevin.tian@intel.com \
--cc=lingshan.zhu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=mhabets@solarflare.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=qemu-devel@nongnu.org \
--cc=rdunlap@infradead.org \
--cc=rob.miller@broadcom.com \
--cc=saugatm@xilinx.com \
--cc=shahafs@mellanox.com \
--cc=stefanha@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=vmireyno@marvell.com \
--cc=xiao.w.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).