From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3833C433DF for ; Thu, 28 May 2020 07:28:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E88C207BC for ; Thu, 28 May 2020 07:28:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="gtJlR3TF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E88C207BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeCxi-0006Ae-8X for qemu-devel@archiver.kernel.org; Thu, 28 May 2020 03:28:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeCvT-0004DS-5g; Thu, 28 May 2020 03:26:03 -0400 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:38765) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jeCvR-0000RG-FU; Thu, 28 May 2020 03:26:02 -0400 Received: by mail-ed1-x542.google.com with SMTP id c35so6034529edf.5; Thu, 28 May 2020 00:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=UyKF229qgjHG717Dm40mZ4mp6YV3xxxM/oUcFKIsZ30=; b=gtJlR3TFpbCXwPCQ/mHvnXQy+yNU55dciiB+iywBKJBUWbiBqK5LqrJRmq0F853DIh bwzws1yLnibNb7Gy5maEmWegbv7edOGWDrIsd4gxGsR4ZTu9de8up/el81LeSttC/DFG 8Dx8aW9QMKhrHaTcnLvZgBdIRKLrYj/BEkDiE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UyKF229qgjHG717Dm40mZ4mp6YV3xxxM/oUcFKIsZ30=; b=ZQZdvIYu1+THooVJW4zC2V51K4DDxdq+kTvn5kVLWyUl+b4YxmnqgRon74X3oqrMpP gBtGccJLY0VNyiLrGnpgFTCYNQYv1vd0yh5/tGEChihQkimy1iVcScWNCAfOnUb5LO7s ifjhTEnZ0Uda16WiGrYNKbf/pk5khmX7JGT8Rs0PwGfwI+Q6wc9QPZf/TjqU9+qV8RW2 ONL8xXPHe5ljpWKBuNrb82ftYIS1E/Hxm1jReDWgz93baDiN+U5/ktmK8XIsVBZCGaQ9 6jaCB0ONkOqk9xwEHtVsOtOiXEmnu6bwBPNPRWfKXf35mHQXdaR3uMKt3/MHdLztq18p cbAQ== X-Gm-Message-State: AOAM531nA8qohvE6O6z/krNdqBeo10y1SZFBKgK8DSKayvEpy6lD0U6f H5CMuWXbN4ucGdqqxzcPDArTC7DOkf6ibDsOc4M= X-Google-Smtp-Source: ABdhPJxlLjyCrSLccfBVA2fYAf0Iiaa+1Me0dANqa07pjZ0UJorYXWaokdDmfYRauHoFYeTCORKTEqK8gRayDkZp+Wk= X-Received: by 2002:a50:e08c:: with SMTP id f12mr1667557edl.233.1590650758836; Thu, 28 May 2020 00:25:58 -0700 (PDT) MIME-Version: 1.0 References: <20200527124406.329503-1-clg@kaod.org> In-Reply-To: <20200527124406.329503-1-clg@kaod.org> From: Joel Stanley Date: Thu, 28 May 2020 07:25:47 +0000 Message-ID: Subject: Re: [PATCH v3] arm/aspeed: Rework NIC attachment To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::542; envelope-from=joel.stan@gmail.com; helo=mail-ed1-x542.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrew Jeffery , Markus Armbruster , QEMU Developers , qemu-arm , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 27 May 2020 at 12:44, C=C3=A9dric Le Goater wrote: > > The number of MACs supported by an Aspeed SoC is defined by "macs_num" > under the SoC model, that is two for the AST2400 and AST2500 and four > for the AST2600. The model initializes the maximum number of supported > MACs but the number of realized devices is capped by the number of > network device back-ends defined on the command line. This can leave > unrealized devices hanging around in the QOM composition tree. > > Modify the machine initialization to define which MACs are attached to > a network device back-end using a bit-field property "macs-mask" and > let the SoC realize all network devices. > > The default setting of "macs-mask" is "use MAC0" only, which works for > all our AST2400 and AST2500 machines. The AST2600 machines have > different configurations. The AST2600 EVB machine activates MAC1, MAC2 > and MAC3 and the Tacoma BMC machine activates MAC2. > > Inactive MACs will have no peer and QEMU may warn the user with : > > qemu-system-arm: warning: nic ftgmac100.0 has no peer > qemu-system-arm: warning: nic ftgmac100.1 has no peer > qemu-system-arm: warning: nic ftgmac100.3 has no peer > > Signed-off-by: C=C3=A9dric Le Goater > Reviewed-by: Markus Armbruster Reviewed-by: Joel Stanley This is a good usability improvement, thanks C=C3=A9dric. > @@ -680,6 +691,7 @@ static void aspeed_machine_ast2600_evb_class_init(Obj= ectClass *oc, void *data) > amc->fmc_model =3D "w25q512jv"; > amc->spi_model =3D "mx66u51235f"; > amc->num_cs =3D 1; > + amc->macs_mask =3D ASPEED_MAC1_ON | ASPEED_MAC2_ON | ASPEED_MAC3_ON= ; In the future we could enable all four. The A0 silicon had a broken MAC4 but it is working on A1.