From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AAD0C433ED for ; Fri, 9 Apr 2021 07:01:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1D64610FC for ; Fri, 9 Apr 2021 07:01:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1D64610FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUl8u-0002C9-Pu for qemu-devel@archiver.kernel.org; Fri, 09 Apr 2021 03:01:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUl5V-0000Jk-I0; Fri, 09 Apr 2021 02:57:53 -0400 Received: from mail-qt1-x836.google.com ([2607:f8b0:4864:20::836]:45625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lUl5U-000521-6J; Fri, 09 Apr 2021 02:57:53 -0400 Received: by mail-qt1-x836.google.com with SMTP id u8so3452567qtq.12; Thu, 08 Apr 2021 23:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BMIdbb5+q2+8P4LA0fA5kKKjKdwZMjpMAxjD8O+1Igk=; b=iD4t8WAbi7Cp2oo21ZNob2gTmHCao8aGQm8Kv3liPjk+Aobg0CtnyH2hsjea6DiEUW WizLsAKATCvy+9KXQdCOdv/7rRT9l6wXa6LYkTN/YmNMhqvcCD9cbdRM7H1nc9m3KXgl mpiGM+qvctso7nYhlMeXWnFqYeHu7k6WSdDhE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BMIdbb5+q2+8P4LA0fA5kKKjKdwZMjpMAxjD8O+1Igk=; b=HhJWgs2a09xgnQg1iueAC7Ov4BIT8u6xbf37VybirzCnBHMxRC4TeGj/Y3wuuR6hrs xHn7+Ws2CbJQKarQKZJFKmmF6uh7rWFE1jZw1tgIs2IutO1ezmtYbm0yWOJnBo3qB3E5 1OTrRH9RX2jnoG6gcjkKA278LGz+KlCg5/YkV7eO4AUoAPaX/e3DwLtvY4TMmkGBrirV NttPm8fST3iRZZpQOCu3edNh4Qbzriw7lxf8Ce22biU7C1kdWvSM3K1T5GieUB1jbdRP BPP/sabYdtrugSFGYIi05oGTlH8nNGciqvd7PV8PCXyQHdkE1EuSHTavFpqsH+p3KoYa k28g== X-Gm-Message-State: AOAM531w12aygsWWq8n8f4dlB2CvpX60/u5PpwzBvHZhW+E0by3wbVnv LZ18cQGF02XuHhlI6cc7cZaPifWBo31ZQGEZgdo= X-Google-Smtp-Source: ABdhPJzsusBv2WiYhEO68Pr7O79GtAg5gyQK4Qdv9WhJjRGZojxBHEIsH+NozM5Uxpxr0lcHzmj9Kk6QEePvbTKOpEs= X-Received: by 2002:ac8:7547:: with SMTP id b7mr11831054qtr.176.1617951470971; Thu, 08 Apr 2021 23:57:50 -0700 (PDT) MIME-Version: 1.0 References: <20210407171637.777743-1-clg@kaod.org> <20210407171637.777743-19-clg@kaod.org> In-Reply-To: <20210407171637.777743-19-clg@kaod.org> From: Joel Stanley Date: Fri, 9 Apr 2021 06:57:39 +0000 Message-ID: Subject: Re: [PATCH 18/24] aspeed: Add support for the rainier-bmc board To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::836; envelope-from=joel.stan@gmail.com; helo=mail-qt1-x836.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , Peter Maydell , qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 7 Apr 2021 at 17:17, C=C3=A9dric Le Goater wrote: > > The Rainer BMC board is a board for the middle range POWER10 IBM systems. Rainier > > Signed-off-by: C=C3=A9dric Le Goater Reviewed-by: Joel Stanley > --- > hw/arm/aspeed.c | 79 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 79 insertions(+) > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > index 97dcca74feb4..19588e17fec8 100644 > --- a/hw/arm/aspeed.c > +++ b/hw/arm/aspeed.c > @@ -135,6 +135,10 @@ struct AspeedMachineState { > #define TACOMA_BMC_HW_STRAP1 0x00000000 > #define TACOMA_BMC_HW_STRAP2 0x00000040 > > +/* Rainier hardware value: (QEMU prototype) */ Can we drop the prototype comment? > +#define RAINIER_BMC_HW_STRAP1 0x00000000 > +#define RAINIER_BMC_HW_STRAP2 0x00000000