qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
To: Julia Suvorova <jusual@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
	David Gibson <dgibson@redhat.com>,
	qemu devel list <qemu-devel@nongnu.org>,
	Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v5 0/7] Use ACPI PCI hot-plug for Q35
Date: Tue, 6 Jul 2021 16:30:19 +0300	[thread overview]
Message-ID: <CAC_L=vXCYSw4UXNXfyv_PfROBA0sNUWrht2me=KvzcwNEkoVJw@mail.gmail.com> (raw)
In-Reply-To: <20210617190739.3673064-1-jusual@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

Hi Julia,

On Thu, Jun 17, 2021 at 10:07 PM Julia Suvorova <jusual@redhat.com> wrote:

> The patch set consists of two parts:
> patches 1-4: introduce new feature
>              'acpi-pci-hotplug-with-bridge-support' on Q35
> patches 5-7: make the feature default along with changes in ACPI tables
>
>
I have tested the patches and I noticed 2 issues:
1. The changes allow to hotplug a device into the pcie.0 bus (device_add
e1000)
    - The device can be seen using `info qtree` but is not visible in guest.
   pcie.0 bus should not support hotplug at all.
  Before the series we get:
       Error: Bus 'pcie.0' does not support hotplugging
2.  The devices hotplugged into a pcie-root-port are not allocated IO space:
    device_add e1000,id=e1,bus=rp1
    In dmesg I see:
         [   24.699178] pci 0000:01:00.0: BAR 1: no space for [io  size
0x0040]
         [  24.699753] pci 0000:01:00.0: BAR 1: failed to assign [io  size
0x0040]
   And in lspci I see:
        I/O ports at <unassigned> [disabled]
  Before the series:
      I/O ports at 1000 [size=64]


Could you please check?

Thanks,
Marcel

[-- Attachment #2: Type: text/html, Size: 1931 bytes --]

      parent reply	other threads:[~2021-07-06 13:32 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 19:07 [PATCH v5 0/7] Use ACPI PCI hot-plug for Q35 Julia Suvorova
2021-06-17 19:07 ` [PATCH v5 1/7] hw/acpi/pcihp: Enhance acpi_pcihp_disable_root_bus() to support Q35 Julia Suvorova
2021-06-23 10:26   ` Marcel Apfelbaum
2021-07-01  4:17   ` David Gibson
2021-07-03  6:19   ` Michael S. Tsirkin
2021-07-03  7:11   ` Michael S. Tsirkin
2021-06-17 19:07 ` [PATCH v5 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35 Julia Suvorova
2021-06-23 10:39   ` Marcel Apfelbaum
2021-07-01  4:36   ` David Gibson
2021-07-02 14:35     ` Michael S. Tsirkin
2021-06-17 19:07 ` [PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug Julia Suvorova
2021-06-23 10:46   ` Marcel Apfelbaum
2021-07-01  4:46   ` David Gibson
2021-07-02 14:36     ` Michael S. Tsirkin
2021-07-02 14:55     ` Julia Suvorova
2021-07-02 15:34       ` Michael S. Tsirkin
2021-07-03  2:51       ` David Gibson
2021-06-17 19:07 ` [PATCH v5 4/7] hw/pci/pcie: Do not set HPC flag if acpihp is used Julia Suvorova
2021-06-17 21:02   ` Michael S. Tsirkin
2021-06-23 11:02     ` Marcel Apfelbaum
2021-06-18 11:54   ` Igor Mammedov
2021-06-18 12:39     ` Michael S. Tsirkin
2021-07-01  4:50   ` David Gibson
2021-06-17 19:07 ` [PATCH v5 5/7] bios-tables-test: Allow changes in DSDT ACPI tables Julia Suvorova
2021-06-23 11:03   ` Marcel Apfelbaum
2021-06-17 19:07 ` [PATCH v5 6/7] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35 Julia Suvorova
2021-06-23 11:13   ` Marcel Apfelbaum
2021-06-17 19:07 ` [PATCH v5 7/7] bios-tables-test: Update golden binaries Julia Suvorova
2021-07-01  4:54   ` David Gibson
2021-07-01  8:36     ` Igor Mammedov
2021-06-17 21:02 ` [PATCH v5 0/7] Use ACPI PCI hot-plug for Q35 Michael S. Tsirkin
2021-06-23 14:47 ` [PATCH] hw/pci/pcie_port: Rename "enable-native-hotplug" property Julia Suvorova
2021-06-24  6:31   ` Igor Mammedov
2021-06-24 12:29   ` Marcel Apfelbaum
2021-07-01  4:55   ` David Gibson
2021-07-03 16:45 ` [PATCH v5 0/7] Use ACPI PCI hot-plug for Q35 Michael S. Tsirkin
2021-07-06 13:30 ` Marcel Apfelbaum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAC_L=vXCYSw4UXNXfyv_PfROBA0sNUWrht2me=KvzcwNEkoVJw@mail.gmail.com' \
    --to=marcel.apfelbaum@gmail.com \
    --cc=dgibson@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jusual@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).