qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mahmoud Mandour <ma.mandourr@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] plugins/syscall: Added a table-like summary output
Date: Fri, 16 Apr 2021 09:19:53 +0200	[thread overview]
Message-ID: <CAD-LL6jDxVBx_Cj9=FydPrOWfXs3aJCNnkKuvWMQLfc+1=8LuA@mail.gmail.com> (raw)
In-Reply-To: <CAD-LL6h1Q5QuccmPoR9jTesM8axLFRN2Hy+Hm85fcXYRPR0KTw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 684 bytes --]

On Fri, Apr 16, 2021 at 8:54 AM Mahmoud Mandour <ma.mandourr@gmail.com>
wrote:

> On Thu, Apr 15, 2021 at 5:20 PM Mahmoud Mandour <ma.mandourr@gmail.com>
> wrote:
>
>>
>> Hello. I just realized that this hunk:
>
> static void vcpu_syscall_ret(qemu_plugin_id_t id, unsigned int vcpu_idx,
>>                               int64_t num, int64_t ret)
>> +{
>> +        // ......
>> +        if (!syscall_entry) {
>> +            qemu_plugin_outs(g_strdup_printf("%" PRIi64 "\n", num));
>> +        }
>>
>
> Is completely superfluous. I think I had it for debugging purposes.
> Should I resend without it or can you omit it from the patch?
>
>
Nevermind, I sent a v2 patch.

Yours,
Mahmoud

[-- Attachment #2: Type: text/html, Size: 1698 bytes --]

      reply	other threads:[~2021-04-16  7:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 15:18 [PATCH] plugins/syscall: Added a table-like summary output Mahmoud Mandour
2021-04-16  6:54 ` Mahmoud Mandour
2021-04-16  7:19   ` Mahmoud Mandour [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD-LL6jDxVBx_Cj9=FydPrOWfXs3aJCNnkKuvWMQLfc+1=8LuA@mail.gmail.com' \
    --to=ma.mandourr@gmail.com \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).