From: Paul Zimmerman <pauldzim@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>, Thomas Huth <thuth@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH for-5.1] hw: Only compile the usb-dwc2 controller if it is really needed
Date: Wed, 22 Jul 2020 21:36:27 -0700 [thread overview]
Message-ID: <CADBGO79TMy+-hM3qUKBrE5U9OY6Pq+2LVe6iozDTzrWFYVhQoQ@mail.gmail.com> (raw)
In-Reply-To: <1aa53dfa-92a0-3866-2117-a7ce450d278f@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]
Gerd, it's OK by me if you take Thomas's patch instead, I agree the
changelog is better. It also has a fixes tag.
Reviewed-by: Paul Zimmerman <pauldzim@gmail.com>
On Wed, Jul 22, 2020 at 9:29 PM Thomas Huth <thuth@redhat.com> wrote:
> On 22/07/2020 19.23, Philippe Mathieu-Daudé wrote:
> > On 7/22/20 5:47 PM, Thomas Huth wrote:
> >> The USB_DWC2 switch is currently "default y", so it is included in all
> >> qemu-system-* builds, even if it is not needed. Even worse, it does a
> >> "select USB", so USB devices are now showing up as available on targets
> >> that do not support USB at all. This sysbus device should only be
> >> included by the boards that need it, i.e. by the Raspi machines.
> >
> > Paul already sent that patch (your description is better although):
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg723681.html
>
> Oh, thanks for the pointer, I should have checked my qemu-devel folder
> first... Please disregard my patch!
>
> Thomas
>
>
[-- Attachment #2: Type: text/html, Size: 1853 bytes --]
next prev parent reply other threads:[~2020-07-23 4:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 15:47 [PATCH for-5.1] hw: Only compile the usb-dwc2 controller if it is really needed Thomas Huth
2020-07-22 17:23 ` Philippe Mathieu-Daudé
2020-07-23 4:28 ` Thomas Huth
2020-07-23 4:36 ` Paul Zimmerman [this message]
2020-07-24 14:14 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADBGO79TMy+-hM3qUKBrE5U9OY6Pq+2LVe6iozDTzrWFYVhQoQ@mail.gmail.com \
--to=pauldzim@gmail.com \
--cc=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).