From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89723C433DB for ; Mon, 1 Mar 2021 16:08:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 923E564DF5 for ; Mon, 1 Mar 2021 16:08:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 923E564DF5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGl6B-0006l8-GU for qemu-devel@archiver.kernel.org; Mon, 01 Mar 2021 11:08:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGl5V-0006Cc-Cb for qemu-devel@nongnu.org; Mon, 01 Mar 2021 11:08:02 -0500 Received: from mail-vk1-xa2e.google.com ([2607:f8b0:4864:20::a2e]:40019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGl5T-00025M-Fq for qemu-devel@nongnu.org; Mon, 01 Mar 2021 11:08:01 -0500 Received: by mail-vk1-xa2e.google.com with SMTP id s12so2086585vkh.7 for ; Mon, 01 Mar 2021 08:07:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aHYT4GZCC6ve2Rk4CMzEzIuV0Aw8+WhooLStYyfh4DU=; b=v0TV24ztnJ6wwPFgQRYKKDjUQMzDr9/mNQsSkADY34IRlv1SWffANtX9+mXETazShu IWVDhyP+4HB6oDncb1aYCNY53rl+sTEj1t1ClbYOTT6TVcxZlo0QKa05bMeRs02zOu1w p3TaqkSDVaZMyaeF8sHYhCjdBOM0v+DHaZzN1WlD/4sqajBtNv2MqDgm463X7o3NfOtP Rrnbe0ZeRKYn18Hvk4npYD7c3GPOfJqeIX9fROG1XrG3RaPajBa9zinXaBjEqKkrnW6M IAQp0gwjOCp4dGBnvCj1Y19ayyzPQy3BMVuErZEa0YgA+ROrQ857dMoT036iUpz0VOZO IrtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aHYT4GZCC6ve2Rk4CMzEzIuV0Aw8+WhooLStYyfh4DU=; b=JkBiFzh2G3BISxBo6PbengEapp9qqAjieS9jTUG8xpDsAWB7VzovUHSj+5VvYsOBOB DZaBcs26aF6Z9fwYmntUtfjNI3yftM0yeRFUijW7rm77Ixihrc1eRpLFkQ8lQexnHIiW r1MG1RGx3hWmG4QCnV38ZZ3wX1Dpir5hjPld8B749ydUiesVGHfX1TS/ZJi6h+jTu5lA ncFPDxEnCsPUYnz/lewFDNycHOhxacm7M5PAaOmyYy9xZ+d6YuBR3ghdgzqEGK8UkueM C/cAUO4fcStWwbFvMdnqCTL9pkwTORvEdiCi01GOPRQ4Nd5yNsaz+wpf8BQSLZAosOvH yP3w== X-Gm-Message-State: AOAM533oHHqrjjNm5jWI9D7+33ne6UtLs+LCM3jOTd0d+6V/ZzHyVKNA NWZEIZnSHWEdZjlRj8wrsxwSsZVtQQzriHuZDiXG4A== X-Google-Smtp-Source: ABdhPJzNtAVna5V4Z6cCK7XARYCLfC1W+WHdiuZb4H0rD4j8CA/uoK+2zhS8Y9ZR+JfmvjdauatmVwJM28MitsOj2vM= X-Received: by 2002:a1f:a452:: with SMTP id n79mr4911300vke.8.1614614876748; Mon, 01 Mar 2021 08:07:56 -0800 (PST) MIME-Version: 1.0 References: <20210228213957.xkc4cceh5o6rgd5n@begin> In-Reply-To: <20210228213957.xkc4cceh5o6rgd5n@begin> From: Doug Evans Date: Mon, 1 Mar 2021 08:07:19 -0800 Message-ID: Subject: Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse To: Samuel Thibault Cc: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Markus Armbruster , QEMU Developers , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Content-Type: multipart/alternative; boundary="0000000000002e91cc05bc7bd295" Received-SPF: pass client-ip=2607:f8b0:4864:20::a2e; envelope-from=dje@google.com; helo=mail-vk1-xa2e.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000002e91cc05bc7bd295 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault wrote: > Hello, > > Daniel P. Berrang=C3=A9, le lun. 22 f=C3=A9vr. 2021 09:39:41 +0000, a ecr= it: > > > The is_v6 flag is only needed > > for the legacy compat needs in slirp, even that is only if we want to > > have strict equivalence with historical behaviour, as opposed to changi= ng > > empty string to mean to listen on both IPv4+6 concurrently.. > > I would say that empty address meaning ipv4+6 looks better to me. > It's not my call, but I have some questions. Are there any users that this functional change would break? [Previously the empty address meant qemu would only listen on ipv4 addr-any.] What if a user wants only ipv4 addr-any (or only ipv6 addr-any) ? What does hostfwd "::12345-6.7.8.9:10" mean? Does the presence of the empty host address mean forward both ipv4 and ipv6 to guest ipv4 6.7.8.9? --0000000000002e91cc05bc7bd295 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:<= br>
Hello,

Daniel P. Berrang=C3=A9, le lun. 22 f=C3=A9vr. 2021 09:39:41 +0000, a ecrit= :

> The is_v6 flag is only needed
> for the legacy compat needs in slirp, even that is only if we want to =
> have strict equivalence with historical behaviour, as opposed to chang= ing
> empty string to mean to listen on both IPv4+6 concurrently..

I would say that empty address meaning ipv4+6 looks better to me.


It&= #39;s not my call, but I have some questions.

Are there any users that this functional ch= ange would break?
[Previously the empty address meant qemu would only listen on ipv4= addr-any.]
What if a use= r wants only ipv4 addr-any (or only ipv6 addr-any) ?

What does hostfwd "::12345-6.7.8.9:10"= ; mean?
Does th= e presence of the empty host address mean forward both ipv4 and ipv6 to gue= st ipv4 6.7.8.9?

--0000000000002e91cc05bc7bd295--